[GeoNetwork-devel] Building GN & skipping tests

GeoNetwork GeoNetwork Developer
,
1

Hi list,

is -DskipTests still required to build geonetwork, or is it a local error of
mine?

In the first case, wouldn't it be nicer to add @Ignore where needed, in order
to help whoever wishes to help fixing?

   Thanks,
   Emanuele

--

GeoServer Professional Services from the experts!
Visit http://goo.gl/NWWaa2 for more information.

Ing. Emanuele Tajariol
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 380 2116282

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

2

Hi Emanuele,

···

2015-09-07 20:21 GMT+02:00 Emanuele Tajariol <etj@anonymised.com>:

Hi list,

is -DskipTests still required to build geonetwork, or is it a local error of
mine?

In the first case, wouldn’t it be nicer to add @Ignore where needed, in order
to help whoever wishes to help fixing?

+1.

Francois

Thanks,
Emanuele

–

GeoServer Professional Services from the experts!
Visit http://goo.gl/NWWaa2 for more information.

Ing. Emanuele Tajariol
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 380 2116282

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

3

On Tue, Sep 8, 2015 at 7:28 AM, Francois Prunayre <fx.prunayre@anonymised.com>
wrote:

Hi Emanuele,

2015-09-07 20:21 GMT+02:00 Emanuele Tajariol <etj@anonymised.com>:

Hi list,

is -DskipTests still required to build geonetwork, or is it a local error
of
mine?

In the first case, wouldn't it be nicer to add @Ignore where needed, in
order
to help whoever wishes to help fixing?

+1.

+1 Or even better: fix the tests that are failing right now so we can run
the full build without problems.

One of the main problems I see right now is that the build is sooo slow
that nobody enables the tests unless it is very obvious that the change you
have made needs an update on the tests. Am I right here?

Francois

   Thanks,
   Emanuele

--

GeoServer Professional Services from the experts!
Visit http://goo.gl/NWWaa2 for more information.

Ing. Emanuele Tajariol
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 380 2116282

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

------------------------------------------------------------------------------
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at
http://sourceforge.net/projects/geonetwork

------------------------------------------------------------------------------

_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at
http://sourceforge.net/projects/geonetwork

4

Hi,

+1 Or even better: fix the tests that are failing right now so we can run
the full build without problems.

I guess that a good starting point would be to allow the working tests to be
run.

I created an issue for topic:
   https://github.com/geonetwork/core-geonetwork/issues/1176
It also includes the temporary removal of the findbugs plugin: tests are not
working, adding one more layer of code checking seems overkill to me.

I have a commit ready to be pushed if you agree.
I'd like to add these changes to the 3.0.x stable branch, in order to make it
a bit more stable :).

   Cheers,
   Emanuele

Alle 08:34:52 di Tuesday 8 September 2015, María Arias de Reyna ha scritto:

On Tue, Sep 8, 2015 at 7:28 AM, Francois Prunayre <fx.prunayre@anonymised.com>

wrote:
> Hi Emanuele,
>
> 2015-09-07 20:21 GMT+02:00 Emanuele Tajariol <etj@anonymised.com>:
>> Hi list,
>>
>> is -DskipTests still required to build geonetwork, or is it a local
>> error of
>> mine?
>>
>> In the first case, wouldn't it be nicer to add @Ignore where needed, in
>> order
>> to help whoever wishes to help fixing?
>
> +1.

+1 Or even better: fix the tests that are failing right now so we can run
the full build without problems.

One of the main problems I see right now is that the build is sooo slow
that nobody enables the tests unless it is very obvious that the change you
have made needs an update on the tests. Am I right here?

> Francois
>
>> Thanks,
>> Emanuele

--

GeoServer Professional Services from the experts!
Visit http://goo.gl/NWWaa2 for more information.

Ing. Emanuele Tajariol
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 380 2116282

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

5

Hi devs,

you may have seen the users mailing list, where it has been noticed that the
travis build is failing since long.
Since the PR related to
   https://github.com/geonetwork/core-geonetwork/issues/1176
also solves this problem, I would merge it if you agree (there have been +1
only on the idea, but not on the PR yet :slight_smile: )

   Thanks,
   Emanuele

Alle 17:20:24 di Tuesday 8 September 2015, Emanuele Tajariol ha scritto:

Hi,

> +1 Or even better: fix the tests that are failing right now so we can run
> the full build without problems.

I guess that a good starting point would be to allow the working tests to
be run.

I created an issue for topic:
   https://github.com/geonetwork/core-geonetwork/issues/1176
It also includes the temporary removal of the findbugs plugin: tests are
not working, adding one more layer of code checking seems overkill to me.

I have a commit ready to be pushed if you agree.
I'd like to add these changes to the 3.0.x stable branch, in order to make
it a bit more stable :).

   Cheers,
   Emanuele

Alle 08:34:52 di Tuesday 8 September 2015, María Arias de Reyna ha scritto:
> On Tue, Sep 8, 2015 at 7:28 AM, Francois Prunayre <fx.prunayre@anonymised.com>
>
> wrote:
> > Hi Emanuele,
> >
> > 2015-09-07 20:21 GMT+02:00 Emanuele Tajariol <etj@anonymised.com>:
> >> Hi list,
> >>
> >> is -DskipTests still required to build geonetwork, or is it a local
> >> error of
> >> mine?
> >>
> >> In the first case, wouldn't it be nicer to add @Ignore where needed,
> >> in order
> >> to help whoever wishes to help fixing?
> >
> > +1.
>
> +1 Or even better: fix the tests that are failing right now so we can run
> the full build without problems.
>
> One of the main problems I see right now is that the build is sooo slow
> that nobody enables the tests unless it is very obvious that the change
> you have made needs an update on the tests. Am I right here?
>
> > Francois
> >
> >> Thanks,
> >> Emanuele

--

GeoServer Professional Services from the experts!
Visit http://goo.gl/NWWaa2 for more information.

Ing. Emanuele Tajariol
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 380 2116282

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

6

Hi Emanuele

+1 for me also, please merge it.

Regards,
Jose García

···

On Thu, Sep 24, 2015 at 10:44 AM, Emanuele Tajariol <etj@anonymised.com> wrote:

Hi devs,

you may have seen the users mailing list, where it has been noticed that the
travis build is failing since long.
Since the PR related to
https://github.com/geonetwork/core-geonetwork/issues/1176
also solves this problem, I would merge it if you agree (there have been +1
only on the idea, but not on the PR yet :slight_smile: )

Thanks,
Emanuele

Alle 17:20:24 di Tuesday 8 September 2015, Emanuele Tajariol ha scritto:

Hi,

+1 Or even better: fix the tests that are failing right now so we can run
the full build without problems.

I guess that a good starting point would be to allow the working tests to
be run.

I created an issue for topic:
https://github.com/geonetwork/core-geonetwork/issues/1176
It also includes the temporary removal of the findbugs plugin: tests are
not working, adding one more layer of code checking seems overkill to me.

I have a commit ready to be pushed if you agree.
I’d like to add these changes to the 3.0.x stable branch, in order to make
it a bit more stable :).

Cheers,
Emanuele

Alle 08:34:52 di Tuesday 8 September 2015, María Arias de Reyna ha scritto:

On Tue, Sep 8, 2015 at 7:28 AM, Francois Prunayre <fx.prunayre@anonymised.com>

wrote:

Hi Emanuele,

2015-09-07 20:21 GMT+02:00 Emanuele Tajariol <etj@anonymised.com>:

Hi list,

is -DskipTests still required to build geonetwork, or is it a local
error of
mine?

In the first case, wouldn’t it be nicer to add @Ignore where needed,
in order
to help whoever wishes to help fixing?

+1.

+1 Or even better: fix the tests that are failing right now so we can run
the full build without problems.

One of the main problems I see right now is that the build is sooo slow
that nobody enables the tests unless it is very obvious that the change
you have made needs an update on the tests. Am I right here?

Francois

Thanks,
Emanuele

–

GeoServer Professional Services from the experts!
Visit http://goo.gl/NWWaa2 for more information.

Ing. Emanuele Tajariol
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 380 2116282

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
Get real-time metrics from all of your servers, apps and tools
in one place.
SourceForge users - Click here to start your Free Trial of Datadog now!
http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

–

Vriendelijke groeten / Kind regards,

Jose García


Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664
M: +31 (0)655 818332

Please consider the environment before printing this email.

7

+1 as well

···

On Thu, Sep 24, 2015 at 10:46 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi Emanuele

+1 for me also, please merge it.

Regards,
Jose García

Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
Get real-time metrics from all of your servers, apps and tools
in one place.
SourceForge users - Click here to start your Free Trial of Datadog now!
http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

–

On Thu, Sep 24, 2015 at 10:44 AM, Emanuele Tajariol <etj@anonymised.com> wrote:

Hi devs,

you may have seen the users mailing list, where it has been noticed that the
travis build is failing since long.
Since the PR related to
https://github.com/geonetwork/core-geonetwork/issues/1176
also solves this problem, I would merge it if you agree (there have been +1
only on the idea, but not on the PR yet :slight_smile: )

Thanks,
Emanuele

Alle 17:20:24 di Tuesday 8 September 2015, Emanuele Tajariol ha scritto:

Hi,

+1 Or even better: fix the tests that are failing right now so we can run
the full build without problems.

I guess that a good starting point would be to allow the working tests to
be run.

I created an issue for topic:
https://github.com/geonetwork/core-geonetwork/issues/1176
It also includes the temporary removal of the findbugs plugin: tests are
not working, adding one more layer of code checking seems overkill to me.

I have a commit ready to be pushed if you agree.
I’d like to add these changes to the 3.0.x stable branch, in order to make
it a bit more stable :).

Cheers,
Emanuele

Alle 08:34:52 di Tuesday 8 September 2015, María Arias de Reyna ha scritto:

On Tue, Sep 8, 2015 at 7:28 AM, Francois Prunayre <fx.prunayre@anonymised.com>

wrote:

Hi Emanuele,

2015-09-07 20:21 GMT+02:00 Emanuele Tajariol <etj@anonymised.com>:

Hi list,

is -DskipTests still required to build geonetwork, or is it a local
error of
mine?

In the first case, wouldn’t it be nicer to add @Ignore where needed,
in order
to help whoever wishes to help fixing?

+1.

+1 Or even better: fix the tests that are failing right now so we can run
the full build without problems.

One of the main problems I see right now is that the build is sooo slow
that nobody enables the tests unless it is very obvious that the change
you have made needs an update on the tests. Am I right here?

Francois

Thanks,
Emanuele

–

GeoServer Professional Services from the experts!
Visit http://goo.gl/NWWaa2 for more information.

Ing. Emanuele Tajariol
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 380 2116282

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
Get real-time metrics from all of your servers, apps and tools
in one place.
SourceForge users - Click here to start your Free Trial of Datadog now!
http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

–

Vriendelijke groeten / Kind regards,

Jose García


Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664
M: +31 (0)655 818332

Please consider the environment before printing this email.

camptocamp
INNOVATIVE SOLUTIONS
BY OPEN SOURCE EXPERTS

Florent Gravin
0479444492

8

Hi all,

PR merged, travis back to green on 3.0.x.
I'll port the changes to the develop branch as well.

   Cheers,
   Emanuele

Alle 10:48:52 di Thursday 24 September 2015, Florent Gravin ha scritto:

+1 as well

On Thu, Sep 24, 2015 at 10:46 AM, Jose Garcia <jose.garcia@anonymised.com>

wrote:
> Hi Emanuele
>
> +1 for me also, please merge it.
>
> Regards,
> Jose García
>
> On Thu, Sep 24, 2015 at 10:44 AM, Emanuele Tajariol
> <etj@anonymised.com>
>
> wrote:
>> Hi devs,
>>
>> you may have seen the users mailing list, where it has been noticed that
>> the
>> travis build is failing since long.
>> Since the PR related to
>>
>> https://github.com/geonetwork/core-geonetwork/issues/1176
>>
>> also solves this problem, I would merge it if you agree (there have been
>> +1
>> only on the idea, but not on the PR yet :slight_smile: )
>>
>> Thanks,
>> Emanuele
>>
>> Alle 17:20:24 di Tuesday 8 September 2015, Emanuele Tajariol ha scritto:
>> > Hi,
>> >
>> > > +1 Or even better: fix the tests that are failing right now so we
>> > > can
>>
>> run
>>
>> > > the full build without problems.
>> >
>> > I guess that a good starting point would be to allow the working tests
>>
>> to
>>
>> > be run.
>> >
>> > I created an issue for topic:
>> > https://github.com/geonetwork/core-geonetwork/issues/1176
>> >
>> > It also includes the temporary removal of the findbugs plugin: tests
>> > are not working, adding one more layer of code checking seems
>> > overkill to
>>
>> me.
>>
>> > I have a commit ready to be pushed if you agree.
>> > I'd like to add these changes to the 3.0.x stable branch, in order to
>>
>> make
>>
>> > it a bit more stable :).
>> >
>> > Cheers,
>> > Emanuele
>> >
>> > Alle 08:34:52 di Tuesday 8 September 2015, María Arias de Reyna ha
>>
>> scritto:
>> > > On Tue, Sep 8, 2015 at 7:28 AM, Francois Prunayre <
>>
>> fx.prunayre@anonymised.com>
>>
>> > > wrote:
>> > > > Hi Emanuele,
>> > > >
>> > > > 2015-09-07 20:21 GMT+02:00 Emanuele Tajariol <etj@anonymised.com
>> > > >
>> > > >> Hi list,
>> > > >>
>> > > >> is -DskipTests still required to build geonetwork, or is it a
>> > > >> local error of
>> > > >> mine?
>> > > >>
>> > > >> In the first case, wouldn't it be nicer to add @Ignore where
>>
>> needed,
>>
>> > > >> in order
>> > > >> to help whoever wishes to help fixing?
>> > > >
>> > > > +1.
>> > >
>> > > +1 Or even better: fix the tests that are failing right now so we
>> > > can
>>
>> run
>>
>> > > the full build without problems.
>> > >
>> > > One of the main problems I see right now is that the build is sooo
>>
>> slow
>>
>> > > that nobody enables the tests unless it is very obvious that the
>>
>> change
>>
>> > > you have made needs an update on the tests. Am I right here?
>> > >
>> > > > Francois
>> > > >
>> > > >> Thanks,
>> > > >> Emanuele
>>
>> --
>> ==
>> GeoServer Professional Services from the experts!
>> Visit http://goo.gl/NWWaa2 for more information.
>> ==
>>
>> Ing. Emanuele Tajariol
>> Technical Lead
>>
>> GeoSolutions S.A.S.
>> Via Poggio alle Viti 1187
>> 55054 Massarosa (LU)
>> Italy
>> phone: +39 0584 962313
>> fax: +39 0584 1660272
>> mob: +39 380 2116282
>>
>> http://www.geo-solutions.it
>> http://twitter.com/geosolutions_it
>>
>> -------------------------------------------------------
>>
>>
>> ------------------------------------------------------------------------
>> ------ Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
>> Get real-time metrics from all of your servers, apps and tools
>> in one place.
>> SourceForge users - Click here to start your Free Trial of Datadog now!
>> http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140
>> _______________________________________________
>> GeoNetwork-devel mailing list
>> GeoNetwork-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
>> GeoNetwork OpenSource is maintained at
>> http://sourceforge.net/projects/geonetwork
>
> --
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> *Vriendelijke groeten / Kind regards,Jose García
> <http://www.geocat.net/&gt;Veenderweg 136721 WD BennekomThe NetherlandsT:
> +31 (0)318 416664 <+31318416664>M: +31 (0)655 818332 <+31655818332>
> <https://www.facebook.com/geocatbv&gt; <https://twitter.com/geocat_bv&gt;
> <https://plus.google.com/u/1/+GeocatNetbv/posts&gt;Please consider the
> environment before printing this email.*
>
>
> -------------------------------------------------------------------------
> ----- Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
> Get real-time metrics from all of your servers, apps and tools
> in one place.
> SourceForge users - Click here to start your Free Trial of Datadog now!
> http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140
> _______________________________________________
> GeoNetwork-devel mailing list
> GeoNetwork-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
> GeoNetwork OpenSource is maintained at
> http://sourceforge.net/projects/geonetwork

--

GeoServer Professional Services from the experts!
Visit http://goo.gl/NWWaa2 for more information.

Ing. Emanuele Tajariol
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 380 2116282

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------