Hi Jeroen,
I agree with you on the shortcut - the reviewer should be able to 'Approve' without the record automatically becoming available to 'All'. Of course, if anyone wants that shortcut then they can override the default behaviour in their own overlay to include it - I'll comment it out in the DefaultStatusActions class, leaving it as an example of a shortcut that could be used if desired.
The underscore prefix on lucene fields, yes, a good opportunity to review this!
I've used it for the lucene fields _status and _statusChangeDate as this seems to be the convention for fields added to the index document by the java code in the indexMetadata method in DataManager.java. My understanding is that it is supposed to indicate that the field is set and managed by the GeoNetwork code, usually from a value in a database table. That is, these fields cannot be directly updated by the user eg. as part of a CSW transaction update request (and nearly all of them are not part of the metadata record anyway).
Note that the CSW server and other search services (like the one in the URL included in the status change emails) can still query most of these fields. They can be quite useful for the expert user to use in queries if they know something about the field eg. _status, _valid, _schema etc.
Cheers,
Simon
On 01/03/2012 03:18 AM, Jeroen Ticheler wrote:
Dear Simon,
First of all a Happy New Year to you (and to all others on this list!),
I quite like the proposal! I have a few questions and remarks:
- The parameters in the request are _status and _statusChangeDate , using the underscore. What's the reason for the underscore and is it a convention that you would like to be adopted more broadly? It is a bit confusing to me since no other parameters use this AFAIK in existing services!?
- The Reviewer automatically changes the privileges for the All group of a record when the status is set to Accepted. I don't really like that since it mixes two different things here: (1) is the metadata in good shape for publishing, and (2) who has access to it. This means that as a Reviewer I can't decide to Accept the record while it is only visible to a specific group of users. While I understand the convenience of the shortcut, I think it should not be taken. I have been thinking if there should be an "unless" scenario, but think it is not a good idea full stop 
The Editor or the Reviewer could set the preferred privileges, but unless the status is not Approved (or Retired!? Will those still be visible?) it will not be visible to others irrespective of the Group(s) they are member of.
Otherwise it is a good improvement for GeoNetwork!
Cheers,
Jeroen
On 24 dec. 2011, at 03:15, <Simon.Pigot@anonymised.com <mailto:Simon.Pigot@anonymised.com>> <Simon.Pigot@anonymised.com <mailto:Simon.Pigot@anonymised.com>> wrote:
Dear PSC,
A proposal to add metadata status (draft, submitted, approved, rejected and retired) and associated user interface functions is available at metadataworkflow – GeoNetwork opensource Developer website
The behaviours associated with status changes eg. status automatically set to draft when a record with approved status is edited or publish to 'all' when a record is approved, can be changed by replacing a java class which encapsulates these behaviours.
The idea behind this proposal is to provide better support metadata editing and publishing workflows.
A patch is attached to the proposal.
Cheers and thanks,
Simon
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create
new or port existing apps to sell to consumers worldwide. Explore the
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join <http://appdeveloper.intel.com/join>
http://p.sf.net/sfu/intel-appdev
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net <mailto:GeoNetwork-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork
____________________________________________________
*
**
*
*GeoCat*
*
* introducesBridge©
*
An extension to ArcGIS© to instantly publish data and metadata on GeoServer and GeoNetwork.
*
See http://geocat.net/> for more details.
*
**
*
Jeroen Ticheler
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
Tel: +31 (0)6 81286572
http://geocat.net
*
Please consider the environment before printing this email.
------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual
desktops for less than the cost of PCs and save 60% on VDI infrastructure
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork
Please consider the environment before printing this email.