[GeoNetwork-devel] Critical: Javascript functions being overwritten.

Dear all,

I’ve just raised the severity of http://trac.osgeo.org/geonetwork/ticket/560 to critical. Hope that’s OK!

Several javascript functions (see below) with the same name but different functionality are being created, but once compiled into the gn.editor.js, only the last one survives. This is silently breaking some intended functionality.

We could consider

  • not minifying them all together
  • namespacing them
  • move to a ‘common’ js file and create versions which are valid under all conditions (eg edit or show modes)

doAction

doTabAction

getHtmlTip

setBunload

Justin.

This email is only intended for the person to whom it is addressed and may contain confidential information. If you have received this email in error, please notify the sender and delete this email which must not be copied, distributed or disclosed to any other person.

Unless stated otherwise, the contents of this email are personal to the writer and do not represent the official view of Ordnance Survey. Nor can any contract be formed on Ordnance Survey's behalf via email. We reserve the right to monitor emails and attachments without prior notice.

Thank you for your cooperation.

Ordnance Survey
Adanac Drive
Southampton SO16 0AS
Tel: 08456 050505
http://www.ordnancesurvey.co.uk