[GeoNetwork-devel] Data manager swapElement but not attributes

Hi all, working on xlink support in DataManager, I'm having trouble with
the swapElement method which doesn't take care of attributes so it
should cause trouble swapping element with attributes such as
gco:isoType, gco:nilReason, xlink:href or others ...

Some of these attributes are also handled y the update-fixed-info
process so maybe the problem occur only under certain conditions.

Here is a patch to swap element's attributes and children.

Simon, could you review that and see if it has to be applied to trunk ?

Thanks a lot.
Ciao

Francois

(attachments)

swapElement.patch (2.04 KB)

Hi Francois,

Good detective work! I reckon you're right - its probably been hidden by update-fixed-info until now. I've added it to the code in the BlueNet MEST sandbox which I'm going to integrate later this week with the trunk (with a slightly different implementation).

Cheers and thanks again,
Simon

Francois-Xavier Prunayre wrote:

Hi all, working on xlink support in DataManager, I'm having trouble with
the swapElement method which doesn't take care of attributes so it
should cause trouble swapping element with attributes such as
gco:isoType, gco:nilReason, xlink:href or others ...

Some of these attributes are also handled y the update-fixed-info
process so maybe the problem occur only under certain conditions.

Here is a patch to swap element's attributes and children.

Simon, could you review that and see if it has to be applied to trunk ?

Thanks a lot.
Ciao

Francois

  ------------------------------------------------------------------------

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
------------------------------------------------------------------------

_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
geonetwork-devel List Signup and Options
GeoNetwork OpenSource is maintained at GeoNetwork - Geographic Metadata Catalog download | SourceForge.net

Hi Simon,

On mar, 2008-10-14 at 11:09 +1100, Simon Pigot wrote:

Good detective work! I reckon you're right

Yep but my patch was not. We need to detach attributes before swaping
it. I also added support of element with no child (but could also have
attributes). See the patch attached to the ticket:
http://trac.osgeo.org/geonetwork/ticket/77

- its probably been hidden by
update-fixed-info until now. I've added it to the code in the BlueNet
MEST sandbox which I'm going to integrate later this week with the trunk
(with a slightly different implementation).

Ok. I let you close the ticket once done.

Ciao.

Francois