[GeoNetwork-devel] Incorrect Schematron errors in Geonetwork.

I get incorrect failures from a Schematron rule that are caused by geonet:element entries remaining in the xml at the time the Schematron rule is evaluated.

Once exported, the xml validates correctly with the saxon jar from Geonetwork and the same Schematron rule file.

I think all geonet namespace elements should be removed before any user-defined Schematron rules are evaluated.

Ideally I would like this to go into 2.6.0 because it is a blocker for the UK Location Program’s release of a metadata editor based on Geonetwork – we can’t rewrite the Schematron rules (which are about to be published) to cope with a bug in Geonetwork.

If a fix doesn’t go into 2.6.0 I will of course write a fix and patch locally and offer it back.

I am happy to start work on a fix, but would appreciate any suggestions as to how I should go about it!

Justin.

This email is only intended for the person to whom it is addressed and may contain confidential information. If you have received this email in error, please notify the sender and delete this email which must not be copied, distributed or disclosed to any other person.

Unless stated otherwise, the contents of this email are personal to the writer and do not represent the official view of Ordnance Survey. Nor can any contract be formed on Ordnance Survey's behalf via email. We reserve the right to monitor emails and attachments without prior notice.

Thank you for your cooperation.

Ordnance Survey
Romsey Road
Southampton SO16 4GU
Tel: 08456 050505
http://www.ordnancesurvey.co.uk

Seems to me those geonet: elements should never remain after you close the editor. I guess you’re calling validation from an open editor when you get this ?

Maybe an easy way to fix is to insert an extra XSLT transformation before the validation that is basically an identity transformation except that it doesn’t copy things in the geonet: namespace ?

Kind regards
Heikki Doeleman

On Tue, Sep 21, 2010 at 12:31 PM, Justin Rowles (C) <Justin.Rowles@anonymised.com> wrote:

I get incorrect failures from a Schematron rule that are caused by geonet:element entries remaining in the xml at the time the Schematron rule is evaluated.

Once exported, the xml validates correctly with the saxon jar from Geonetwork and the same Schematron rule file.

I think all geonet namespace elements should be removed before any user-defined Schematron rules are evaluated.

Ideally I would like this to go into 2.6.0 because it is a blocker for the UK Location Program’s release of a metadata editor based on Geonetwork – we can’t rewrite the Schematron rules (which are about to be published) to cope with a bug in Geonetwork.

If a fix doesn’t go into 2.6.0 I will of course write a fix and patch locally and offer it back.

I am happy to start work on a fix, but would appreciate any suggestions as to how I should go about it!

Justin.

This email is only intended for the person to whom it is addressed and may contain confidential information. If you have received this email in error, please notify the sender and delete this email which must not be copied, distributed or disclosed to any other person.

Unless stated otherwise, the contents of this email are personal to the writer and do not represent the official view of Ordnance Survey. Nor can any contract be formed on Ordnance Survey's behalf via email. We reserve the right to monitor emails and attachments without prior notice.

Thank you for your cooperation.

Ordnance Survey
Romsey Road
Southampton SO16 4GU
Tel: 08456 050505
[http://www.ordnancesurvey.co.uk](http://www.ordnancesurvey.co.uk)


Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Exactly right. This is a false fail when pressing 'check' while editing
a record.

There are a bunch of 'export' transformations (one for each schema), and
I think the relevant one of those should be applied first, but I don't
know how to determine which is to be used or how to apply it (well, how
to get hold of it - I know how to apply it). Suggestions welcome.

Justin.

________________________________

From: heikki [mailto:tropicano@anonymised.com]
Sent: 21 September 2010 11:42
To: Justin Rowles (C)
Cc: geonetwork-devel@lists.sourceforge.net
Subject: Re: [GeoNetwork-devel] Incorrect Schematron errors in
Geonetwork.

Seems to me those geonet: elements should never remain after you close
the editor. I guess you're calling validation from an open editor when
you get this ?

Maybe an easy way to fix is to insert an extra XSLT transformation
before the validation that is basically an identity transformation
except that it doesn't copy things in the geonet: namespace ?

Kind regards
Heikki Doeleman

On Tue, Sep 21, 2010 at 12:31 PM, Justin Rowles (C)
<Justin.Rowles@anonymised.com> wrote:

I get incorrect failures from a Schematron rule that are caused by
geonet:element entries remaining in the xml at the time the Schematron
rule is evaluated.

Once exported, the xml validates correctly with the saxon jar from
Geonetwork and the same Schematron rule file.

I think all geonet namespace elements should be removed before any
user-defined Schematron rules are evaluated.

Ideally I would like this to go into 2.6.0 because it is a blocker for
the UK Location Program's release of a metadata editor based on
Geonetwork - we can't rewrite the Schematron rules (which are about to
be published) to cope with a bug in Geonetwork.

If a fix doesn't go into 2.6.0 I will of course write a fix and patch
locally and offer it back.

I am happy to start work on a fix, but would appreciate any suggestions
as to how I should go about it!

Justin.

This email is only intended for the person to whom it is addressed and
may contain confidential information. If you have received this email in
error, please notify the sender and delete this email which must not be
copied, distributed or disclosed to any other person.

Unless stated otherwise, the contents of this email are personal to the
writer and do not represent the official view of Ordnance Survey. Nor
can any contract be formed on Ordnance Survey's behalf via email. We
reserve the right to monitor emails and attachments without prior
notice.

Thank you for your cooperation.

Ordnance Survey
Romsey Road
Southampton SO16 4GU
Tel: 08456 050505
http://www.ordnancesurvey.co.uk

------------------------------------------------------------------------
------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at
http://sourceforge.net/projects/geonetwork

This email is only intended for the person to whom it is addressed and may contain confidential information. If you have received this email in error, please notify the sender and delete this email which must not be copied, distributed or disclosed to any other person.

Unless stated otherwise, the contents of this email are personal to the writer and do not represent the official view of Ordnance Survey. Nor can any contract be formed on Ordnance Survey's behalf via email. We reserve the right to monitor emails and attachments without prior notice.

Thank you for your cooperation.

Ordnance Survey
Romsey Road
Southampton SO16 4GU
Tel: 08456 050505
http://www.ordnancesurvey.co.uk

Hi Justin,

I can't seem to reproduce the error. The 'Check' button does a save and the retrieves the metadata from the session, throwing away the editing info (ie. the geonet: namespace elements) before doing the XSD and Schematron validate (see validateMetadata and doValidate in DataManager.java). Can you send me your demo so I can track this down please?

Cheers and thanks,
Simon
________________________________________
From: Justin Rowles (C) [Justin.Rowles@anonymised.com]
Sent: Tuesday, 21 September 2010 8:31 PM
To: geonetwork-devel@lists.sourceforge.net
Subject: [GeoNetwork-devel] Incorrect Schematron errors in Geonetwork.

I get incorrect failures from a Schematron rule that are caused by geonet:element entries remaining in the xml at the time the Schematron rule is evaluated.

Once exported, the xml validates correctly with the saxon jar from Geonetwork and the same Schematron rule file.

I think all geonet namespace elements should be removed before any user-defined Schematron rules are evaluated.

Ideally I would like this to go into 2.6.0 because it is a blocker for the UK Location Program’s release of a metadata editor based on Geonetwork – we can’t rewrite the Schematron rules (which are about to be published) to cope with a bug in Geonetwork.

If a fix doesn’t go into 2.6.0 I will of course write a fix and patch locally and offer it back.

I am happy to start work on a fix, but would appreciate any suggestions as to how I should go about it!

Justin.

This email is only intended for the person to whom it is addressed and may contain confidential information. If you have received this email in error, please notify the sender and delete this email which must not be copied, distributed or disclosed to any other person.

Unless stated otherwise, the contents of this email are personal to the writer and do not represent the official view of Ordnance Survey. Nor can any contract be formed on Ordnance Survey's behalf via email. We reserve the right to monitor emails and attachments without prior notice.

Thank you for your cooperation.

Ordnance Survey
Romsey Road
Southampton SO16 4GU
Tel: 08456 050505