Hi
We have different header styles:
Which one should be used? And if so, should be updated all source files?
Note also that the first format contains tabs, so if we check with Checkstyle SUN rules it complains.
Regards,
Jose García
Vriendelijke groeten / Kind regards,
Jose García
Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664
Please consider the environment before printing this email.
On a tangential note, GeoServer and GeoTools sought legal advice about the copyright header and discovered we don’t need to keep the 2001-2016 style dates in the header which is one less thing to worry about when patching files.
Ian
On 22 February 2017 at 07:58, Jose Garcia <jose.garcia@anonymised.com> wrote:
Hi
We have different header styles:
Which one should be used? And if so, should be updated all source files?
Note also that the first format contains tabs, so if we check with Checkstyle SUN rules it complains.
Regards,
Jose García–
Vriendelijke groeten / Kind regards,
Jose García
Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664
Please consider the environment before printing this email.
Check out the vibrant tech community on one of the world’s most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
GeoNetwork-devel mailing list
GeoNetwork-devel@…537…sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork
–
Ian Turton
On Wed, Feb 22, 2017 at 9:54 AM, Ian Turton <ijturton@anonymised.com> wrote:
On a tangential note, GeoServer and GeoTools sought legal advice about the
copyright header and discovered we don't need to keep the 2001-2016 style
dates in the header which is one less thing to worry about when patching
files.
So, what do we have to legally have in a header? Is it not enough the
license on the root of the repository? Can we get rid of headers?
Ian
On 22 February 2017 at 07:58, Jose Garcia <jose.garcia@anonymised.com> wrote:
Hi
We have different header styles:
https://github.com/geonetwork/core-geonetwork/blob/develop/c
ore/src/main/java/org/fao/geonet/kernel/AccessManager.java#L1-L22https://github.com/geonetwork/core-geonetwork/blob/develop/e
vents/src/main/java/org/fao/geonet/events/group/GroupCreated.java#L1-L22Which one should be used? And if so, should be updated all source files?
Note also that the first format contains tabs, so if we check with
Checkstyle SUN rules it complains.Regards,
Jose García--
*Vriendelijke groeten / Kind regards,Jose García
<http://www.geocat.net/>Veenderweg 136721 WD BennekomThe NetherlandsT: +31
(0)318 416664 <+31318416664> <https://www.facebook.com/geocatbv>
<https://twitter.com/geocat_bv>
<https://plus.google.com/u/1/+GeocatNetbv/posts>Please consider the
environment before printing this email.*------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/project
s/geonetwork--
Ian Turton------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/
projects/geonetwork
Hi Maria
From Ian comment, I understand he refers about the dates only, not the rest of the legal stuff. I agree with him, that helps to avoid maintenance.
Apart of that would be good to have clear from other committers also what should be the header to use so can be setup in the IDE, now there’s a mix of headers and also the one that seem more used across files (https://github.com/geonetwork/core-geonetwork/blob/develop/core/src/main/java/org/fao/geonet/kernel/AccessManager.java#L1-L22) use tabs, whats not really nice.
Regards,
Jose García
On Wed, Feb 22, 2017 at 10:10 AM, María Arias de Reyna <delawen@anonymised.com> wrote:
–
Vriendelijke groeten / Kind regards,
Jose García
Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664
Please consider the environment before printing this email.
On Wed, Feb 22, 2017 at 9:54 AM, Ian Turton <ijturton@anonymised.com> wrote:
On a tangential note, GeoServer and GeoTools sought legal advice about the copyright header and discovered we don’t need to keep the 2001-2016 style dates in the header which is one less thing to worry about when patching files.
So, what do we have to legally have in a header? Is it not enough the license on the root of the repository? Can we get rid of headers?
Ian
Check out the vibrant tech community on one of the world’s most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
GeoNetwork-devel mailing list
GeoNetwork-devel@anonymised.comorge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork
On 22 February 2017 at 07:58, Jose Garcia <jose.garcia@anonymised.com> wrote:
Hi
We have different header styles:
Which one should be used? And if so, should be updated all source files?
Note also that the first format contains tabs, so if we check with Checkstyle SUN rules it complains.
Regards,
Jose García–
Vriendelijke groeten / Kind regards,
Jose García
Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664Please consider the environment before printing this email.
Check out the vibrant tech community on one of the world’s most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
GeoNetwork-devel mailing list
GeoNetwork-devel@anonymised.comorge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork
–
Ian Turton
HI,
What I usually do is copy/paste from another file. But if we already have different headers…
From next month on I plan to start working on serious guidelines about how to contribute. So, noted.
On Wed, Feb 22, 2017 at 10:14 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:
Hi Maria
From Ian comment, I understand he refers about the dates only, not the rest of the legal stuff. I agree with him, that helps to avoid maintenance.
Apart of that would be good to have clear from other committers also what should be the header to use so can be setup in the IDE, now there’s a mix of headers and also the one that seem more used across files (https://github.com/geonetwork/core-geonetwork/blob/develop/core/src/main/java/org/fao/geonet/kernel/AccessManager.java#L1-L22) use tabs, whats not really nice.
Regards,
Jose García
On Wed, Feb 22, 2017 at 10:10 AM, María Arias de Reyna <delawen@anonymised.com> wrote:
–
Vriendelijke groeten / Kind regards,
Jose García
Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664
Please consider the environment before printing this email.
On Wed, Feb 22, 2017 at 9:54 AM, Ian Turton <ijturton@anonymised.com> wrote:
On a tangential note, GeoServer and GeoTools sought legal advice about the copyright header and discovered we don’t need to keep the 2001-2016 style dates in the header which is one less thing to worry about when patching files.
So, what do we have to legally have in a header? Is it not enough the license on the root of the repository? Can we get rid of headers?
Ian
Check out the vibrant tech community on one of the world’s most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
GeoNetwork-devel mailing list
GeoNetwork-devel@anonymised.comorge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork
On 22 February 2017 at 07:58, Jose Garcia <jose.garcia@anonymised.com> wrote:
Hi
We have different header styles:
Which one should be used? And if so, should be updated all source files?
Note also that the first format contains tabs, so if we check with Checkstyle SUN rules it complains.
Regards,
Jose García–
Vriendelijke groeten / Kind regards,
Jose García
Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664Please consider the environment before printing this email.
Check out the vibrant tech community on one of the world’s most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
GeoNetwork-devel mailing list
GeoNetwork-devel@anonymised.comorge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork
–
Ian Turton
Here is the blogpost -http://geotoolsnews.blogspot.co.uk/2016/07/copyright-headers-in-source-code-files.html but you don’t actually need any of the stuff we usually paste in there 
Ian
On 22 February 2017 at 09:19, María Arias de Reyna <delawen@anonymised.com> wrote:
HI,
What I usually do is copy/paste from another file. But if we already have different headers…
From next month on I plan to start working on serious guidelines about how to contribute. So, noted.
–
On Wed, Feb 22, 2017 at 10:14 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:
Hi Maria
From Ian comment, I understand he refers about the dates only, not the rest of the legal stuff. I agree with him, that helps to avoid maintenance.
Apart of that would be good to have clear from other committers also what should be the header to use so can be setup in the IDE, now there’s a mix of headers and also the one that seem more used across files (https://github.com/geonetwork/core-geonetwork/blob/develop/core/src/main/java/org/fao/geonet/kernel/AccessManager.java#L1-L22) use tabs, whats not really nice.
Regards,
Jose García
On Wed, Feb 22, 2017 at 10:10 AM, María Arias de Reyna <delawen@anonymised.com> wrote:
–
Vriendelijke groeten / Kind regards,
Jose García
Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664
Please consider the environment before printing this email.
On Wed, Feb 22, 2017 at 9:54 AM, Ian Turton <ijturton@anonymised.com> wrote:
On a tangential note, GeoServer and GeoTools sought legal advice about the copyright header and discovered we don’t need to keep the 2001-2016 style dates in the header which is one less thing to worry about when patching files.
So, what do we have to legally have in a header? Is it not enough the license on the root of the repository? Can we get rid of headers?
Ian
Check out the vibrant tech community on one of the world’s most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
GeoNetwork-devel mailing list
GeoNetwork-devel@anonymised.comorge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork
On 22 February 2017 at 07:58, Jose Garcia <jose.garcia@anonymised.com> wrote:
Hi
We have different header styles:
Which one should be used? And if so, should be updated all source files?
Note also that the first format contains tabs, so if we check with Checkstyle SUN rules it complains.
Regards,
Jose García–
Vriendelijke groeten / Kind regards,
Jose García
Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664Please consider the environment before printing this email.
Check out the vibrant tech community on one of the world’s most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
GeoNetwork-devel mailing list
GeoNetwork-devel@anonymised.comorge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork
–
Ian Turton
Ian Turton
On Wed, Feb 22, 2017 at 8:58 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:
We have different header styles:
https://github.com/geonetwork/core-geonetwork/blob/develop/
core/src/main/java/org/fao/geonet/kernel/AccessManager.java#L1-L22
This is the one used in the legacy GN old code.
https://github.com/geonetwork/core-geonetwork/blob/develop/
events/src/main/java/org/fao/geonet/events/group/GroupCreated.java#L1-L22
This one is used in the new code.
--
*Vriendelijke groeten / Kind regards,Juan Luis Rodríguez.
<http://www.geocat.net/>Veenderweg 136721 WD BennekomThe NetherlandsT: +31
(0)318 416664 <+31318416664> <https://www.facebook.com/geocatbv>
<https://twitter.com/geocat_bv>
<https://plus.google.com/u/1/+GeocatNetbv/posts>Please consider the
environment before printing this email.*