Hi,
could a commiter/developer have a look at the following pending patches,
and eventually commit them to master/2.8.x branch ?
- http://trac.osgeo.org/geonetwork/ticket/1226 applies to master but
could apply to 2.8.x if http://trac.osgeo.org/geonetwork/ticket/1107 is
backported to it - atm 2.8.x generates duplicated download links for
attached files
- http://trac.osgeo.org/geonetwork/ticket/1227 is straightforward
- http://trac.osgeo.org/geonetwork/ticket/1228 fixes search by status
- http://trac.osgeo.org/geonetwork/ticket/1229 &
http://trac.osgeo.org/geonetwork/ticket/1231 fixes annoying bugs when
geopublishing to geoserver
- http://trac.osgeo.org/geonetwork/ticket/1232 enhances the
geopublishing by also sending the abstract to geoserver.
- http://trac.osgeo.org/geonetwork/ticket/1166 does have a fix, but it's
not 100% clean and simon doesnt reproduce it..
Thanks!
--
Landry Breuil
Mouton a 5 pattes du CRAIG
On 03/01/13 10:56, Landry Breuil wrote:
Hi,
could a commiter/developer have a look at the following pending patches,
and eventually commit them to master/2.8.x branch ?
- http://trac.osgeo.org/geonetwork/ticket/1226 applies to master but
could apply to 2.8.x if http://trac.osgeo.org/geonetwork/ticket/1107 is
backported to it - atm 2.8.x generates duplicated download links for
attached files
- http://trac.osgeo.org/geonetwork/ticket/1227 is straightforward
- http://trac.osgeo.org/geonetwork/ticket/1228 fixes search by status
- http://trac.osgeo.org/geonetwork/ticket/1229 &
http://trac.osgeo.org/geonetwork/ticket/1231 fixes annoying bugs when
geopublishing to geoserver
- http://trac.osgeo.org/geonetwork/ticket/1232 enhances the
geopublishing by also sending the abstract to geoserver.
- http://trac.osgeo.org/geonetwork/ticket/1166 does have a fix, but it's
not 100% clean and simon doesnt reproduce it..
Ping ? Can anyone with commit access to github look into this ?
--
Landry Breuil
Mouton a 5 pattes du CRAIG
Landry,
I have noticed that you have been adding a lot of patches/comments recently
which is very much appreciated.
May I suggest that if you want your commits to be applied faster then I
suggest that you create a github account (it's free) and fork geonetwork.
Instruction are at the bottom of the following page
http://trac.osgeo.org/geonetwork/wiki/HowToWorkWithGit
Once you have forked then checkout the forked version to your PC and commit
your changes using a git client.
Once you have applied your changes to your forked version you can then
submit a "pull request" to have members of the geonetwork team pull your
changes from your fork.
This is how I submit my changes and it works great.
--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Pending-patches-in-trac-tp5037886p5041858.html
Sent from the GeoNetwork developer mailing list archive at Nabble.com.
Landry,
I noticed you have sent a lot of pull request. That's good.
I do want to give you a quick pointer based on my experience when dealing
with branches as I noticed that afew of your tickets are targeting the 2.8.x
branch.
When submitting a pull request which needs to be applied to the master and
another branch, I generally try to perform a test cherry-pick of that commit
between branches - if it can get cherry picked without any issues then I
generally ask that the change be cherry picked to the other branch in my
pull request. If there are conflicts or issues during the cherry-pick, I
then submit a separate pull request for the branch and indicate this in the
comments of the pull request. This way, members like Jesse are not wasting
time trying to merge changes between branches.
Also, I have noticed that generally if I don't ask for it to be cherry
picked to another branch it does not get done. Especially if I send a change
to the Master.
Also, I believe they prefer (Jesse - correct me if I'm wrong) that the
change be submitted to the lower branch (i.e. 2.8) and then cherry picked to
the master. But it can work both ways....
--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Pending-patches-in-trac-tp5037886p5042136.html
Sent from the GeoNetwork developer mailing list archive at Nabble.com.