[GeoNetwork-devel] Proposal for vote: Validation Hook

Dear PSC members,

a proposal to add an extension point to GeoNetwork, in order to allow users to plug in custom code to be executed after validation.

This extension does not affect GeoNetwork’s functionality for users who do not choose to add custom code for this.

See more details about this here http://trac.osgeo.org/geonetwork/wiki/ValidationHook.

Please vote,

kind regards
Heikki Doeleman

I like it

On Thu, Aug 2, 2012 at 10:20 PM, heikki <tropicano@anonymised.com> wrote:

Dear PSC members,

a proposal to add an extension point to GeoNetwork, in order to allow users to plug in custom code to be executed after validation.

This extension does not affect GeoNetwork’s functionality for users who do not choose to add custom code for this.

See more details about this here http://trac.osgeo.org/geonetwork/wiki/ValidationHook.

Please vote,

kind regards
Heikki Doeleman


Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

+1 for me Heikki, do you have some real use case ? what type of hook
do you plan to setup ?

Jesse, don't you have some projects with a unpublish record if not valid ?

Also a bit related to that, user could also subscribe to RSS feed on
invalid item with:
http://localhost:8080/geonetwork/srv/eng/rss.search?_valid=0

Francois

2012/8/3 Jesse Eichar <jesse.eichar@anonymised.com>:

I like it

On Thu, Aug 2, 2012 at 10:20 PM, heikki <tropicano@anonymised.com> wrote:

Dear PSC members,

a proposal to add an extension point to GeoNetwork, in order to allow
users to plug in custom code to be executed after validation.

This extension does not affect GeoNetwork's functionality for users who do
not choose to add custom code for this.

See more details about this here
http://trac.osgeo.org/geonetwork/wiki/ValidationHook.

Please vote,

kind regards
Heikki Doeleman

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at
http://sourceforge.net/projects/geonetwork

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at
http://sourceforge.net/projects/geonetwork

On Fri, Aug 3, 2012 at 8:38 AM, Francois Prunayre <fx.prunayre@anonymised.com> wrote:

+1 for me Heikki, do you have some real use case ? what type of hook
do you plan to setup ?

Jesse, don’t you have some projects with a unpublish record if not valid ?

Yep Geocat does that.

Also a bit related to that, user could also subscribe to RSS feed on
invalid item with:
http://localhost:8080/geonetwork/srv/eng/rss.search?_valid=0

Hi Heikki

Proposal looks good to me.

Just one question about the params (Object… args) for onValidate. If I understand well the new method postValidation will invoke onValidate for all hooks configured, so in that case the arguments should be the same for all hooks, no? In that case, I think better to explicit define a fixed list of params required.

Regards,
Jose García

On Thu, Aug 2, 2012 at 10:20 PM, heikki <tropicano@…31…> wrote:

Dear PSC members,

a proposal to add an extension point to GeoNetwork, in order to allow users to plug in custom code to be executed after validation.

This extension does not affect GeoNetwork’s functionality for users who do not choose to add custom code for this.

See more details about this here http://trac.osgeo.org/geonetwork/wiki/ValidationHook.

Please vote,

kind regards
Heikki Doeleman


Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net

@François: this user wants to store information about the results of the validation inside the metadata itself;

@Jose: it is still only possible to define 1 hook, as I didn’t change Jeeves to make it possible to have >1 element with the same name in (or to have elements with a different strcuture than they do now). Even so, an implementation using different parameters will need to change the invocation of ValidatonHookFactory.onValidate() in DataManager.postValidate(). If it were possible to define >1 ValidationHook then they all should be invoked from there, with whatever parameters they require.

On Fri, Aug 3, 2012 at 8:58 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi Heikki

Proposal looks good to me.

Just one question about the params (Object… args) for onValidate. If I understand well the new method postValidation will invoke onValidate for all hooks configured, so in that case the arguments should be the same for all hooks, no? In that case, I think better to explicit define a fixed list of params required.

Regards,
Jose García

On Thu, Aug 2, 2012 at 10:20 PM, heikki <tropicano@anonymised.com> wrote:

Dear PSC members,

a proposal to add an extension point to GeoNetwork, in order to allow users to plug in custom code to be executed after validation.

This extension does not affect GeoNetwork’s functionality for users who do not choose to add custom code for this.

See more details about this here http://trac.osgeo.org/geonetwork/wiki/ValidationHook.

Please vote,

kind regards
Heikki Doeleman


Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net

Hi Heikki

Ok, but my concern is that then if supported >1 ValidationHook (and seem each can require different parameters) then also DataManager code requires to be changed, so no that pluggable.

Regards,
Jose García

On Fri, Aug 3, 2012 at 11:45 AM, heikki <tropicano@anonymised.com> wrote:

@François: this user wants to store information about the results of the validation inside the metadata itself;

@Jose: it is still only possible to define 1 hook, as I didn’t change Jeeves to make it possible to have >1 element with the same name in (or to have elements with a different strcuture than they do now). Even so, an implementation using different parameters will need to change the invocation of ValidatonHookFactory.onValidate() in DataManager.postValidate(). If it were possible to define >1 ValidationHook then they all should be invoked from there, with whatever parameters they require.

On Fri, Aug 3, 2012 at 8:58 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi Heikki

Proposal looks good to me.

Just one question about the params (Object… args) for onValidate. If I understand well the new method postValidation will invoke onValidate for all hooks configured, so in that case the arguments should be the same for all hooks, no? In that case, I think better to explicit define a fixed list of params required.

Regards,
Jose García

On Thu, Aug 2, 2012 at 10:20 PM, heikki <tropicano@anonymised.com> wrote:

Dear PSC members,

a proposal to add an extension point to GeoNetwork, in order to allow users to plug in custom code to be executed after validation.

This extension does not affect GeoNetwork’s functionality for users who do not choose to add custom code for this.

See more details about this here http://trac.osgeo.org/geonetwork/wiki/ValidationHook.

Please vote,

kind regards
Heikki Doeleman


Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net

hi Jose,

if Jeeves were adapted to allow for defining >1 ValidationHook, it could also gather which parameters are needed for each from there, e.g.

But you’re right, still a code change in DataManager would be required to actually provide the specific values for each of the implementations. The advantage of the varargs interface is that this is the only code change that would be necessary for it (otherwise, also ValidationFactory would need to be changed to accomodate for each implementation). I think the DataManager code change is unavoidable, as the parameters will have to be supplied from somewhere.

Once we have Spring dependency injection that could be addressed by injecting a subclass of DataManager instead of the vanilla one, that overrides postValidate(), I think.

What do you think ?

On Fri, Aug 3, 2012 at 11:50 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi Heikki

Ok, but my concern is that then if supported >1 ValidationHook (and seem each can require different parameters) then also DataManager code requires to be changed, so no that pluggable.

Regards,
Jose García

On Fri, Aug 3, 2012 at 11:45 AM, heikki <tropicano@anonymised.com> wrote:

@François: this user wants to store information about the results of the validation inside the metadata itself;

@Jose: it is still only possible to define 1 hook, as I didn’t change Jeeves to make it possible to have >1 element with the same name in (or to have elements with a different strcuture than they do now). Even so, an implementation using different parameters will need to change the invocation of ValidatonHookFactory.onValidate() in DataManager.postValidate(). If it were possible to define >1 ValidationHook then they all should be invoked from there, with whatever parameters they require.

On Fri, Aug 3, 2012 at 8:58 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi Heikki

Proposal looks good to me.

Just one question about the params (Object… args) for onValidate. If I understand well the new method postValidation will invoke onValidate for all hooks configured, so in that case the arguments should be the same for all hooks, no? In that case, I think better to explicit define a fixed list of params required.

Regards,
Jose García

On Thu, Aug 2, 2012 at 10:20 PM, heikki <tropicano@anonymised.com> wrote:

Dear PSC members,

a proposal to add an extension point to GeoNetwork, in order to allow users to plug in custom code to be executed after validation.

This extension does not affect GeoNetwork’s functionality for users who do not choose to add custom code for this.

See more details about this here http://trac.osgeo.org/geonetwork/wiki/ValidationHook.

Please vote,

kind regards
Heikki Doeleman


Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net

Hi

Maybe it’s better about the ValidationFactory, can be provided a default one and if specific one required, subclass it. If the ValidationFactory can be injected as the ValidationHook to DataManager then at least no need to change DataManager, that would be great.

But no clear if will work, I have no clear on the actual parameters for the actual use case and also no idea what others can be required. If makes sense for you about ValidationFactory, seem a good option. Otherwise if no possible actual proposal seem fine, at least the validation custom code is not inside DataManager.

Regards,
Jose García

On Fri, Aug 3, 2012 at 12:00 PM, heikki <tropicano@anonymised.com> wrote:

hi Jose,

if Jeeves were adapted to allow for defining >1 ValidationHook, it could also gather which parameters are needed for each from there, e.g.

But you’re right, still a code change in DataManager would be required to actually provide the specific values for each of the implementations. The advantage of the varargs interface is that this is the only code change that would be necessary for it (otherwise, also ValidationFactory would need to be changed to accomodate for each implementation). I think the DataManager code change is unavoidable, as the parameters will have to be supplied from somewhere.

Once we have Spring dependency injection that could be addressed by injecting a subclass of DataManager instead of the vanilla one, that overrides postValidate(), I think.

What do you think ?

On Fri, Aug 3, 2012 at 11:50 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi Heikki

Ok, but my concern is that then if supported >1 ValidationHook (and seem each can require different parameters) then also DataManager code requires to be changed, so no that pluggable.

Regards,
Jose García

On Fri, Aug 3, 2012 at 11:45 AM, heikki <tropicano@anonymised.com> wrote:

@François: this user wants to store information about the results of the validation inside the metadata itself;

@Jose: it is still only possible to define 1 hook, as I didn’t change Jeeves to make it possible to have >1 element with the same name in (or to have elements with a different strcuture than they do now). Even so, an implementation using different parameters will need to change the invocation of ValidatonHookFactory.onValidate() in DataManager.postValidate(). If it were possible to define >1 ValidationHook then they all should be invoked from there, with whatever parameters they require.

On Fri, Aug 3, 2012 at 8:58 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi Heikki

Proposal looks good to me.

Just one question about the params (Object… args) for onValidate. If I understand well the new method postValidation will invoke onValidate for all hooks configured, so in that case the arguments should be the same for all hooks, no? In that case, I think better to explicit define a fixed list of params required.

Regards,
Jose García

On Thu, Aug 2, 2012 at 10:20 PM, heikki <tropicano@anonymised.com> wrote:

Dear PSC members,

a proposal to add an extension point to GeoNetwork, in order to allow users to plug in custom code to be executed after validation.

This extension does not affect GeoNetwork’s functionality for users who do not choose to add custom code for this.

See more details about this here http://trac.osgeo.org/geonetwork/wiki/ValidationHook.

Please vote,

kind regards
Heikki Doeleman


Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net

hi Jose,

don’t think that can work just like that because without the varargs interface, BOTH the ValidationHookFactory AND its client (i.c. DataManager) would need to be changed. The varargs interface makes it more flexible on 1 side, but the caller side still needs to deal with the actual values required for the actual parameters.

I prefer to keep the proposal as it is for now, unless someone thinks it would be better or clearer to just use a fixed argument list instead.

On Fri, Aug 3, 2012 at 12:10 PM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi

Maybe it’s better about the ValidationFactory, can be provided a default one and if specific one required, subclass it. If the ValidationFactory can be injected as the ValidationHook to DataManager then at least no need to change DataManager, that would be great.

But no clear if will work, I have no clear on the actual parameters for the actual use case and also no idea what others can be required. If makes sense for you about ValidationFactory, seem a good option. Otherwise if no possible actual proposal seem fine, at least the validation custom code is not inside DataManager.

Regards,
Jose García

On Fri, Aug 3, 2012 at 12:00 PM, heikki <tropicano@anonymised.com> wrote:

hi Jose,

if Jeeves were adapted to allow for defining >1 ValidationHook, it could also gather which parameters are needed for each from there, e.g.

But you’re right, still a code change in DataManager would be required to actually provide the specific values for each of the implementations. The advantage of the varargs interface is that this is the only code change that would be necessary for it (otherwise, also ValidationFactory would need to be changed to accomodate for each implementation). I think the DataManager code change is unavoidable, as the parameters will have to be supplied from somewhere.

Once we have Spring dependency injection that could be addressed by injecting a subclass of DataManager instead of the vanilla one, that overrides postValidate(), I think.

What do you think ?

On Fri, Aug 3, 2012 at 11:50 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi Heikki

Ok, but my concern is that then if supported >1 ValidationHook (and seem each can require different parameters) then also DataManager code requires to be changed, so no that pluggable.

Regards,
Jose García

On Fri, Aug 3, 2012 at 11:45 AM, heikki <tropicano@anonymised.com> wrote:

@François: this user wants to store information about the results of the validation inside the metadata itself;

@Jose: it is still only possible to define 1 hook, as I didn’t change Jeeves to make it possible to have >1 element with the same name in (or to have elements with a different strcuture than they do now). Even so, an implementation using different parameters will need to change the invocation of ValidatonHookFactory.onValidate() in DataManager.postValidate(). If it were possible to define >1 ValidationHook then they all should be invoked from there, with whatever parameters they require.

On Fri, Aug 3, 2012 at 8:58 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi Heikki

Proposal looks good to me.

Just one question about the params (Object… args) for onValidate. If I understand well the new method postValidation will invoke onValidate for all hooks configured, so in that case the arguments should be the same for all hooks, no? In that case, I think better to explicit define a fixed list of params required.

Regards,
Jose García

On Thu, Aug 2, 2012 at 10:20 PM, heikki <tropicano@anonymised.com> wrote:

Dear PSC members,

a proposal to add an extension point to GeoNetwork, in order to allow users to plug in custom code to be executed after validation.

This extension does not affect GeoNetwork’s functionality for users who do not choose to add custom code for this.

See more details about this here http://trac.osgeo.org/geonetwork/wiki/ValidationHook.

Please vote,

kind regards
Heikki Doeleman


Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net