[GeoNetwork-devel] Questionable compressed js files in the repo...

Ian_Allen · June 21, 2012, 1:16pm

Hi,

I was attempting to correct trac ticket 954 which is a simply typo change
and I noticed some files in the repository that are questionable.... Since
you are the experts I thought I would run it by you.

The following files seems outdated and the are automatically regenerated
when doing a "mvn clean install"

web-client/src/main/resources/apps/search/js/App-mini.js
web-client/src/main/resources/apps/js/GeoNetwork-mini.js
web-client/src/main/resources/apps/js/GeoNetwork-mini-nomap.js

The next file, I cannot find any reference to to its usage - it has the same
cryptic code as the other compress js files. - It is not automatically
generated so I'm not sure where it came from . It seems like it was
initially committed as a bulk add. I cannot see how anyone can maintain this
file? So I think it should be removed.

web-client/src/main/resources/apps/js/GeoNetwork.js

Thanks.

--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Questionable-compressed-js-files-in-the-repo-tp4982992.html
Sent from the GeoNetwork developer mailing list archive at Nabble.com.

Jesse_Eichar2 · June 21, 2012, 6:23pm

One thing I do is use

git update-index --assume-unchanged

so that I never see that they are changed, then it is as if they are not in my index and I can go on with life. I personally don’t think they should be in the index but I am not terribly strongly opinionated about the issue.

See http://gitready.com/intermediate/2009/02/18/temporarily-ignoring-files.html

on more about the update-index to ignore files that are tracked by git.

Jesse

On Thu, Jun 21, 2012 at 3:16 PM, ianwallen <ianwallen@anonymised.com> wrote:

Hi,

I was attempting to correct trac ticket 954 which is a simply typo change
and I noticed some files in the repository that are questionable… Since
you are the experts I thought I would run it by you.

The following files seems outdated and the are automatically regenerated
when doing a “mvn clean install”

web-client/src/main/resources/apps/search/js/App-mini.js
web-client/src/main/resources/apps/js/GeoNetwork-mini.js
web-client/src/main/resources/apps/js/GeoNetwork-mini-nomap.js

The next file, I cannot find any reference to to its usage - it has the same
cryptic code as the other compress js files. - It is not automatically
generated so I’m not sure where it came from . It seems like it was
initially committed as a bulk add. I cannot see how anyone can maintain this
file? So I think it should be removed.

web-client/src/main/resources/apps/js/GeoNetwork.js

Thanks.

–
View this message in context: http://osgeo-org.1560.n6.nabble.com/Questionable-compressed-js-files-in-the-repo-tp4982992.html
Sent from the GeoNetwork developer mailing list archive at Nabble.com.

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Ian_Allen · June 22, 2012, 11:03am

Thank you for the information Jesse - I found the git information to be
useful

I must be more opinionated that you! I don't see why these files in the
repository in the first place. They are not providing any benefit. And if
they are going to be in the repository, then they should be, at least, up to
date - which they are not.

For now, I will place them in the index.

I just wanted to bring it up to the group so that someone with a better
understanding of the requirements of these files can review them to
determine if they are really needed.

Again, thanks

--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Questionable-compressed-js-files-in-the-repo-tp4982992p4983187.html
Sent from the GeoNetwork developer mailing list archive at Nabble.com.

Heikki_Doeleman · June 25, 2012, 2:37pm

I agree that these files are build artifacts, and should not be in the repository – it’s confusing and runs the risk they’re out of date.

Kind regards
Heikki Doeleman

On Fri, Jun 22, 2012 at 1:03 PM, ianwallen <ianwallen@anonymised.com> wrote:

Thank you for the information Jesse - I found the git information to be
useful

I must be more opinionated that you! I don’t see why these files in the
repository in the first place. They are not providing any benefit. And if
they are going to be in the repository, then they should be, at least, up to
date - which they are not.

For now, I will place them in the index.

I just wanted to bring it up to the group so that someone with a better
understanding of the requirements of these files can review them to
determine if they are really needed.

Again, thanks

–
View this message in context: http://osgeo-org.1560.n6.nabble.com/Questionable-compressed-js-files-in-the-repo-tp4982992p4983187.html

Sent from the GeoNetwork developer mailing list archive at Nabble.com.

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Jesse_Eichar2 · June 25, 2012, 2:44pm

Should we vote on keeping them in or out?

I am +1 for removing them.

Jesse

On Mon, Jun 25, 2012 at 4:37 PM, heikki <tropicano@anonymised.com> wrote:

I agree that these files are build artifacts, and should not be in the repository – it’s confusing and runs the risk they’re out of date.

Kind regards
Heikki Doeleman

On Fri, Jun 22, 2012 at 1:03 PM, ianwallen <ianwallen@anonymised.com> wrote:

Thank you for the information Jesse - I found the git information to be
useful

I must be more opinionated that you! I don’t see why these files in the
repository in the first place. They are not providing any benefit. And if
they are going to be in the repository, then they should be, at least, up to
date - which they are not.

For now, I will place them in the index.

I just wanted to bring it up to the group so that someone with a better
understanding of the requirements of these files can review them to
determine if they are really needed.

Again, thanks

–
View this message in context: http://osgeo-org.1560.n6.nabble.com/Questionable-compressed-js-files-in-the-repo-tp4982992p4983187.html

Sent from the GeoNetwork developer mailing list archive at Nabble.com.

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

sppigot · June 26, 2012, 3:06am

I am also +1 for removing them.

Cheers,
Simon
________________________________________
From: Jesse Eichar [jesse.eichar@anonymised.com]
Sent: Tuesday, 26 June 2012 12:44 AM
To: tropicano@anonymised.com
Cc: ianwallen; geonetwork-devel@lists.sourceforge.net
Subject: Re: [GeoNetwork-devel] Questionable compressed js files in the repo...

Should we vote on keeping them in or out?

I am +1 for removing them.

Jesse

On Mon, Jun 25, 2012 at 4:37 PM, heikki <tropicano@anonymised.com<mailto:tropicano@anonymised.com>> wrote:
I agree that these files are build artifacts, and should not be in the repository -- it's confusing and runs the risk they're out of date.

Kind regards
Heikki Doeleman

On Fri, Jun 22, 2012 at 1:03 PM, ianwallen <ianwallen@anonymised.com<mailto:ianwallen@anonymised.com>> wrote:
Thank you for the information Jesse - I found the git information to be
useful

I must be more opinionated that you! I don't see why these files in the
repository in the first place. They are not providing any benefit. And if
they are going to be in the repository, then they should be, at least, up to
date - which they are not.

For now, I will place them in the index.

I just wanted to bring it up to the group so that someone with a better
understanding of the requirements of these files can review them to
determine if they are really needed.

Again, thanks

--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Questionable-compressed-js-files-in-the-repo-tp4982992p4983187.html
Sent from the GeoNetwork developer mailing list archive at Nabble.com.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net<mailto:GeoNetwork-devel@anonymised.comforge.net>
geonetwork-devel List Signup and Options
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Francois_Prunayre · June 26, 2012, 5:08am

+1 for me

Le 25 juin 2012 17:45, “Jesse Eichar” <jesse.eichar@anonymised.com> a écrit :

Should we vote on keeping them in or out?

I am +1 for removing them.

Jesse

On Mon, Jun 25, 2012 at 4:37 PM, heikki <tropicano@anonymised.com> wrote:

I agree that these files are build artifacts, and should not be in the repository – it’s confusing and runs the risk they’re out of date.

Kind regards
Heikki Doeleman

On Fri, Jun 22, 2012 at 1:03 PM, ianwallen <ianwallen@anonymised.com> wrote:

Thank you for the information Jesse - I found the git information to be
useful

I must be more opinionated that you! I don’t see why these files in the
repository in the first place. They are not providing any benefit. And if
they are going to be in the repository, then they should be, at least, up to
date - which they are not.

For now, I will place them in the index.

I just wanted to bring it up to the group so that someone with a better
understanding of the requirements of these files can review them to
determine if they are really needed.

Again, thanks

–
View this message in context: http://osgeo-org.1560.n6.nabble.com/Questionable-compressed-js-files-in-the-repo-tp4982992p4983187.html

Sent from the GeoNetwork developer mailing list archive at Nabble.com.

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

ticheler · June 26, 2012, 5:58am

+1 from me

Op 26 jun. 2012 om 08:08 heeft Francois Prunayre <fx.prunayre@anonymised.com> het volgende geschreven:

+1 for me

Le 25 juin 2012 17:45, “Jesse Eichar” <jesse.eichar@anonymised.com.> a écrit :

Should we vote on keeping them in or out?

I am +1 for removing them.

Jesse

On Mon, Jun 25, 2012 at 4:37 PM, heikki <tropicano@anonymised.com> wrote:

I agree that these files are build artifacts, and should not be in the repository – it’s confusing and runs the risk they’re out of date.

Kind regards
Heikki Doeleman

On Fri, Jun 22, 2012 at 1:03 PM, ianwallen <ianwallen@anonymised.com> wrote:

Thank you for the information Jesse - I found the git information to be
useful

I must be more opinionated that you! I don’t see why these files in the
repository in the first place. They are not providing any benefit. And if
they are going to be in the repository, then they should be, at least, up to
date - which they are not.

For now, I will place them in the index.

I just wanted to bring it up to the group so that someone with a better
understanding of the requirements of these files can review them to
determine if they are really needed.

Again, thanks

–
View this message in context: http://osgeo-org.1560.n6.nabble.com/Questionable-compressed-js-files-in-the-repo-tp4982992p4983187.html

Sent from the GeoNetwork developer mailing list archive at Nabble.com.

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Monteduro_Patrizia_C · June 26, 2012, 3:16pm

0 (neutral) from my side.

Sorry but it is toooo technical for me J

Cheers,

Patrizia

From: Jeroen Ticheler [mailto:jeroen.ticheler@…437…]
Sent: 26 June 2012 07:59
To: Francois Prunayre
Cc: ianwallen; geonetwork-devel@lists.sourceforge.net
Subject: Re: [GeoNetwork-devel] Questionable compressed js files in the repo…

+1 from me

Op 26 jun. 2012 om 08:08 heeft Francois Prunayre <fx.prunayre@…31…> het volgende geschreven:

+1 for me

Le 25 juin 2012 17:45, “Jesse Eichar” <jesse.eichar@…189…> a écrit :

Should we vote on keeping them in or out?

I am +1 for removing them.

Jesse

On Mon, Jun 25, 2012 at 4:37 PM, heikki <tropicano@…31…> wrote:

I agree that these files are build artifacts, and should not be in the repository – it’s confusing and runs the risk they’re out of date.

Kind regards

Heikki Doeleman

On Fri, Jun 22, 2012 at 1:03 PM, ianwallen <ianwallen@…22…> wrote:

Thank you for the information Jesse - I found the git information to be
useful

I must be more opinionated that you! I don’t see why these files in the
repository in the first place. They are not providing any benefit. And if
they are going to be in the repository, then they should be, at least, up to
date - which they are not.

For now, I will place them in the index.

I just wanted to bring it up to the group so that someone with a better
understanding of the requirements of these files can review them to
determine if they are really needed.

Again, thanks

–
View this message in context: http://osgeo-org.1560.n6.nabble.com/Questionable-compressed-js-files-in-the-repo-tp4982992p4983187.html

Sent from the GeoNetwork developer mailing list archive at Nabble.com.

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

fgravin · June 27, 2012, 8:49am

i would say +1
they don’t have to be here

On Tue, Jun 26, 2012 at 5:16 PM, Monteduro, Patrizia (NRL) <Patrizia.Monteduro@anonymised.com> wrote:

0 (neutral) from my side.

Sorry but it is toooo technical for me J

Cheers,

Patrizia

From: Jeroen Ticheler [mailto:jeroen.ticheler@anonymised.com]
Sent: 26 June 2012 07:59
To: Francois Prunayre

Cc: ianwallen; geonetwork-devel@anonymised.comrge.net
Subject: Re: [GeoNetwork-devel] Questionable compressed js files in the repo…

+1 from me

Op 26 jun. 2012 om 08:08 heeft Francois Prunayre <fx.prunayre@anonymised.com> het volgende geschreven:

+1 for me

Le 25 juin 2012 17:45, “Jesse Eichar” <jesse.eichar@anonymised.com> a écrit :

Should we vote on keeping them in or out?

I am +1 for removing them.

Jesse

On Mon, Jun 25, 2012 at 4:37 PM, heikki <tropicano@anonymised.com> wrote:

I agree that these files are build artifacts, and should not be in the repository – it’s confusing and runs the risk they’re out of date.

Kind regards

Heikki Doeleman

On Fri, Jun 22, 2012 at 1:03 PM, ianwallen <ianwallen@anonymised.com> wrote:

Thank you for the information Jesse - I found the git information to be
useful

I must be more opinionated that you! I don’t see why these files in the
repository in the first place. They are not providing any benefit. And if
they are going to be in the repository, then they should be, at least, up to
date - which they are not.

For now, I will place them in the index.

I just wanted to bring it up to the group so that someone with a better
understanding of the requirements of these files can review them to
determine if they are really needed.

Again, thanks

–
View this message in context: http://osgeo-org.1560.n6.nabble.com/Questionable-compressed-js-files-in-the-repo-tp4982992p4983187.html

Sent from the GeoNetwork developer mailing list archive at Nabble.com.

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@anonymised.com.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Live Security Virtual Conference
Exclusive live event will cover all the ways today’s security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork