[GeoNetwork-devel] StatusValue table

Hi, 2 questions about the StatusValue table :

This table contains a column named 'reserved' (default value 'n'). Is
this used or planned to be used for something ?

Adding a new column for ordering the status would be useful for some
users. Any objections ?

Cheers.

Francois

Francois,

Here is my best guess..

I would say that the "reserved" would be for identifying the status that are
used internally. The proposal
(http://trac.osgeo.org/geonetwork/wiki/metadataworkflow) mentions that extra
statuses can be added by the users. I would suspect that it there was a tool
for managing the statuses, that it would not allow users to remove/modify
the statuses marked as "reserved". You will noticed that in
data-db-default.sql they are all set to "y" - all others will default to "n"
(Of course this is just my guess - I may be off the mark :slight_smile: )

In proposal - http://trac.osgeo.org/geonetwork/wiki/ImprovedWorkflow - it
suggest stricter states which may mean the users would no longer be able to
add their own states - in which case this field would no longer be required.

Note: It does seem to be used in the following code.

web-client\src\main\resources\apps\js\GeoNetwork\lib\GeoNetwork\data\StatusStore.js(76):
name: 'reserved'

And of course all the SQL
code....(web\src\main\webapp\WEB-INF\classes\setup\sql\...)

Regarding the ordering, I suspect that you want to add a flow order. I don't
have any issues as long as it still supports the current method which is
sorting by label. So I assume that after you apply the change it would sort
by flow order and then by label. - setting all the flow orders to null
would sort as it does now.

--
View this message in context: http://osgeo-org.1560.x6.nabble.com/StatusValue-table-tp5072202p5072265.html
Sent from the GeoNetwork developer mailing list archive at Nabble.com.

Thanks for the feedback Ian,

2013/8/13 ianwallen <ianwallen@anonymised.com>:

Francois,

Here is my best guess..

I would say that the "reserved" would be for identifying the status that are
used internally. The proposal
(http://trac.osgeo.org/geonetwork/wiki/metadataworkflow) mentions that extra
statuses can be added by the users. I would suspect that it there was a tool
for managing the statuses, that it would not allow users to remove/modify
the statuses marked as "reserved". You will noticed that in
data-db-default.sql they are all set to "y" - all others will default to "n"
(Of course this is just my guess - I may be off the mark :slight_smile: )

In proposal - http://trac.osgeo.org/geonetwork/wiki/ImprovedWorkflow - it
suggest stricter states which may mean the users would no longer be able to
add their own states - in which case this field would no longer be required.

Note: It does seem to be used in the following code.

web-client\src\main\resources\apps\js\GeoNetwork\lib\GeoNetwork\data\StatusStore.js(76):
name: 'reserved'

And of course all the SQL
code....(web\src\main\webapp\WEB-INF\classes\setup\sql\...)

Regarding the ordering, I suspect that you want to add a flow order.

Exactly, the main complain of users here is when switching to french
to english, status are not in the same order because using labels.

I don't
have any issues as long as it still supports the current method which is
sorting by label. So I assume that after you apply the change it would sort
by flow order and then by label. - setting all the flow orders to null
would sort as it does now.

Done https://github.com/geonetwork/core-geonetwork/issues/228

Cheers.

Francois

--
View this message in context: http://osgeo-org.1560.x6.nabble.com/StatusValue-table-tp5072202p5072265.html
Sent from the GeoNetwork developer mailing list archive at Nabble.com.

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Francois,

I see you already committed the changes.... I'm not sure if you forgot this
one or you are not concerned about the classic interface - but here is
another location that does status sorting.

https://github.com/geonetwork/core-geonetwork/blob/develop/web/src/main/webapp/xsl/searchform_advanced.xsl#L318

--
View this message in context: http://osgeo-org.1560.x6.nabble.com/StatusValue-table-tp5072202p5072291.html
Sent from the GeoNetwork developer mailing list archive at Nabble.com.

Ian,

···

2013/8/13 ianwallen <ianwallen@anonymised.com>

Francois,

I see you already committed the changes… I’m not sure if you forgot this
one or you are not concerned about the classic interface

I would not say “not concerned”, but yes, not using it.

  • but here is
    another location that does status sorting.

Fixed in https://github.com/geonetwork/core-geonetwork/commit/bdb6709e0d071a6a1819eed04332d65eae2ddf31

Thanks for pointing this.

Francois

https://github.com/geonetwork/core-geonetwork/blob/develop/web/src/main/webapp/xsl/searchform_advanced.xsl#L318


View this message in context: http://osgeo-org.1560.x6.nabble.com/StatusValue-table-tp5072202p5072291.html

Sent from the GeoNetwork developer mailing list archive at Nabble.com.


Get 100% visibility into Java/.NET code with AppDynamics Lite!
It’s a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork