[GeoNetwork-devel] Tests failing in core module

Hi

I have done a clean checkout of the develop branch and when buiding with:

$ mvn clean install

I get a failed test:

LuceneIndexLanguageTrackerTest.testCanResetWhenFileIsLockedByProcess:119 expected:<index[_1]> but was:<index>

The line failing is this:

assertEquals(FSDirectoryFactory.NON_SPATIAL_DIR + “_” + 1, directoryFactory.getIndexDir().getName());

looks like directoryFactory.getIndexDir().getName() has the value index, but the check expects for some reason to be index_1.

I don’t understand really the check, also not sure if it’s a platform issue (using osx). Maybe others can check also and if possible explain the check?

Would be really good that this kind of tests have some code comments, as are not easily understandable and makes things difficult to maintain (I should apply this also in my code, for sure).

Regards,

Jose García


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net

I am not getting the same error as you.

I have a failure in web but not in any other modules. When I find the time I will try and see why web is failing.

Jesse

···

On Mon, Apr 14, 2014 at 9:54 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi

I have done a clean checkout of the develop branch and when buiding with:

$ mvn clean install

I get a failed test:

LuceneIndexLanguageTrackerTest.testCanResetWhenFileIsLockedByProcess:119 expected:<index[_1]> but was:<index>

The line failing is this:

assertEquals(FSDirectoryFactory.NON_SPATIAL_DIR + “_” + 1, directoryFactory.getIndexDir().getName());

looks like directoryFactory.getIndexDir().getName() has the value index, but the check expects for some reason to be index_1.

I don’t understand really the check, also not sure if it’s a platform issue (using osx). Maybe others can check also and if possible explain the check?

Would be really good that this kind of tests have some code comments, as are not easily understandable and makes things difficult to maintain (I should apply this also in my code, for sure).

Regards,

Jose García


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net


Learn Graph Databases - Download FREE O’Reilly Book
“Graph Databases” is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Hi Jesse

Thanks for checking, maybe is a platform issue. Can you explain why the index folders are expected to be like index_X in the test?

···

Regards,
Jose García

On Mon, Apr 14, 2014 at 12:45 PM, Jesse Eichar <jesse.eichar@anonymised.com> wrote:

I am not getting the same error as you.

I have a failure in web but not in any other modules. When I find the time I will try and see why web is failing.

Jesse


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net

On Mon, Apr 14, 2014 at 9:54 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi

I have done a clean checkout of the develop branch and when buiding with:

$ mvn clean install

I get a failed test:

LuceneIndexLanguageTrackerTest.testCanResetWhenFileIsLockedByProcess:119 expected:<index[_1]> but was:<index>

The line failing is this:

assertEquals(FSDirectoryFactory.NON_SPATIAL_DIR + “_” + 1, directoryFactory.getIndexDir().getName());

looks like directoryFactory.getIndexDir().getName() has the value index, but the check expects for some reason to be index_1.

I don’t understand really the check, also not sure if it’s a platform issue (using osx). Maybe others can check also and if possible explain the check?

Would be really good that this kind of tests have some code comments, as are not easily understandable and makes things difficult to maintain (I should apply this also in my code, for sure).

Regards,

Jose García


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net


Learn Graph Databases - Download FREE O’Reilly Book
“Graph Databases” is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Hi

About the web module test failing, for me seem all fine, if you provide the test failing I can take a look.

Regards,
Jose García

···

On Mon, Apr 14, 2014 at 12:58 PM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi Jesse

Thanks for checking, maybe is a platform issue. Can you explain why the index folders are expected to be like index_X in the test?


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net

Regards,
Jose García

On Mon, Apr 14, 2014 at 12:45 PM, Jesse Eichar <jesse.eichar@anonymised.com> wrote:

I am not getting the same error as you.

I have a failure in web but not in any other modules. When I find the time I will try and see why web is failing.

Jesse


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net

On Mon, Apr 14, 2014 at 9:54 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi

I have done a clean checkout of the develop branch and when buiding with:

$ mvn clean install

I get a failed test:

LuceneIndexLanguageTrackerTest.testCanResetWhenFileIsLockedByProcess:119 expected:<index[_1]> but was:<index>

The line failing is this:

assertEquals(FSDirectoryFactory.NON_SPATIAL_DIR + “_” + 1, directoryFactory.getIndexDir().getName());

looks like directoryFactory.getIndexDir().getName() has the value index, but the check expects for some reason to be index_1.

I don’t understand really the check, also not sure if it’s a platform issue (using osx). Maybe others can check also and if possible explain the check?

Would be really good that this kind of tests have some code comments, as are not easily understandable and makes things difficult to maintain (I should apply this also in my code, for sure).

Regards,

Jose García


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net


Learn Graph Databases - Download FREE O’Reilly Book
“Graph Databases” is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

I think i had local changes that made the web project fail is tests.

···

On Mon, Apr 14, 2014 at 12:58 PM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi Jesse

Thanks for checking, maybe is a platform issue. Can you explain why the index folders are expected to be like index_X in the test?


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net

Regards,
Jose García

On Mon, Apr 14, 2014 at 12:45 PM, Jesse Eichar <jesse.eichar@anonymised.com> wrote:

I am not getting the same error as you.

I have a failure in web but not in any other modules. When I find the time I will try and see why web is failing.

Jesse


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net

On Mon, Apr 14, 2014 at 9:54 AM, Jose Garcia <jose.garcia@anonymised.com> wrote:

Hi

I have done a clean checkout of the develop branch and when buiding with:

$ mvn clean install

I get a failed test:

LuceneIndexLanguageTrackerTest.testCanResetWhenFileIsLockedByProcess:119 expected:<index[_1]> but was:<index>

The line failing is this:

assertEquals(FSDirectoryFactory.NON_SPATIAL_DIR + “_” + 1, directoryFactory.getIndexDir().getName());

looks like directoryFactory.getIndexDir().getName() has the value index, but the check expects for some reason to be index_1.

I don’t understand really the check, also not sure if it’s a platform issue (using osx). Maybe others can check also and if possible explain the check?

Would be really good that this kind of tests have some code comments, as are not easily understandable and makes things difficult to maintain (I should apply this also in my code, for sure).

Regards,

Jose García


GeoCat Bridge for ArcGIS allows instant publishing of data and metadata on GeoServer and GeoNetwork. Visit http://geocat.net for details.


Jose García
GeoCat bv
Veenderweg 13
6721 WD Bennekom
The Netherlands
http://GeoCat.net


Learn Graph Databases - Download FREE O’Reilly Book
“Graph Databases” is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork