Hi,
web-itest has been commented out from the build. And I have a branch which changes the web-itest module to be webspecs maven adapter. It checks out webspecs and runs the integration tests. All the tests currently in web-itest are in the webspecs as well.
The module is only included in the build if the integration-tests profile is activated so the idea is that this would primarily be used on the continuous integration build and not each time a developer builds.
Last weekend I spent sometime to get most of the tests passing again and as a result found a couple of errors. One was a database connection leak which I consider to be critical.
My question: Can I merge these change to trunk? (it does not affect build without profile so it is a pretty safe change.) Not all tests pass yet because there have been enough changes since January (when I wrote them) that some have been broken but again it doesn’t affect build and it does have some important fixes.
Jesse
Hi Jesse,
This sounds like really good work and even better when it turns up critical fixes! For my part, I think you should commit these as soon as possible so that we can all use them in the RC process.
Cheers and thanks,
Simon
________________________________________
From: Jesse Eichar [jesse.eichar@anonymised.com]
Sent: Wednesday, 16 May 2012 4:52 AM
To: Devel geonetwork-devel@lists.sourceforge.net
Subject: [GeoNetwork-devel] web-itest
Hi,
web-itest has been commented out from the build. And I have a branch which changes the web-itest module to be webspecs maven adapter. It checks out webspecs and runs the integration tests. All the tests currently in web-itest are in the webspecs as well.
The module is only included in the build if the integration-tests profile is activated so the idea is that this would primarily be used on the continuous integration build and not each time a developer builds.
Last weekend I spent sometime to get most of the tests passing again and as a result found a couple of errors. One was a database connection leak which I consider to be critical.
My question: Can I merge these change to trunk? (it does not affect build without profile so it is a pretty safe change.) Not all tests pass yet because there have been enough changes since January (when I wrote them) that some have been broken but again it doesn't affect build and it does have some important fixes.
Jesse
It looks good to me too, Jesse.
Thanks
Francois
2012/5/15 Jesse Eichar <jesse.eichar@anonymised.com>:
Hi,
web-itest has been commented out from the build. And I have a branch which
changes the web-itest module to be webspecs maven adapter. It checks out
webspecs and runs the integration tests. All the tests currently in
web-itest are in the webspecs as well.
The module is only included in the build if the integration-tests profile is
activated so the idea is that this would primarily be used on the continuous
integration build and not each time a developer builds.
Last weekend I spent sometime to get most of the tests passing again and as
a result found a couple of errors. One was a database connection leak which
I consider to be critical.
My question: Can I merge these change to trunk? (it does not affect build
without profile so it is a pretty safe change.) Not all tests pass yet
because there have been enough changes since January (when I wrote them)
that some have been broken but again it doesn't affect build and it does
have some important fixes.
Jesse
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at
http://sourceforge.net/projects/geonetwork