Hi Simon,
I applied changes 3,4 and 6.
Please let me know, if you need anything else in this regard. Would be nice, if it could find it's way into the trunk.
Cheers,
Michael
-----Original Message-----
From: Pigot, Simon (CMAR, Hobart)
Sent: Monday, 30 November 2009 11:24 AM
To: Pigot, Simon (CMAR, Hobart); Stegherr, Michael (E&M, Kensington)
Subject: Your patch for Advanced search on temporal extent in 2.4.1Hi Michael,
Have looked through your patch - looks good - a few comments:
1. By allowing various options in the search forms to be
hidden with the +/- they can be invisible to the user if they
are set and the advanced search form is hidden and then
reopened - in the BlueNetMEST we expand them if they contain
values that are not default so the user can see that they are
set to something other than default values - might want to
consider the same code for the trunk.
2. Temporal extent fields will not be indexed correctly for
ISO format searching if the beginTime/endTime are not in ISO
format eg. see the WMO example records in the BlueNetMEST -
so the code for parsing from a variety of these formats needs
to be included ie. JODA time stuff in the BlueNetMEST
3. I suggest 'Dataset Issued' - which searches against the
temporal extent lucene fields - should be 'Resource time
range' - resources can be datasets, services etc
4. I suggest 'Resource Issued' - which searches against the
_changeDate lucene field (updated when metadata is modified)
- should be 'Metadata change date'
5. Problem that does not appear to be solved in either this
patch or the BlueNetMEST is how to handle records that have
multiple temporal extents (I think any extra temporal extent
values would be appended into one big string in the Lucene
fields tempExtentBegin and tempExtentEnd which I think would
kind of mucks up the search comparison? :-))
6. You should create tags with the english string in it for
each of the other translations (referring to changes made to
web/geonetwork/loc/en/strings.xml) so that at least something
appears when the page is viewed in those languages and
translators can work out what needs to be done (easy to
forget this - I know I have!)
7. A 'feature' of the search forms in the trunk is that if
you reset the form (advanced or simple) - only the client
side receives the reset (ie. fields are set to blank etc) -
the server side is never told to reset the search defaults
and so when the advanced search form or simple search form is
rendered using hide/show advanced options the reset values
reappear which can be kind of surprising for the user -
BlueNetMEST has a specific reset defaults ajax call which it
makes to the server to force the reset there as well - might
want to consider the same code for the trunk.I think at least 2 and 6 - (3 and 4 need resolving too but we
can argue about those :-)) - need to be resolved before this
can be committed and it would be nice to think about 5 as
well as I expect that problem is not unique to this
application of Lucene! Since you've already put this patch
together for the trunk using various pieces of code from the
BlueNetMEST, how about extending it to include the above?Cheers and thanks!
Simon
________________________________________
From: Simon.Pigot@anonymised.com [Simon.Pigot@anonymised.com]
Sent: Friday, 27 November 2009 3:45 AM
To: Stegherr, Michael (E&M, Kensington);
geonetwork-users@lists.sourceforge.net
Cc: geonetwork-devel@lists.sourceforge.net
Subject: Re: [GeoNetwork-devel] [ExternalEmail] Re:
[GeoNetwork-users] Advanced search for time extent in 2.4.1Hi Michael and Steve,
I'm interested - been busy with a workshop so have been a
little quiet for the last few days - I'll take a look at your
patch Michael over the next day or so.Cheers and thanks,
Simon
_______________________________________
From: Michael.Stegherr@anonymised.com [Michael.Stegherr@anonymised.com]
Sent: Thursday, 26 November 2009 5:27 PM
To: geonetwork-users@lists.sourceforge.net
Cc: geonetwork-devel@lists.sourceforge.net
Subject: [ExternalEmail] Re: [GeoNetwork-devel]
[GeoNetwork-users] Advanced search for time extent in 2.4.1Hi Steve,
> -----Original Message-----
> From: Stephen M Richard [mailto:steve.richard@anonymised.com]
> Sent: Thursday, 26 November 2009 4:48 AM
> Subject: Re: [GeoNetwork-users] Advanced search for time
> extent in 2.4.1
>
> I'm guessing the other date you're talking about is
> MD_DataIdentification/citation/CI_Citation/date, which is the
> date of most recent update to the resource that is described
> (not the same as the metadata record).This is correct.
> Of course there's always the question of which when the
> normal user will expect that AdvancedSearch actually refers to--
> --Update date for metadata record (probably not)
> --Date of currentness for the resource (maybe)
> --Temporal extent that the resource content describes (maybe)
>
> The last one is
> MD_DataIdentification/extent/EX_Extent/temporalElement/EX_Temp
> oralExtent....
>
> One problem that needs to be fixed is for the AdvancedSearch
> UI to clarify which when is 'When?'.The solutions I worked out with the WA Geothermal CoE people
and with help of Simon Pigot is the following:- easier access to documentation (click on "WHEN?")
- more descriptive labels for When?
("Resource issued" for
MD_DataIdentification/citation/CI_Citation/date,
"Dataset issued" for
MD_DataIdentification/extent/EX_Extent/temporalElement/EX_Temp
oralExtent...)It still needs a lot of refinement, but I attached the
patches, if someone is interested. You can also see how it works here:
http://wagcoe.ivec.org/geonetwork/Cheers,
Michael--------------------------------------------------------------
----------------
Let Crystal Reports handle the reporting - Free Crystal
Reports 2008 30-Day
trial. Simplify your report design, integration and
deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at
http://sourceforge.net/projects/geonetwork