[GeoNetwork-users] Commit modifications of GeoExt JS file

Hi,
I've modified the LegendWMS.js file in order to avoid the associated legend
coming from a WMS on a GeoServer with it's associated SLD to be displayed as
a GIF file in the MapViewer panel. The GIF file was providing a ugly display
of the legend specially for the labels. Instead I changed to PNG and
provided a border around the legend.
I've been able to see the modifications I've made using the ?debug URL
parameter and I'm happy with them.
Now, I would like to commit those modification to my GeoNetwork instance.
I've seen the procedure dealing with minifying the JS code and using
jsbuild.
http://trac.osgeo.org/geonetwork/wiki/HowToCompile
Unfortunately links to this jsbuild software are wrongs and I've not find
any reference of jsbuild inside OSGeo.
I've find jsbuild reference using Google on this page:
http://jsbuild.kodfabrik.com/

So, my questions are:
1/ Is this the right way to make such modifications in the code or did I
miss some more "high level" options to do the same ?
2/ If 1 is correct is the jsbuild link I provide the right one for minifying
the JS code ?

Thanks for your help.

Lionel

--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Commit-modifications-of-GeoExt-JS-file-tp4557597p4557597.html
Sent from the GeoNetwork users mailing list archive at Nabble.com.

I bring back this topic as I'm still facing this ugly gif legend display.
Is there any news on this ?

Cheers,

Lionel

--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Commit-modifications-of-GeoExt-JS-file-tp4557597p5036920.html
Sent from the GeoNetwork users mailing list archive at Nabble.com.

I'm not sure if this is the official repository but it looks like you can get
a copy from here.
    https://github.com/whitmo/jstools

And if you are on linux you may be able to install it using the following
(as described in the HowToCompile)

--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Commit-modifications-of-GeoExt-JS-file-tp4557597p5036935.html
Sent from the GeoNetwork users mailing list archive at Nabble.com.

Hi Ian,
thank you for your reply.
So your advice is to go through the minify approach as a "best practice" for
solving this pb ?

Lionel

--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Commit-modifications-of-GeoExt-JS-file-tp4557597p5036938.html
Sent from the GeoNetwork users mailing list archive at Nabble.com.

If you plan on submitting a patch then you don't need to minify it as it gets
minified during the compile.
I suggest that you create a new bug in Trac
<http://trac.osgeo.org/geonetwork/&gt; detailing the bug you are trying to
fix - you can also upload a patch to the ticket that was created. And if you
are comfortable with git, you can submit a pull request for the patch you
want to apply.

--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Commit-modifications-of-GeoExt-JS-file-tp4557597p5037233.html
Sent from the GeoNetwork users mailing list archive at Nabble.com.