If you have any improvements you want to contribute back, the best is to
use git to get a local copy of the source code, apply the fix and put out a
Pull request so your improvements can be integrated quickly. Otherwise you
can also create new Tickets in the issue tracker: https://github.com/geonetwork/core-geonetwork/issues
Thanks and congratulations to the all community members and developers that
have been putting efforts and energy in this release!
Jose García
PSC Member
--
*Vriendelijke groeten / Kind regards,Jose García
<http://www.geocat.net/>Veenderweg 136721 WD BennekomThe NetherlandsT: +31
(0)318 416664 <+31318416664>Please consider the environment before printing
this email.*
I understood the point of using *3.10.4-SNAPSHOT* was to make the next
*3.10.4* release, the use of 3.10.4*-0* forces maven to treat the version
number as a string.
3.10.0-0
3.10.1-0
3.10.2-0
3.10.3-0
3.10.4-0
...
3.6.0-0
3.8.0-0
(3.8.1 tag is 3.8.2-SNAPSHOT)
(3.8.2 tag is actually 3.8.3-SNAPSHOT)
3.8.3-0
4.0.0-alpha.3
In the above list 3.10.4-0 should be listed after 3.8.3-0 but because it
is being compared as a string it shows up in the wrong order.
In the future can I recommend removing the "-SNAPSHOT" when making a
release, so *3.10.4-SNAPSHOT* becomes *3.10.4 *on release.
--
Jody Garnett
On Thu, 1 Oct 2020 at 06:53, Jose Garcia <jose.garcia@anonymised.com> wrote:
If you have any improvements you want to contribute back, the best is to
use git to get a local copy of the source code, apply the fix and put out a
Pull request so your improvements can be integrated quickly. Otherwise you
can also create new Tickets in the issue tracker: https://github.com/geonetwork/core-geonetwork/issues
Thanks and congratulations to the all community members and developers
that have been putting efforts and energy in this release!
If you have any improvements you want to contribute back, the best is to
use git to get a local copy of the source code, apply the fix and put out a
Pull request so your improvements can be integrated quickly. Otherwise you
can also create new Tickets in the issue tracker: https://github.com/geonetwork/core-geonetwork/issues
Thanks and congratulations to the all community members and developers that
have been putting efforts and energy in this release!
I was going to offer to deploy the release to repo.osgeo.org but I see it is already done, and am surprised at the version number used:
org.geonetwork-opensource
domain
3.10.4-0
I understood the point of using 3.10.4-SNAPSHOT was to make the next 3.10.4 release, the use of 3.10.4**-0** forces maven to treat the version number as a string.
3.10.0-0
3.10.1-0
3.10.2-0
3.10.3-0
3.10.4-0
…
3.6.0-0
3.8.0-0
(3.8.1 tag is 3.8.2-SNAPSHOT)
(3.8.2 tag is actually 3.8.3-SNAPSHOT)
3.8.3-0
4.0.0-alpha.3
In the above list 3.10.4-0 should be listed after 3.8.3-0 but because it is being compared as a string it shows up in the wrong order.
···
In the future can I recommend removing the “-SNAPSHOT” when making a release, so 3.10.4-SNAPSHOT becomes 3.10.4 on release.
This change means that downstream projects can continue to compile against the master or 3.10.x branch and not have to be updated each time a release is made.
I also double checked my research, and found a new article which actually tested with unit tests what maven does for both version definition and sort order, rather than trust the documentation!
I was going to offer to deploy the release to repo.osgeo.org but I see it is already done, and am surprised at the version number used:
org.geonetwork-opensource
domain
3.10.4-0
I understood the point of using 3.10.4-SNAPSHOT was to make the next 3.10.4 release, the use of 3.10.4**-0** forces maven to treat the version number as a string.
3.10.0-0
3.10.1-0
3.10.2-0
3.10.3-0
3.10.4-0
…
3.6.0-0
3.8.0-0
(3.8.1 tag is 3.8.2-SNAPSHOT)
(3.8.2 tag is actually 3.8.3-SNAPSHOT)
3.8.3-0
4.0.0-alpha.3
In the above list 3.10.4-0 should be listed after 3.8.3-0 but because it is being compared as a string it shows up in the wrong order.
In the future can I recommend removing the “-SNAPSHOT” when making a release, so 3.10.4-SNAPSHOT becomes 3.10.4 on release.
If you have any improvements you want to contribute back, the best is to use git to get a local copy of the source code, apply the fix and put out a Pull request so your improvements can be integrated quickly. Otherwise you can also create new Tickets in the issue tracker: https://github.com/geonetwork/core-geonetwork/issues
Thanks and congratulations to the all community members and developers that have been putting efforts and energy in this release!