[Geoserver-devel] a little gsip clean-up

GeoServer GeoServer Developer
1

Hey all, was doing a bit of checking of gsip’s to get a handle on where different things are at, and I noticed that I think we’re a little out of date. I’m happy to move some wiki pages around, just wanted to raise some for discussion in case I missed something. Can people give feedback on the status on things? I’ll put my guesses based on what I’ve read, but I’ve been off this list for a bit so may easily miss some.

Please give quick feedback. If anything looks like a longer conversation we can move to its own thread - I’m just looking to clean up.

And for anyone who got this far in the email - check out http://geoserver.org/display/GEOS/Completed+Proposals Pretty cool history of the big things done in GeoServer in the past 5 years. Everyone should feel really proud of what’s been built.

2

On Thu, Dec 15, 2011 at 6:03 PM, Chris Holmes <cholmes@anonymised.com.> wrote:

  • GSIP 40 - Review Process
    This doesn’t look like it ever got finished. Started by Justin. Unless someone wants to propose a formal review process now we should probably kill it.

It’s basically empty, at the same time we have a certain amount of “practice” in terms of code reviews now,
a code review is required in practice for all large changes and for all patches made by someone that is not
a “maintainer” in a certain module (I know, we don’t have official maintainers of core modules, yet there
is people that qualify as one on many modules, it’s the module creator or the person that works on it the
most).

Agreed

Afaik this was never done

  • GSIP 53 Geoserver security improvement
    Christian and Justin have been working on this a bunch, no? But I guess we’ll still need a formal gsip and vote on it for that code to come home? Though if that code is already on trunk then we should probably have a vote and put under ‘active’.

Afaik the work Christian and Justin are doing is not the same as this GSIP, but I may be wrong.

Yep

  • GSIP 62 - WMS animator — Add a flexible WMS tool to generate animations based on sequences of WMS maps
    Done, right? I can move to ‘completed’.

Yep

  • GSIP 63 - Encrypt Plaintext Passwords — Support digest and encrypted passwords for users and datastore credentials.
    Move to ‘active’? It sounds like the new security work does a superset of this.

Right, not sure what’s the overlap/conflict between the two. The discussion between Christian and Ian on this one seemed to have reached
a stall.

Agreed

It has never been backported to 2.1.x, not sure if we are going to do it in the short term either.
I’d say, let’s move it to done?

Cheers
Andrea

–

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 339 8844549

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

3

On Thu, Dec 15, 2011 at 5:03 PM, Chris Holmes <cholmes@anonymised.com…1501…> wrote:

Hey all, was doing a bit of checking of gsip’s to get a handle on where different things are at, and I noticed that I think we’re a little out of date. I’m happy to move some wiki pages around, just wanted to raise some for discussion in case I missed something. Can people give feedback on the status on things? I’ll put my guesses based on what I’ve read, but I’ve been off this list for a bit so may easily miss some.

Please give quick feedback. If anything looks like a longer conversation we can move to its own thread - I’m just looking to clean up.

  • GSIP 36 - Resource - Publishing Split and Virtual Configuration
    Justin tells me that this is mostly getting superseded by the newer more iterative catalog stuff, but there may be some things there he wants eventually. Justin, should we just move to deferred and point to the others that have been done and then you can make a new one for anything more from it?

Yup, deferred works for me.

Yeah, i am fine with killing this one. As Andrea notes I think there is a pretty well established practice in place that is generally understood. The developer guide does a decent job but could probably be improved.

http://docs.geoserver.org/stable/en/developer/policies/index.html

The idea here was to have the catalog and config module be able to live totally standalone as a separate module. This relates back to the round of hibernate work that Emanuele had been working on. Not sure if there is still motivation to do that or not.

  • GSIP 53 Geoserver security improvement
    Christian and Justin have been working on this a bunch, no? But I guess we’ll still need a formal gsip and vote on it for that code to come home? Though if that code is already on trunk then we should probably have a vote and put under ‘active’.

Yeah, there is some overlap but in general this one seems to be centered upon how to define access control, whereas the stuff on the current security branch is more about pluggable authentication, and different types of backend stores for users, groups, and roles. We will however need a GSIP for that work soon so i am happy to recycle this one.

Move to ‘active’? It sounds like the new security work does a superset of this.

This one has been pretty much totally incorporated into the current security branch, and actually improved upon by Christian. So I think we should just roll this up into that GSIP when it comes. I would maybe leave it for now and we can poach when that time comes.

And for anyone who got this far in the email - check out http://geoserver.org/display/GEOS/Completed+Proposals Pretty cool history of the big things done in GeoServer in the past 5 years. Everyone should feel really proud of what’s been built.

10 Tips for Better Server Consolidation
Server virtualization is being driven by many needs.
But none more important than the need to reduce IT complexity
while improving strategic productivity. Learn More!
http://www.accelacomm.com/jaw/sdnl/114/51507609/

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

4

On Thu, Dec 15, 2011 at 12:22 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Thu, Dec 15, 2011 at 6:03 PM, Chris Holmes <cholmes@anonymised.com> wrote:

  • GSIP 40 - Review Process
    This doesn’t look like it ever got finished. Started by Justin. Unless someone wants to propose a formal review process now we should probably kill it.

It’s basically empty, at the same time we have a certain amount of “practice” in terms of code reviews now,
a code review is required in practice for all large changes and for all patches made by someone that is not
a “maintainer” in a certain module (I know, we don’t have official maintainers of core modules, yet there
is people that qualify as one on many modules, it’s the module creator or the person that works on it the
most).

Ok, I moved it to deferred. I’d say we can just accept that our review process evolves as the core devs see fit - don’t need a formal proposal unless we are contemplating some drastic change that warrants discussion.

Afaik this was never done

Ok, I’ll move to deferred - I imagine enough has already changed in the GeoServer internals that the proposal would change. It could of course be picked up from ‘deferred’ and reworked to in to an active discussion.

  • GSIP 53 Geoserver security improvement
    Christian and Justin have been working on this a bunch, no? But I guess we’ll still need a formal gsip and vote on it for that code to come home? Though if that code is already on trunk then we should probably have a vote and put under ‘active’.

Afaik the work Christian and Justin are doing is not the same as this GSIP, but I may be wrong.

Based on Justin’s feedback I’ll just leave this under ‘under discussion’ and it’ll be reworked to reflect what they’re doing. The title is generic enough to cover a lot, and the ‘discussion’ is a dialog that is resulting in some things changing.

Yep

Moved.

  • GSIP 62 - WMS animator — Add a flexible WMS tool to generate animations based on sequences of WMS maps
    Done, right? I can move to ‘completed’.

Yep

Moved.

  • GSIP 63 - Encrypt Plaintext Passwords — Support digest and encrypted passwords for users and datastore credentials.
    Move to ‘active’? It sounds like the new security work does a superset of this.

Right, not sure what’s the overlap/conflict between the two. The discussion between Christian and Ian on this one seemed to have reached
a stall.

Based on Justin’s feedback will leave in ‘under discussion’, and when it gets rolled up we can change its status.

Agreed

Moved.

It has never been backported to 2.1.x, not sure if we are going to do it in the short term either.
I’d say, let’s move it to done?

Yeah, I think we should move things to ‘completed’ when they reach the ‘target’ it says. So I’ll just change the line for ‘assigned to release’ to 2.2.x, removing the mention of 2.1.x

thanks for the feedback guys. Everyone else feel free to sound in, it’s easy to move things.

Cheers
Andrea

–

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 339 8844549

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf