[Geoserver-devel] A mockrunner removal branch

GeoServer GeoServer Developer
1

Hi,
after the discussion about the Spring upgrade Friday I thought a bit about
the mockrunner removal, which is one of the items that needs to be addressed
during a potential upgrade, and decided to see if I could get it off the table
during the weekend.

The plan was simple, use sprint-test, which provides similar classes, by:

  1. creating a set of mockrunner replacements that were simple subclases of the spring-test ones (put in the platform module, which everything depends on)
  2. remove the mockrunner dependencies and replace them with spring-test in pom files
  3. perform any adaptation necessary for method and behavior incompatibilities between the two sets of classes
  4. refactor out the subclasses leaving the code using directly sprint-test

Step 3 was … ughh… significantly less than mechanical, and I could not fix everything in community
modules (was running out of time), but managed to get core and extension building.

The result of this work can be found here:
https://github.com/aaime/geoserver/tree/mockrunner-spring

In particular, it’s split in three commits:

Now… what to do with it? My suggestion would be:

  • If we go for the Spring upgrade, see that as my contribution to the upgrade, and merge it soon
  • If we do not go for the Spring upgrade, no problem, it’s still useful work, let’s merge it right
    after the RC gets cut, on the new 2.10.x master? Downside, we’ll have to live longer with
    some difficulty in backporting for new tests that are low level enough to care about servlet API

As said, I could not get all community modules in communityRelease to pass tests, and I believe
there are failures due to the switch in:

  • script
  • rest-ext
    Also, I did not check at all modules that are not in the communityRelease profile.

Some help there would be appreciated :-p

Cheers
Andrea

···

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.