I think adding a build in the middle to clean (and probably also compile/package/install for consistency with step 1) the community modules is something we should add as well. I will test this out.
I don’t really have much to add with respect to the content of the community pom, but it sounds like it does make sense to not depend on gs-platform.
···
On Wed, Nov 2, 2016 at 1:27 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:
Hi Torben,
maybe the problem is due to how the build is configured?
The build does a two maven call:
-
-B -U -P allExtensions,printing,secJdbcJndiTest clean install -DconfigDirectory=…/…/…/data -T2 -fae (cleans core and extension)
-
-B -U -DskipTests -P allExtensions,communityRelease deploy -DconfigDirectory=…/…/…/data (builds also communityRelease, but does not clean it, so stuff is allowed to accumulate)
Not cleaning extension can have other ugly side effects, like leaving old versions of dependencies around in the target dirs when we upgrade them.
It’s however a bit strange in that master is configured the same way and it’s not getting timestamped jars…
and I’ve checked the working area now, in particular
http://ares.boundlessgeo.com/jenkins/view/geoserver/job/geoserver-2.10.x/ws/src/community/jms-cluster/activemqBroker/target/activemqBroker-2.10-SNAPSHOT/WEB-INF/lib/
it’s indeed full of timestamped jars, while:
http://ares.boundlessgeo.com/jenkins/view/geoserver/job/geoserver-master/ws/src/community/jms-cluster/activemqBroker/target/activemqBroker-2.11-SNAPSHOT/WEB-INF/lib/
has only one timestamped jar per geotools jar.
Also… why are they there to start with? This is a stripped down activemq server… the thing is, the dependency has been
added to the main community pom, and imho it should not be there to start with:
https://github.com/geoserver/geoserver/blob/master/src/community/pom.xml#L20
Looking at the history, it has been there from day one:
https://github.com/geoserver/geoserver-history/blame/master/src/community/pom.xml#L20
I still don’t know why jars are accumulating on 2.10.x only, but a few things seem to be clear:
- The maven build should be cleaning communityRelease too… we need a third build to do that without throwing away the work done by the first build, either make a “step zero” that cleans everything, or add a build in the middle that only cleans communityRelease
- The main community pom should not enforce a dependency on gs-platform, community modules can be “other” things that do no depend directly on GeoServer core, like a store/reader packaging, a datastore that the author desire to release only a GPL, a javascript GUI bit, and so on
Opinions/feedback?
Cheers
Andrea
On Wed, Nov 2, 2016 at 12:32 AM, Torben Barsballe <tbarsballe@anonymised.com> wrote:
We were able to fix the build failure by increasing the max upload size on repo.boundlessgeo.com to 200MB
Looking into the root cause, it appears that the activeMQ SNAPSHOT WAR has been slowly increasing in size over time, and is currently at about 112 MB.
Expanding the WAR and comparing the contents between the current version and a previous version (I compared https://repo.boundlessgeo.com/snapshot/org/geoserver/community/activemqBroker/2.10-SNAPSHOT/activemqBroker-2.10-20161030.140716-1099.war and https://repo.boundlessgeo.com/snapshot/org/geoserver/community/activemqBroker/2.10-SNAPSHOT/activemqBroker-2.10-20161101.225927-1107.war), it appears that there are multiple versions of several gt snapshot jars in the WAR.
The duplicated jars are:
gt-api-16-20161030.114305-790.jar
gt-coverage-16-20161030.114340-788.jar
gt-cql-16-20161030.114336-789.jar
gt-data-16-20161030.114337-789.jar
gt-epsg-hsql-16-20161030.114308-790.jar
gt-jdbc-16-20161030.114403-788.jar
gt-main-16-20161030.114322-789.jar
gt-metadata-16-20161030.114302-790.jar
gt-opengis-16-20161030.114256-790.jar
gt-render-16-20161030.114350-788.jar
gt-wms-16-20161030.114502-787.jar
gt-xml-16-20161030.114402-788.jar
activemqBroker-2.10-20161030.140716-1099.war had five different versions of each of these jars, eg:
gt-api-16-20161016.111429-782.jar
gt-api-16-20161017.162023-783.jar
gt-api-16-20161025.191154-787.jar
gt-api-16-20161026.193405-788.jar
gt-api-16-SNAPSHOT.jar
activemqBroker-2.10-20161101.225927-1107.war had six different versions of each of these jars, eg:
gt-api-16-20161016.111429-782.jar
gt-api-16-20161017.162023-783.jar
gt-api-16-20161025.191154-787.jar
gt-api-16-20161026.193405-788.jar
gt-api-16-20161030.114305-790.jar
gt-api-16-SNAPSHOT.jar
Looking at the ares logs from 2016-10-14 ( http://ares.boundlessgeo.com/jenkins/view/geoserver/job/geoserver-2.10.x/1/consoleFull ), the activeMQ war was about 58 MB.
Torben
–
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
On Tue, Nov 1, 2016 at 11:17 AM, Torben Barsballe <tbarsballe@anonymised.com> wrote:
Well, I’ve fixed GEOS-7830 - Community root pom defines a dependency on gs-gwc, and that doesn’t seem to have fixed the failure. (Which frankly doesn’t surprise me too much; GEOS-7830 affected both master and 2.10.x, but only 2.10.x is failing).
Torben
On Tue, Nov 1, 2016 at 12:58 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:
Hi Torben,
I believe Nuno has already identified the issue in an extra gwc dependency
in the community pom, however to my surprise I don’t see any commit to fix it yet:
https://github.com/geoserver/geoserver/commit/118acc311e36abcf892387bc98c7eb689110c56e
Today is a holiday in Italy, Nuno is likely taking the day off too, feel free to remove that
dependency right away, otherwise we’ll be around tomorrow
Cheers
Andrea
On Mon, Oct 31, 2016 at 10:30 PM, Torben Barsballe <tbarsballe@anonymised.com> wrote:
The last 3 GeServer 2.10.x builds (all three ran today) on ares have failed due to the activeMq community module:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy (default-deploy) on project activemqBroker:
Failed to deploy artifacts: Could not transfer artifact org.geoserver.community:activemqBroker:war:2.10-20161031.161135-1101 from/to boundless ([https://repo.boundlessgeo.com/snapshot/](https://repo.boundlessgeo.com/snapshot/)):
Failed to transfer file: [https://repo.boundlessgeo.com/snapshot/org/geoserver/community/activemqBroker/2.10-SNAPSHOT/activemqBroker-2.10-20161031.161135-1101.war](https://repo.boundlessgeo.com/snapshot/org/geoserver/community/activemqBroker/2.10-SNAPSHOT/activemqBroker-2.10-20161031.161135-1101.war).
Return code is: 413, ReasonPhrase: Request Entity Too Large. -> [Help 1]
Looking at the commit history, there does not appear to be any recent changes in that area (last change is 3 months ago).
HTTP 413 suggests that this may be a configuration change on the server, but if that were the case I would have suspected it to fail earlier. However, the activeMQ war is around 100 MB, so it certaintly is not small.
Anyone have any idea why this would just start failing?
Torben
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
