[Geoserver-devel] Adding support for viewParams in WPS embedded WFS requests

Hi,
currently you cannot specify the viewParams attribute in a WFS GetFeature request embedded in a WPS Execute statement.

This is because parsing of WFS requests is done through geotools bindings that are not aware of the viewParams attribute.

Having viewParams support is a nice improvement, in my opinion, since it opens new scenarios for WPS processes involving sqlviews driven feature types.

I tried an approach to get this done, and it’s working, but I would like to get more opinions on the “cleanest” way to do this kind of things.

Basically, what I tried to do is to replace the XSDDelegate responsible for WFS requests parsing used in GeoTools with a custom one, using GeoServer GetFeatureTypeBinding implementation (that is able to parse GeoServer vendor params).

This is the related snippet in GS WPSConfiguration:

protected void configureContext(MutablePicoContainer container) {
super.configureContext(container);

Object wfsDelegate = container.getComponentInstanceOfType(WFSParserDelegate.class);
container.unregisterComponentByInstance(wfsDelegate);
container.registerComponentInstance(new XSDParserDelegate(new WFSConfiguration() {

@Override
protected void configureBindings(MutablePicoContainer container) {
super.configureBindings(container);
container.registerComponentImplementation(WFS.GetFeatureType, GetFeatureTypeBinding.class);
}

}));
}

Can you think of a simpler / cleaner approach?

Maybe we can create a GS WFSDelegate that is using full GS WFSConfiguration objects, instead of the GT ones.

Any other idea?

···

Regards,

Mauro Bartolomeoli

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

On Tue, Aug 29, 2017 at 2:04 PM, Mauro Bartolomeoli <
mauro.bartolomeoli@anonymised.com> wrote:

Can you think of a simpler / cleaner approach?

Maybe we can create a GS WFSDelegate that is using full GS
WFSConfiguration objects, instead of the GT ones.

Hi Mauro,
I believe this one looks good. Using the WFS one would be interesting too,
the only downside I see is
that it would bind WPS startup to the presence of WFS in the classpath...
which in theory is a problem,
WPS should be able to work without WFS around, but in fact I don't know if
that's already the case
(I would guess WPS cannot start already without WFS around) and WFS is a
core module anyways.

Just creating a class at runtime should not prevent startup, should only
cause failure in when the
object is actually instantiated.

So... unsure, maybe leave it like you did it.

Cheers
Andrea

--

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

Hi, I opened a JIRA issue (https://osgeo-org.atlassian.net/browse/GEOS-8267) and created a pull request for this: https://github.com/geoserver/geoserver/pull/2504

Please, kindly review.

Mauro

···

2017-08-29 14:18 GMT+02:00 Andrea Aime <andrea.aime@anonymised.com>:

On Tue, Aug 29, 2017 at 2:04 PM, Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.comsolutions.it> wrote:

Can you think of a simpler / cleaner approach?

Maybe we can create a GS WFSDelegate that is using full GS WFSConfiguration objects, instead of the GT ones.

Hi Mauro,
I believe this one looks good. Using the WFS one would be interesting too, the only downside I see is
that it would bind WPS startup to the presence of WFS in the classpath… which in theory is a problem,
WPS should be able to work without WFS around, but in fact I don’t know if that’s already the case
(I would guess WPS cannot start already without WFS around) and WFS is a core module anyways.

Just creating a class at runtime should not prevent startup, should only cause failure in when the
object is actually instantiated.

So… unsure, maybe leave it like you did it.

Cheers
Andrea

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

Regards,

Mauro Bartolomeoli

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.