[Geoserver-devel] and now for the wfs 1.1 cite failure

GeoServer GeoServer Developer
1

TLDR: Mauro a change you made Sep 19th broke cite tests on master. Are you able to fix for the scheduled release tomorrow?

···

–
Jody Garnett

2

Hi Jody,
if I remember correctly, the fix was done as an addition the FOSS4G sprint attempt to upgrade to a new version of the cite tests.

My question is: did we ever upgrade?

If not, probably the fix to this failing test is simply reverting it (it was just adding a question mark to a url, so we only need to remove it).

Mauro

···

2015-01-19 6:27 GMT+01:00 Jody Garnett <jody.garnett@anonymised.com>:

TLDR: Mauro a change you made Sep 19th broke cite tests on master. Are you able to fix for the scheduled release tomorrow?

We have two cite failures a WCS cite failure (see other email thread) and a WFS 1.1 cite failure.

  • ant wfs-1.1-log
  • grep Failed
    [exec] Test wfs:wfs-main (wfs-1.1.0) Failed (Inherited Failure)
    [exec] Test wfs:readiness-tests (wfs-1.1.0/d41e34700_1) Failed (Inherited Failure)
    [exec] Test wfs:basic-main (wfs-1.1.0/d41e34700_1/d41e749_1) Failed (Inherited Failure)
    [exec] Test wfs:run-GetCapabilities-GET (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1) Failed (Inherited Failure)
    [exec] Test wfs:wfs-1.1.0-Basic-GetCapabilities-tc9.2 (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e853_1) Failed
    [exec] Test wfs:wfs-1.1.0-Basic-GetCapabilities-tc16.5 (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e930_1) Failed
  • ‘[’ 0 == 0 ‘]’
  • RETURN=1
  • echo RETURN=1
    RETURN=1

I am not quite sure what to make of this one?

Checking history - when did this start failing …

Failed > Console Output #345 Sep 20, 2014 4:40:46 PM

Success > Console Output #344 Sep 19, 2014 4:40:52 PM

So a week after the foss4g sprint working on cite tests.

Lets see what was happening on master about then:

Success > Console Output #792 Sep 21, 2014 3:29:15 PM

Success > Console Output #791 Sep 19, 2014 2:22:44 PM

So we have a suspect:

Here are the details…

Build #791 (Sep 19, 2014 2:22:44 PM)

Changes

GEOS-6675: workaround fix for wfs 1.1 cite tests failures (detail)

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET (detail)

Started by an SCM change

Revision: 763f20fe66c5e445b08241a0148b546bcad77ff3

origin/master

Here is the summary of the changes:

Summary

GEOS-6675: workaround fix for wfs 1.1 cite tests failures (details)

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET (details)

Commit e4dc4e829b885bd8b022fe265afd5a51cdee4773 by maurobartolomeoli

GEOS-6675: workaround fix for wfs 1.1 cite tests failures

The file was modified src/wfs/src/main/java/org/geoserver/wfs/CapabilitiesTransformer.java

Commit 9f09639262dcc73a9f6220e607f56c82400f3117 by maurobartolomeoli

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET

The file was modified src/wfs/src/main/java/org/geoserver/wfs/CapabilitiesTransformer.java

–
Jody Garnett

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

3

Based on your fix causing a test failure I am assuming we never upgraded.

···

On 19 January 2015 at 00:09, Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com> wrote:

Hi Jody,
if I remember correctly, the fix was done as an addition the FOSS4G sprint attempt to upgrade to a new version of the cite tests.

My question is: did we ever upgrade?

If not, probably the fix to this failing test is simply reverting it (it was just adding a question mark to a url, so we only need to remove it).

Mauro

–
Jody Garnett

2015-01-19 6:27 GMT+01:00 Jody Garnett <jody.garnett@anonymised.com>:

TLDR: Mauro a change you made Sep 19th broke cite tests on master. Are you able to fix for the scheduled release tomorrow?

We have two cite failures a WCS cite failure (see other email thread) and a WFS 1.1 cite failure.

  • ant wfs-1.1-log
  • grep Failed
    [exec] Test wfs:wfs-main (wfs-1.1.0) Failed (Inherited Failure)
    [exec] Test wfs:readiness-tests (wfs-1.1.0/d41e34700_1) Failed (Inherited Failure)
    [exec] Test wfs:basic-main (wfs-1.1.0/d41e34700_1/d41e749_1) Failed (Inherited Failure)
    [exec] Test wfs:run-GetCapabilities-GET (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1) Failed (Inherited Failure)
    [exec] Test wfs:wfs-1.1.0-Basic-GetCapabilities-tc9.2 (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e853_1) Failed
    [exec] Test wfs:wfs-1.1.0-Basic-GetCapabilities-tc16.5 (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e930_1) Failed
  • ‘[’ 0 == 0 ‘]’
  • RETURN=1
  • echo RETURN=1
    RETURN=1

I am not quite sure what to make of this one?

Checking history - when did this start failing …

Failed > Console Output #345 Sep 20, 2014 4:40:46 PM

Success > Console Output #344 Sep 19, 2014 4:40:52 PM

So a week after the foss4g sprint working on cite tests.

Lets see what was happening on master about then:

Success > Console Output #792 Sep 21, 2014 3:29:15 PM

Success > Console Output #791 Sep 19, 2014 2:22:44 PM

So we have a suspect:

Here are the details…

Build #791 (Sep 19, 2014 2:22:44 PM)

Changes

GEOS-6675: workaround fix for wfs 1.1 cite tests failures (detail)

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET (detail)

Started by an SCM change

Revision: 763f20fe66c5e445b08241a0148b546bcad77ff3

origin/master

Here is the summary of the changes:

Summary

GEOS-6675: workaround fix for wfs 1.1 cite tests failures (details)

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET (details)

Commit e4dc4e829b885bd8b022fe265afd5a51cdee4773 by maurobartolomeoli

GEOS-6675: workaround fix for wfs 1.1 cite tests failures

The file was modified src/wfs/src/main/java/org/geoserver/wfs/CapabilitiesTransformer.java

Commit 9f09639262dcc73a9f6220e607f56c82400f3117 by maurobartolomeoli

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET

The file was modified src/wfs/src/main/java/org/geoserver/wfs/CapabilitiesTransformer.java

–
Jody Garnett

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

4

It’s not a problem for me to revert it.
Should I do it?

Mauro

···

2015-01-19 9:23 GMT+01:00 Jody Garnett <jody.garnett@anonymised.com>:

Based on your fix causing a test failure I am assuming we never upgraded.

Jody

–

–
Jody Garnett

On 19 January 2015 at 00:09, Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com> wrote:

Hi Jody,
if I remember correctly, the fix was done as an addition the FOSS4G sprint attempt to upgrade to a new version of the cite tests.

My question is: did we ever upgrade?

If not, probably the fix to this failing test is simply reverting it (it was just adding a question mark to a url, so we only need to remove it).

Mauro

2015-01-19 6:27 GMT+01:00 Jody Garnett <jody.garnett@anonymised.com403…>:

TLDR: Mauro a change you made Sep 19th broke cite tests on master. Are you able to fix for the scheduled release tomorrow?

We have two cite failures a WCS cite failure (see other email thread) and a WFS 1.1 cite failure.

  • ant wfs-1.1-log
  • grep Failed
    [exec] Test wfs:wfs-main (wfs-1.1.0) Failed (Inherited Failure)
    [exec] Test wfs:readiness-tests (wfs-1.1.0/d41e34700_1) Failed (Inherited Failure)
    [exec] Test wfs:basic-main (wfs-1.1.0/d41e34700_1/d41e749_1) Failed (Inherited Failure)
    [exec] Test wfs:run-GetCapabilities-GET (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1) Failed (Inherited Failure)
    [exec] Test wfs:wfs-1.1.0-Basic-GetCapabilities-tc9.2 (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e853_1) Failed
    [exec] Test wfs:wfs-1.1.0-Basic-GetCapabilities-tc16.5 (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e930_1) Failed
  • ‘[’ 0 == 0 ‘]’
  • RETURN=1
  • echo RETURN=1
    RETURN=1

I am not quite sure what to make of this one?

Checking history - when did this start failing …

Failed > Console Output #345 Sep 20, 2014 4:40:46 PM

Success > Console Output #344 Sep 19, 2014 4:40:52 PM

So a week after the foss4g sprint working on cite tests.

Lets see what was happening on master about then:

Success > Console Output #792 Sep 21, 2014 3:29:15 PM

Success > Console Output #791 Sep 19, 2014 2:22:44 PM

So we have a suspect:

Here are the details…

Build #791 (Sep 19, 2014 2:22:44 PM)

Changes

GEOS-6675: workaround fix for wfs 1.1 cite tests failures (detail)

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET (detail)

Started by an SCM change

Revision: 763f20fe66c5e445b08241a0148b546bcad77ff3

origin/master

Here is the summary of the changes:

Summary

GEOS-6675: workaround fix for wfs 1.1 cite tests failures (details)

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET (details)

Commit e4dc4e829b885bd8b022fe265afd5a51cdee4773 by maurobartolomeoli

GEOS-6675: workaround fix for wfs 1.1 cite tests failures

The file was modified src/wfs/src/main/java/org/geoserver/wfs/CapabilitiesTransformer.java

Commit 9f09639262dcc73a9f6220e607f56c82400f3117 by maurobartolomeoli

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET

The file was modified src/wfs/src/main/java/org/geoserver/wfs/CapabilitiesTransformer.java

–
Jody Garnett

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

5

Please do so, and if we can kick the CITE build I should have a clear shot tomorrow morning.

···

2015-01-19 9:23 GMT+01:00 Jody Garnett <jody.garnett@anonymised.com>:

Based on your fix causing a test failure I am assuming we never upgraded.

Jody

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

–
Jody Garnett

On 19 January 2015 at 00:09, Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com> wrote:

Hi Jody,
if I remember correctly, the fix was done as an addition the FOSS4G sprint attempt to upgrade to a new version of the cite tests.

My question is: did we ever upgrade?

If not, probably the fix to this failing test is simply reverting it (it was just adding a question mark to a url, so we only need to remove it).

Mauro

2015-01-19 6:27 GMT+01:00 Jody Garnett <jody.garnett@anonymised.com403…>:

TLDR: Mauro a change you made Sep 19th broke cite tests on master. Are you able to fix for the scheduled release tomorrow?

We have two cite failures a WCS cite failure (see other email thread) and a WFS 1.1 cite failure.

  • ant wfs-1.1-log
  • grep Failed
    [exec] Test wfs:wfs-main (wfs-1.1.0) Failed (Inherited Failure)
    [exec] Test wfs:readiness-tests (wfs-1.1.0/d41e34700_1) Failed (Inherited Failure)
    [exec] Test wfs:basic-main (wfs-1.1.0/d41e34700_1/d41e749_1) Failed (Inherited Failure)
    [exec] Test wfs:run-GetCapabilities-GET (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1) Failed (Inherited Failure)
    [exec] Test wfs:wfs-1.1.0-Basic-GetCapabilities-tc9.2 (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e853_1) Failed
    [exec] Test wfs:wfs-1.1.0-Basic-GetCapabilities-tc16.5 (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e930_1) Failed
  • ‘[’ 0 == 0 ‘]’
  • RETURN=1
  • echo RETURN=1
    RETURN=1

I am not quite sure what to make of this one?

Checking history - when did this start failing …

Failed > Console Output #345 Sep 20, 2014 4:40:46 PM

Success > Console Output #344 Sep 19, 2014 4:40:52 PM

So a week after the foss4g sprint working on cite tests.

Lets see what was happening on master about then:

Success > Console Output #792 Sep 21, 2014 3:29:15 PM

Success > Console Output #791 Sep 19, 2014 2:22:44 PM

So we have a suspect:

Here are the details…

Build #791 (Sep 19, 2014 2:22:44 PM)

Changes

GEOS-6675: workaround fix for wfs 1.1 cite tests failures (detail)

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET (detail)

Started by an SCM change

Revision: 763f20fe66c5e445b08241a0148b546bcad77ff3

origin/master

Here is the summary of the changes:

Summary

GEOS-6675: workaround fix for wfs 1.1 cite tests failures (details)

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET (details)

Commit e4dc4e829b885bd8b022fe265afd5a51cdee4773 by maurobartolomeoli

GEOS-6675: workaround fix for wfs 1.1 cite tests failures

The file was modified src/wfs/src/main/java/org/geoserver/wfs/CapabilitiesTransformer.java

Commit 9f09639262dcc73a9f6220e607f56c82400f3117 by maurobartolomeoli

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET

The file was modified src/wfs/src/main/java/org/geoserver/wfs/CapabilitiesTransformer.java

–
Jody Garnett

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

6

Reverted.

Mauro

···

2015-01-19 9:34 GMT+01:00 Jody Garnett <jody.garnett@anonymised.com>:

Please do so, and if we can kick the CITE build I should have a clear shot tomorrow morning.

On Mon, Jan 19, 2015 at 12:30 AM Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com> wrote:

It’s not a problem for me to revert it.
Should I do it?

Mauro

–

2015-01-19 9:23 GMT+01:00 Jody Garnett <jody.garnett@anonymised.com>:

Based on your fix causing a test failure I am assuming we never upgraded.

Jody

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

–
Jody Garnett

On 19 January 2015 at 00:09, Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com> wrote:

Hi Jody,
if I remember correctly, the fix was done as an addition the FOSS4G sprint attempt to upgrade to a new version of the cite tests.

My question is: did we ever upgrade?

If not, probably the fix to this failing test is simply reverting it (it was just adding a question mark to a url, so we only need to remove it).

Mauro

2015-01-19 6:27 GMT+01:00 Jody Garnett <jody.garnett@anonymised.com403…>:

TLDR: Mauro a change you made Sep 19th broke cite tests on master. Are you able to fix for the scheduled release tomorrow?

We have two cite failures a WCS cite failure (see other email thread) and a WFS 1.1 cite failure.

  • ant wfs-1.1-log
  • grep Failed
    [exec] Test wfs:wfs-main (wfs-1.1.0) Failed (Inherited Failure)
    [exec] Test wfs:readiness-tests (wfs-1.1.0/d41e34700_1) Failed (Inherited Failure)
    [exec] Test wfs:basic-main (wfs-1.1.0/d41e34700_1/d41e749_1) Failed (Inherited Failure)
    [exec] Test wfs:run-GetCapabilities-GET (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1) Failed (Inherited Failure)
    [exec] Test wfs:wfs-1.1.0-Basic-GetCapabilities-tc9.2 (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e853_1) Failed
    [exec] Test wfs:wfs-1.1.0-Basic-GetCapabilities-tc16.5 (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e930_1) Failed
  • ‘[’ 0 == 0 ‘]’
  • RETURN=1
  • echo RETURN=1
    RETURN=1

I am not quite sure what to make of this one?

Checking history - when did this start failing …

Failed > Console Output #345 Sep 20, 2014 4:40:46 PM

Success > Console Output #344 Sep 19, 2014 4:40:52 PM

So a week after the foss4g sprint working on cite tests.

Lets see what was happening on master about then:

Success > Console Output #792 Sep 21, 2014 3:29:15 PM

Success > Console Output #791 Sep 19, 2014 2:22:44 PM

So we have a suspect:

Here are the details…

Build #791 (Sep 19, 2014 2:22:44 PM)

Changes

GEOS-6675: workaround fix for wfs 1.1 cite tests failures (detail)

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET (detail)

Started by an SCM change

Revision: 763f20fe66c5e445b08241a0148b546bcad77ff3

origin/master

Here is the summary of the changes:

Summary

GEOS-6675: workaround fix for wfs 1.1 cite tests failures (details)

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET (details)

Commit e4dc4e829b885bd8b022fe265afd5a51cdee4773 by maurobartolomeoli

GEOS-6675: workaround fix for wfs 1.1 cite tests failures

The file was modified src/wfs/src/main/java/org/geoserver/wfs/CapabilitiesTransformer.java

Commit 9f09639262dcc73a9f6220e607f56c82400f3117 by maurobartolomeoli

GEOS-6675: generalized fix to be applied always, not only for cite-tests and restricted to HTTP GET

The file was modified src/wfs/src/main/java/org/geoserver/wfs/CapabilitiesTransformer.java

–
Jody Garnett

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.