PR #553 factors out some code in the main module into a new method, but doesn’t change the function of it, and is otherwise confined to the JDBCConfig module. Would anyone object to backporting it to 2.5 now rather than waiting a month?
–
Kevin Smith
Junior Software Engineer | Boundless
+1-778-785-7459
Go for it, not it is nice if the pull requests have a Jira in order to be listed in our change log.
Jody Garnett
On Fri, Apr 11, 2014 at 6:15 AM, Kevin Smith <ksmith@anonymised.com> wrote:
PR #553 factors out some code in the main module into a new method, but doesn’t change the function of it, and is otherwise confined to the JDBCConfig module. Would anyone object to backporting it to 2.5 now rather than waiting a month?
–
Kevin Smith
Junior Software Engineer | Boundless
+1-778-785-7459
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
On Thu, Apr 10, 2014 at 10:15 PM, Kevin Smith <ksmith@anonymised.com>wrote:
PR #553 factors out some code in the main module into a new method, but
doesn't change the function of it, and is otherwise confined to the
JDBCConfig module. Would anyone object to backporting it to 2.5 now rather
than waiting a month?
The one month wait is for adding new features, this is mostly a reshuffle
of existing code right?
+1 on backporting
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
+1. Even though it is just a refactoring, backporting code improvements makes later cherry-picking easier.
On 11/04/14 04:15, Kevin Smith wrote:
PR #553 factors out some code in the main module into a new method, but
doesn't change the function of it, and is otherwise confined to the
JDBCConfig module. Would anyone object to backporting it to 2.5 now
rather than waiting a month?--
Kevin Smith
Junior Software Engineer | Boundless
ksmith@anonymised.com <mailto:ksmith@anonymised.com>
+1-778-785-7459
@boundlessgeo <https://twitter.com/boundlessgeo>
------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre
Thanks, I’ve backported it.
On 11 April 2014 00:46, Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com> wrote:
+1. Even though it is just a refactoring, backporting code improvements makes later cherry-picking easier.
On 11/04/14 04:15, Kevin Smith wrote:
PR #553 factors out some code in the main module into a new method, but
doesn’t change the function of it, and is otherwise confined to the
JDBCConfig module. Would anyone object to backporting it to 2.5 now
rather than waiting a month?–
Kevin Smith
Junior Software Engineer | Boundless
ksmith@anonymised.com…3839… mailto:[ksmith@anonymised.comcom](mailto:ksmith@anonymised.com)
+1-778-785-7459
@boundlessgeo <https://twitter.com/boundlessgeo>
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
Geoserver-devel mailing list
Geoserver-devel@anonymised.comsourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel–
Ben Caradoc-Davies Ben.Caradoc-Davies@anonymised.com
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre
–
Kevin Smith
Junior Software Engineer | Boundless
+1-778-785-7459