[Geoserver-devel] Backport recent JDBCConfig fixes/improvements

Several bug fixes and minor improvements to JDBCConfig have gone into master recently

https://github.com/geoserver/geoserver/pull/257 (Use JNDI to find the data source and an update to reflect an API change on master, that part could be removed but doesn’t seem to hurt anything if backported)

https://github.com/geoserver/geoserver/pull/308 (Fixed a bug, GEOS-5968, touches on CSW module, but that change can be safely removed as it’s just removing a workaround for the fixed bug)
https://github.com/geoserver/geoserver/pull/329 (Documentation update)
https://github.com/geoserver/geoserver/pull/335 (Fixed a bug, touches on restconfig and WMS modules, and the root POM. POM change can be removed by disabling the unit test for the fix)
https://github.com/geoserver/geoserver/pull/350 (Added a UI notice that JDBCConfig is working)
https://github.com/geoserver/geoserver/pull/369 (Change JDBCConfig to default to being off until the user has a chance to configure it)

I’d like to backport them onto 2.4. I’ve tested it both straight, and with the CSW and root POM changes removed and haven’t encountered any problems.

Kevin Smith

Junior Software Engineer | Boundless

ksmith@anonymised.com

+1-778-785-7459

@boundlessgeo

On Wed, Oct 23, 2013 at 6:53 PM, Kevin Smith <ksmith@anonymised.com>wrote:

Several bug fixes and minor improvements to JDBCConfig have gone into
master recently

https://github.com/geoserver/geoserver/pull/257 (Use JNDI to find the
data source and an update to reflect an API change on master, that part
could be removed but doesn't seem to hurt anything if backported)
https://github.com/geoserver/geoserver/pull/308 (Fixed a bug, GEOS-5968,
touches on CSW module, but that change can be safely removed as it's just
removing a workaround for the fixed bug)
https://github.com/geoserver/geoserver/pull/329 (Documentation update)
https://github.com/geoserver/geoserver/pull/335 (Fixed a bug, touches on
restconfig and WMS modules, and the root POM. POM change can be removed by
disabling the unit test for the fix)
https://github.com/geoserver/geoserver/pull/350 (Added a UI notice that
JDBCConfig is working)
https://github.com/geoserver/geoserver/pull/369 (Change JDBCConfig to
default to being off until the user has a chance to configure it)

I'd like to backport them onto 2.4. I've tested it both straight, and
with the CSW and root POM changes removed and haven't encountered any
problems.

All the changes touching a community module do not require any
authorization, you're free
to do as you see fit, besides talking to whoever is working on the module
(provided there is anyone).

What other changes are there?

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

Other changes outside JDBCConfig are: The WMS and Restconfig modules are changed as part of one fix, the root POM is updated with a newer EasyMock dependency used in a new unit test, and there’s a change to CSW in one fix, but it’s just removing a workaround for the bug being fixed.

···

On 23 October 2013 10:06, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Wed, Oct 23, 2013 at 6:53 PM, Kevin Smith <ksmith@anonymised.com> wrote:

Kevin Smith

Junior Software Engineer | Boundless

ksmith@anonymised.com

+1-778-785-7459

@boundlessgeo

Several bug fixes and minor improvements to JDBCConfig have gone into master recently

https://github.com/geoserver/geoserver/pull/257 (Use JNDI to find the data source and an update to reflect an API change on master, that part could be removed but doesn’t seem to hurt anything if backported)

https://github.com/geoserver/geoserver/pull/308 (Fixed a bug, GEOS-5968, touches on CSW module, but that change can be safely removed as it’s just removing a workaround for the fixed bug)
https://github.com/geoserver/geoserver/pull/329 (Documentation update)
https://github.com/geoserver/geoserver/pull/335 (Fixed a bug, touches on restconfig and WMS modules, and the root POM. POM change can be removed by disabling the unit test for the fix)
https://github.com/geoserver/geoserver/pull/350 (Added a UI notice that JDBCConfig is working)
https://github.com/geoserver/geoserver/pull/369 (Change JDBCConfig to default to being off until the user has a chance to configure it)

I’d like to backport them onto 2.4. I’ve tested it both straight, and with the CSW and root POM changes removed and haven’t encountered any problems.

All the changes touching a community module do not require any authorization, you’re free
to do as you see fit, besides talking to whoever is working on the module (provided there is anyone).

What other changes are there?

Cheers
Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


On Wed, Oct 23, 2013 at 7:41 PM, Kevin Smith <ksmith@anonymised.com>wrote:

Other changes outside JDBCConfig are: The WMS and Restconfig modules are
changed as part of one fix, the root POM is updated with a newer EasyMock
dependency used in a new unit test, and there's a change to CSW in one fix,
but it's just removing a workaround for the bug being fixed.

Hmm... ok, I had to go pull by pull searching for the above changes... but
they do look good
+1 for the backport

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

That’s why I listed other affected modules next to each pull in the original post.

···

On 23 October 2013 10:48, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Wed, Oct 23, 2013 at 7:41 PM, Kevin Smith <ksmith@anonymised.com> wrote:

Kevin Smith

Junior Software Engineer | Boundless

ksmith@anonymised.com

+1-778-785-7459

@boundlessgeo

Other changes outside JDBCConfig are: The WMS and Restconfig modules are changed as part of one fix, the root POM is updated with a newer EasyMock dependency used in a new unit test, and there’s a change to CSW in one fix, but it’s just removing a workaround for the bug being fixed.

Hmm… ok, I had to go pull by pull searching for the above changes… but they do look good
+1 for the backport

Cheers

Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it