[Geoserver-devel] Backporting spring and jetty changes

Hey folks, I wanted to get a feel for how devs would feel about back porting the recent jetty and spring upgrades to the 2.8.x branch? I’ve been working with them on master without any issues, not sure if anyone else has run into any hitches though.

If people do think this is a safe back port is now (with a 2.8 release pretty fresh out the door) a good time?

Thanks!

-Justin

Now that CITE tests have passed on master we can think about it :slight_smile: Master has not quite had the testing it usually does.

Let me check if now is a good time to back port, what were the bug fixes associated with a sprint / jetty upgrade again? Or is just for better compatibility.

···

On 26 November 2015 at 09:25, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hey folks, I wanted to get a feel for how devs would feel about back porting the recent jetty and spring upgrades to the 2.8.x branch? I’ve been working with them on master without any issues, not sure if anyone else has run into any hitches though.

If people do think this is a safe back port is now (with a 2.8 release pretty fresh out the door) a good time?

Thanks!

-Justin


Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


Jody Garnett

No specific bug fixes associated with the upgrade, it’s just bringing the libraries up to a version that are actually maintained/supported by the respective projects. And since I have a mandate to do it at the moment I thought I would offer.

···


Jody Garnett

On 26 November 2015 at 09:25, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hey folks, I wanted to get a feel for how devs would feel about back porting the recent jetty and spring upgrades to the 2.8.x branch? I’ve been working with them on master without any issues, not sure if anyone else has run into any hitches though.

If people do think this is a safe back port is now (with a 2.8 release pretty fresh out the door) a good time?

Thanks!

-Justin


Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140


Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Nifty, I like the idea - but we should wait to hear back from others.

···

On 26 November 2015 at 14:18, Justin Deoliveira <jdeolive@anonymised.com> wrote:

No specific bug fixes associated with the upgrade, it’s just bringing the libraries up to a version that are actually maintained/supported by the respective projects. And since I have a mandate to do it at the moment I thought I would offer.

On Thu, Nov 26, 2015 at 2:41 PM Jody Garnett <jody.garnett@anonymised.com> wrote:

Now that CITE tests have passed on master we can think about it :slight_smile: Master has not quite had the testing it usually does.

Let me check if now is a good time to back port, what were the bug fixes associated with a sprint / jetty upgrade again? Or is just for better compatibility.


Jody Garnett


Jody Garnett

On 26 November 2015 at 09:25, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hey folks, I wanted to get a feel for how devs would feel about back porting the recent jetty and spring upgrades to the 2.8.x branch? I’ve been working with them on master without any issues, not sure if anyone else has run into any hitches though.

If people do think this is a safe back port is now (with a 2.8 release pretty fresh out the door) a good time?

Thanks!

-Justin


Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140


Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Hi Justin,
this one had me thinking a while :slight_smile:

So, there are two separate things. The first one is the Spring upgrade. It’s an upgrade between
two minor versions, had a single commit, basically just the version number change in the pom files, worked fine.
The Spring integration is exercised by our tests and by the CITE tests, all of them seem to be working fine.
An upgrade of the library that wires everything is still risky, but given the above I’m not too concerned… let’s make that a +0?

I believe the Jetty upgrade is more contentious, more reward and more risk.
The Jetty we are shipping with on 2.8.x is a bit of an horror, old, inefficient, with known security risks, so an
upgrade is very much welcomed.
Testing wise however we are coming out pretty light though. We had the CITE tests running on master for a few
days, and I believe some people tested it interactively… but the stable series is meant for production, so I believe
we need more than that.
And then we have the installers: how many people have tried the windows and OSX installer with the new Jetty and can attest they are working?
Possibly a number <= 1, assuming Justin has had the time to check both when making the Jetty upgrade :-p

So… from this point of view I’d be -1 on the Jetty upgrade, but at the same time… it would be so good…
so what can be done to mitigate those risks?
Here is a few of ideas, hopefully others will add more/better ones:

  • Have a well known demo instance of GeoServer somewhere use the new bin package and see how it stands the load
  • We could run some of the benchmarking exercises on top of it
  • To have people use the installers, maybe cut a milestone release out of trunk? We have a few new features
    already in there to sweeten the pot and make it more interesting for people to kick its tires

What do you think?

Cheers
Andrea

···

On Thu, Nov 26, 2015 at 6:25 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hey folks, I wanted to get a feel for how devs would feel about back porting the recent jetty and spring upgrades to the 2.8.x branch? I’ve been working with them on master without any issues, not sure if anyone else has run into any hitches though.

If people do think this is a safe back port is now (with a 2.8 release pretty fresh out the door) a good time?

Thanks!

-Justin


Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


I am willing to test a nightly build.

I note that OpenGeo Suite ships with a slightly newer version of Jetty and I would be in favour of upgrading both for consistency.

···

On Thu, Nov 26, 2015 at 6:25 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hey folks, I wanted to get a feel for how devs would feel about back porting the recent jetty and spring upgrades to the 2.8.x branch? I’ve been working with them on master without any issues, not sure if anyone else has run into any hitches though.

If people do think this is a safe back port is now (with a 2.8 release pretty fresh out the door) a good time?

Thanks!

-Justin


Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140


Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


Fair enough. I will say that I have to do the back port regardless for a project but I can easily work from a branch in my own fork for now if folks decide it’s not worth the risk.

As for mitigating the risk, your suggestions all sound good. Regarding updating a demo server the only people I know that run a stable GeoServer demo are Boundless and GeoSolutions. So I’ll let those devs comment on if they want to do an upgrade. I can cut a 2.8.x build with the library upgrades or they can grab a nightly from master. Just let me know.

As for running benchmarks is there a test suite that is readily available and easy to set up? Depending on how much work is involved there I can volunteer some time to put to that.

As for a milestone release from master I can also put some time toward that as long as it’s something I can bust off in a few hours time frame. If there is going to be more ceremony around it not sure how much time I can devote to it at the moment.

···

On Thu, Nov 26, 2015 at 6:25 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hey folks, I wanted to get a feel for how devs would feel about back porting the recent jetty and spring upgrades to the 2.8.x branch? I’ve been working with them on master without any issues, not sure if anyone else has run into any hitches though.

If people do think this is a safe back port is now (with a 2.8 release pretty fresh out the door) a good time?

Thanks!

-Justin


Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140


Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


On Fri, Nov 27, 2015 at 5:54 PM, Justin Deoliveira <jdeolive@anonymised.com>
wrote:

Fair enough. I will say that I have to do the back port regardless for a
project but I can easily work from a branch in my own fork for now if folks
decide it’s not worth the risk.

As for mitigating the risk, your suggestions all sound good. Regarding
updating a demo server the only people I know that run a stable GeoServer
demo are Boundless and GeoSolutions. So I’ll let those devs comment on if
they want to do an upgrade. I can cut a 2.8.x build with the library
upgrades or they can grab a nightly from master. Just let me know.

I'll check internally. At the time of writing the demo servers are pretty
old, we have 2.6.x on both:
http://demo.geo-solutions.it/geoserver/web/
http://demo.opengeo.org/geoserver/web/

As for running benchmarks is there a test suite that is readily available
and easy to set up? Depending on how much work is involved there I can
volunteer some time to put to that.

Grabbing the data is the main pain point (tens of GB worth of). But I can
run the benchmarks locally if we get the other mitigation bits moving.

As for a milestone release from master I can also put some time toward
that as long as it’s something I can bust off in a few hours time frame. If
there is going to be more ceremony around it not sure how much time I can
devote to it at the moment.

I'd say, little or not ceremony needed, just run the release scripts on
master and make a quick blog post explaining why we did it? I can help with
a short description of the new features I've implemented so far

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

*Geosolutions' Winter Holidays from 24/12 to 6/1*

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

Justin:

Following up on this one based on test results - the milestone release is mostly successful:

  • linux: bin download works
  • windows: Jukka tested - my understanding is the bin download worked, but installer may be untested
  • osx: both bin and app install did not work (moving JAI jars to jetty/lib folder allowed it to start)

If we can figure out the above issue I am happy to backport.

···

On 26 November 2015 at 09:25, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hey folks, I wanted to get a feel for how devs would feel about back porting the recent jetty and spring upgrades to the 2.8.x branch? I’ve been working with them on master without any issues, not sure if anyone else has run into any hitches though.

If people do think this is a safe back port is now (with a 2.8 release pretty fresh out the door) a good time?

Thanks!

-Justin


Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


Jody Garnett

windows: Andrea tested windows installer and it functioned as expected

···

On 29 December 2015 at 14:04, Jody Garnett <jody.garnett@anonymised.com> wrote:

Justin:

Following up on this one based on test results - the milestone release is mostly successful:

  • linux: bin download works
  • windows: Jukka tested - my understanding is the bin download worked, but installer may be untested
  • osx: both bin and app install did not work (moving JAI jars to jetty/lib folder allowed it to start)

If we can figure out the above issue I am happy to backport.


Jody Garnett


Jody Garnett

On 26 November 2015 at 09:25, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hey folks, I wanted to get a feel for how devs would feel about back porting the recent jetty and spring upgrades to the 2.8.x branch? I’ve been working with them on master without any issues, not sure if anyone else has run into any hitches though.

If people do think this is a safe back port is now (with a 2.8 release pretty fresh out the door) a good time?

Thanks!

-Justin


Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140


Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel