[Geoserver-devel] Backporting spring and jetty changes

Hi,

I found why it fails for me and a way to repair it. There is a small difference betweeen the start command in the bin-zip that works and in the installer version that fails. See this part in the zip version:

:run

if “%JAVA_OPTS%” == “” (set JAVA_OPTS=-XX:MaxPermSize=128m)

cd %GEOSERVER_HOME%

echo Please wait while loading GeoServer…

echo.

“%RUN_JAVA%” “%JAVA_OPTS%” -DGEOSERVER_DATA_DIR=“%GEOSERVER_DATA_DIR%” -Djava.awt.headless=true -DSTOP.PORT=8079 -DSTOP.KEY=geoserver -jar start.jar

cd bin

goto end

So, java.exe –jar start.jar is run from the GEOSERVER_HOME, not from GEOSERVER_HOME\BIN where the startup.bat is located.

If I add:

cd …

as the first line into the startup.bat I can get also the installer version to start. I did not edit the path to jar but I kept it as “C:\Program Files (x86)\GeoServer 2.9-M0\start.jar” but I suggest to make the installer version of startup.bat similar to the zip version by adding “CD …” and use “–jar start.jar” without path because it seems to be reliable and clean.

Should we add -Djava.awt.headless=true also to the installer version? And remove MaxPermSize if GS 2.9 requires java 1.8 anyway?

-Jukka Rahkonen-

Andrea Aime wrote:

···

On Wed, Dec 30, 2015 at 9:38 PM, Rahkonen Jukka (MML) <jukka.rahkonen@…4189…> wrote:

Hi,

Did Andrea make a new test after he wrote what is cited in your mail below:

” - windows: Jukka tested - my understanding is the bin download worked, but installer may be untested”

I tested it during the last PSC meeting, because we were talking about the M0 release being blocked, Jody though

the issue was showing up on all OSs, but I remembered Linux working for me, so I first tested Linux again,

and then Windows using the installer on a clean machine (uninstalled the previous GeoServer before adding

the new one).

Bin-zip really worked for me. Installer seems to install everything OK but startup.bat does not start Geoserver. The error is:

C:\Program Files (x86)\GeoServer 2.9-M0\bin>call "C:\Program Files (x86)\Java\jr

e1.8.0_60\bin\java.exe" -DGEOSERVER_DATA_DIR="C:\Program Files (x86)\GeoServer 2

.9-M0\data_dir" -Xmx512m -XX:MaxPermSize=128m -DSTOP.PORT=8079 -DSTOP.KEY=geoser

ver -Djetty.port=8080 -Djetty.logs="C:\Program Files (x86)\GeoServer 2.9-M0\logs

" -jar “C:\Program Files (x86)\GeoServer 2.9-M0\start.jar”

Java HotSpot™ Client VM warning: ignoring option MaxPermSize=128m; support was removed in 8.0

WARNING: Module not found [ssl]

WARNING: Nothing to start, exiting …

Usage: java -jar start.jar [options] [properties] [configs]

java -jar start.jar --help # for more information

Startup.bat is really simple and all the paths look correct. By editing the path to start.jar I got another error so I do not know yet what makes it to fail.

call “C:\Program Files (x86)\Java\jre1.8.0_60\bin\java.exe” -DGEOSERVER_DATA_DIR=“C:\Program Files (x86)\GeoServer 2.9-M0\data_dir” -Xmx512m -XX:MaxPermSize=128m -DSTOP.PORT=8079 -DSTOP.KEY=geoserver -Djetty.port=8080 -Djetty.logs=“C:\Program Files (x86)\GeoServer 2.9-M0\logs” -jar “C:\Program Files (x86)\GeoServer 2.9-M0\start.jar”

I don’t know what’s going on there, although it’s similar to what Jody is seeing… could it be some incompatibility with a previous install?

Or maybe just draw of the luck when loading up jars from the file system?

Cheers

Andrea

==

GeoServer Professional Services from the experts! Visit

http://goo.gl/it488V for more information.

==

Geosolutions’ Winter Holidays from 24/12 to 6/1

Ing. Andrea Aime

@geowolf

Technical Lead

GeoSolutions S.A.S.

Via Poggio alle Viti 1187

55054 Massarosa (LU)

Italy

phone: +39 0584 962313

fax: +39 0584 1660272

mob: +39 339 8844549

http://www.geo-solutions.it

http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


Jukka,

the 2.9-M0 release was made before the migration to Java 8 and should run with Java 7.

In the Java 8 migration I removed the -XX:MaxPermSize line from startup.bat. I eradicated every mention of permsize/permgen that I could from the code base. Note that 2.9-M0 will not include this change.

Kind regards,
Ben.

On 01/01/16 00:17, Rahkonen Jukka (MML) wrote:

Hi,

I found why it fails for me and a way to repair it. There is a small difference betweeen the start command in the bin-zip that works and in the installer version that fails. See this part in the zip version:

:run
   if "%JAVA_OPTS%" == "" (set JAVA_OPTS=-XX:MaxPermSize=128m)
   cd %GEOSERVER_HOME%
   echo Please wait while loading GeoServer...
   echo.
   "%RUN_JAVA%" "%JAVA_OPTS%" -DGEOSERVER_DATA_DIR="%GEOSERVER_DATA_DIR%" -Djava.awt.headless=true -DSTOP.PORT=8079 -DSTOP.KEY=geoserver -jar start.jar
   cd bin
goto end

So, java.exe –jar start.jar is run from the GEOSERVER_HOME, not from GEOSERVER_HOME\BIN where the startup.bat is located.
If I add:
cd ..
as the first line into the startup.bat I can get also the installer version to start. I did not edit the path to jar but I kept it as "C:\Program Files (x86)\GeoServer 2.9-M0\start.jar" but I suggest to make the installer version of startup.bat similar to the zip version by adding “CD ..” and use “–jar start.jar” without path because it seems to be reliable and clean.
Should we add -Djava.awt.headless=true also to the installer version? And remove MaxPermSize if GS 2.9 requires java 1.8 anyway?

-Jukka Rahkonen-

Andrea Aime wrote:

On Wed, Dec 30, 2015 at 9:38 PM, Rahkonen Jukka (MML) <jukka.rahkonen@anonymised.com<mailto:jukka.rahkonen@anonymised.com>> wrote:
Hi,

Did Andrea make a new test after he wrote what is cited in your mail below:
” - windows: Jukka tested - my understanding is the bin download worked, but installer may be untested”

I tested it during the last PSC meeting, because we were talking about the M0 release being blocked, Jody though
the issue was showing up on all OSs, but I remembered Linux working for me, so I first tested Linux again,
and then Windows using the installer on a clean machine (uninstalled the previous GeoServer before adding
the new one).

Bin-zip really worked for me. Installer seems to install everything OK but startup.bat does not start Geoserver. The error is:

C:\Program Files (x86)\GeoServer 2.9-M0\bin>call "C:\Program Files (x86)\Java\jr
e1.8.0_60\bin\java.exe" -DGEOSERVER_DATA_DIR="C:\Program Files (x86)\GeoServer 2
.9-M0\data_dir" -Xmx512m -XX:MaxPermSize=128m -DSTOP.PORT=8079 -DSTOP.KEY=geoser
ver -Djetty.port=8080 -Djetty.logs="C:\Program Files (x86)\GeoServer 2.9-M0\logs
" -jar "C:\Program Files (x86)\GeoServer 2.9-M0\start.jar"
Java HotSpot(TM) Client VM warning: ignoring option MaxPermSize=128m; support was removed in 8.0
WARNING: Module not found [ssl]
WARNING: Nothing to start, exiting ...

Usage: java -jar start.jar [options] [properties] [configs]
        java -jar start.jar --help # for more information

Startup.bat is really simple and all the paths look correct. By editing the path to start.jar I got another error so I do not know yet what makes it to fail.

call "C:\Program Files (x86)\Java\jre1.8.0_60\bin\java.exe" -DGEOSERVER_DATA_DIR="C:\Program Files (x86)\GeoServer 2.9-M0\data_dir" -Xmx512m -XX:MaxPermSize=128m -DSTOP.PORT=8079 -DSTOP.KEY=geoserver -Djetty.port=8080 -Djetty.logs="C:\Program Files (x86)\GeoServer 2.9-M0\logs" -jar "C:\Program Files (x86)\GeoServer 2.9-M0\start.jar"

I don't know what's going on there, although it's similar to what Jody is seeing... could it be some incompatibility with a previous install?
Or maybe just draw of the luck when loading up jars from the file system?

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Geosolutions' Winter Holidays from 24/12 to 6/1

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

-------------------------------------------------------

------------------------------------------------------------------------------

_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/&gt;
New Zealand