[Geoserver-devel] beta progress

GeoServer GeoServer Developer
1

As per meeting here is an update with how far I got.

···

–
Jody Garnett

2

Note for the list: this in an occasional intermittent failure in a timeout-related test. See the PR for details. Jody has merged this one manually.

On 24/02/16 23:42, Jody Garnett wrote:

-https://github.com/geoserver/geoserver/pull/1510 - gives me a failure in
app schema (sent details to devon and ben)

--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/&gt;
New Zealand

3

Gotten through the above list (most requests from this weeks meeting made it in).

CITE tests are running now against:

···

On 24 February 2016 at 02:42, Jody Garnett <jody.garnett@anonymised.com> wrote:

As per meeting here is an update with how far I got.

–
Jody Garnett

–
Jody Garnett

4

Kevin has deployed gwc 1.9-beta (thanks kevin).

Release script is failing:

[ERROR] Failed to execute goal on project gs-release: Could not resolve dependencies for project org.geoserver:gs-release:jar:2.9-beta: Could not find artifact org.geoserver.extension:gs-geosearch:jar:2.9-beta in boundless (https://repo.boundlessgeo.com/main/) → [Help 1]

I expect there will be some back and forth on this while we update release to reflect recent changes.

···

On 24 February 2016 at 22:53, Jody Garnett <jody.garnett@anonymised.com> wrote:

Gotten through the above list (most requests from this weeks meeting made it in).

CITE tests are running now against:

version = 2.9-SNAPSHOT
git revision = c102461d0e5e9e7915bb41278407e728538e6c1c
git branch = c102461d0e5e9e7915bb41278407e728538e6c1c
build date = 25-Feb-2016 06:02
geotools version = 15-SNAPSHOT
geotools revision = 098e2447a031f65b7ebaeb167a122a94a2622b7c
geowebcache version = 1.9-SNAPSHOT
geowebcache revision = 986f5fc020edb0998dcaa0278644299a908a2e1e/986f5

–
Jody Garnett

–
Jody Garnett

On 24 February 2016 at 02:42, Jody Garnett <jody.garnett@anonymised.com> wrote:

As per meeting here is an update with how far I got.

–
Jody Garnett

5

Moving on … to javadocs failures - with messages like these:

[ERROR] /var/lib/jenkins/workspace/geoserver-release/src/platform/src/main/java/org/geoserver/platform/ExtensionProvider.java:21: error: unexpected end tag: </p>

Guess we did not try javadocs since upgrading to java 8 - doing so now.

···

On 26 February 2016 at 19:31, Jody Garnett <jody.garnett@anonymised.com> wrote:

Kevin has deployed gwc 1.9-beta (thanks kevin).

Release script is failing:

[ERROR] Failed to execute goal on project gs-release: Could not resolve dependencies for project org.geoserver:gs-release:jar:2.9-beta: Could not find artifact org.geoserver.extension:gs-geosearch:jar:2.9-beta in boundless (https://repo.boundlessgeo.com/main/) → [Help 1]

I expect there will be some back and forth on this while we update release to reflect recent changes.

–
Jody Garnett

–
Jody Garnett

On 24 February 2016 at 22:53, Jody Garnett <jody.garnett@anonymised.com> wrote:

Gotten through the above list (most requests from this weeks meeting made it in).

CITE tests are running now against:

version = 2.9-SNAPSHOT
git revision = c102461d0e5e9e7915bb41278407e728538e6c1c
git branch = c102461d0e5e9e7915bb41278407e728538e6c1c
build date = 25-Feb-2016 06:02
geotools version = 15-SNAPSHOT
geotools revision = 098e2447a031f65b7ebaeb167a122a94a2622b7c
geowebcache version = 1.9-SNAPSHOT
geowebcache revision = 986f5fc020edb0998dcaa0278644299a908a2e1e/986f5

–
Jody Garnett

On 24 February 2016 at 02:42, Jody Garnett <jody.garnett@anonymised.com> wrote:

As per meeting here is an update with how far I got.

–
Jody Garnett

6

Yes, this is the first release since the Java 8 upgrade, which was delayed until 2.9-M0 was complete.

On 27/02/16 17:37, Jody Garnett wrote:

Guess we did not try javadocs since upgrading to java 8 - doing so now.

--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/&gt;
New Zealand

7

So this is worth a feature branch:

Most errors thus far have been invalid links.

I am having trouble with class javadocs for generics, cannot seem to figure out how to make eclipse accept them (or ignore them).

Javadoc: Description expected after this reference

Currently working through these - introduced by all the auto generated “@throws Exception” and “@param x” javadocs that were never filled in with a description. Deleting these lines generates the same javadoc …

···

On 26 February 2016 at 22:32, Ben Caradoc-Davies <ben@anonymised.com> wrote:

Yes, this is the first release since the Java 8 upgrade, which was delayed until 2.9-M0 was complete.

On 27/02/16 17:37, Jody Garnett wrote:

Guess we did not try javadocs since upgrading to java 8 - doing so now.

–

Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand

–
Jody Garnett

8

Okay found info on java 8 “doclint” (enabled by default)… trying to turn it off:

-Xdoclint:none
···

On 26 February 2016 at 23:14, Jody Garnett <jody.garnett@anonymised.com> wrote:

So this is worth a feature branch:

Most errors thus far have been invalid links.

I am having trouble with class javadocs for generics, cannot seem to figure out how to make eclipse accept them (or ignore them).

Javadoc: Description expected after this reference

Currently working through these - introduced by all the auto generated “@throws Exception” and “@param x” javadocs that were never filled in with a description. Deleting these lines generates the same javadoc …

–
Jody Garnett

–
Jody Garnett

On 26 February 2016 at 22:32, Ben Caradoc-Davies <ben@anonymised.com> wrote:

Yes, this is the first release since the Java 8 upgrade, which was delayed until 2.9-M0 was complete.

On 27/02/16 17:37, Jody Garnett wrote:

Guess we did not try javadocs since upgrading to java 8 - doing so now.

–

Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand

9

Turning it off did not work, here is pull request for the manual correction of these errors:

···

On 26 February 2016 at 23:43, Jody Garnett <jody.garnett@anonymised.com> wrote:

Okay found info on java 8 “doclint” (enabled by default)… trying to turn it off:

-Xdoclint:none

–
Jody Garnett

–
Jody Garnett

On 26 February 2016 at 23:14, Jody Garnett <jody.garnett@anonymised.com> wrote:

So this is worth a feature branch:

Most errors thus far have been invalid links.

I am having trouble with class javadocs for generics, cannot seem to figure out how to make eclipse accept them (or ignore them).

Javadoc: Description expected after this reference

Currently working through these - introduced by all the auto generated “@throws Exception” and “@param x” javadocs that were never filled in with a description. Deleting these lines generates the same javadoc …

–
Jody Garnett

On 26 February 2016 at 22:32, Ben Caradoc-Davies <ben@anonymised.com> wrote:

Yes, this is the first release since the Java 8 upgrade, which was delayed until 2.9-M0 was complete.

On 27/02/16 17:37, Jody Garnett wrote:

Guess we did not try javadocs since upgrading to java 8 - doing so now.

–

Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand

10

That is strange. I disabled doclint on GeoTools master in December and this resolved the failure to generate javadocs on Java 8:
https://github.com/geotools/geotools/commit/502a6f3831a2734484989f85425838966ae452a6

On 27/02/16 21:13, Jody Garnett wrote:

Turning it off did not work, here is pull request for the manual correction
of these errors:

* https://github.com/geoserver/geoserver/pull/1520

--
Jody Garnett

On 26 February 2016 at 23:43, Jody Garnett <jody.garnett@anonymised.com> wrote:

Okay found info
<http://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-8-when-javadoc-tags-are-incomplete&gt;
on java 8 "doclint" (enabled by default)... trying to turn it off:

             <configuration>
                 <additionalparam>-Xdoclint:none</additionalparam>
             </configuration>

--
Jody Garnett

On 26 February 2016 at 23:14, Jody Garnett <jody.garnett@anonymised.com> wrote:

So this is worth a feature branch:

* https://github.com/geoserver/geoserver/tree/javadoc_errors

Most errors thus far have been invalid links.

I am having trouble with class javadocs for generics, cannot seem to
figure out how to make eclipse accept them (or ignore them).

*Javadoc: Description expected after this reference*
Currently working through these - introduced by all the auto generated
"@throws Exception" and "@param x" javadocs that were never filled in with
a description. Deleting these lines generates the same javadoc ...

--
Jody Garnett

On 26 February 2016 at 22:32, Ben Caradoc-Davies <ben@anonymised.com>
wrote:

Yes, this is the first release since the Java 8 upgrade, which was
delayed until 2.9-M0 was complete.

On 27/02/16 17:37, Jody Garnett wrote:

Guess we did not try javadocs since upgrading to java 8 - doing so now.

--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/&gt;
New Zealand

--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/&gt;
New Zealand

11

Ah, Andrea has the answer: GeoTools has the javadoc plugin in the build section, but GeoServer has it in the reporting section of the pom, so the configuration is ignored for javadoc:javadoc or javadoc:aggregate until moved to the build section:
https://github.com/geoserver/geoserver/pull/1520#issuecomment-189617075

(Email here for the benefit of the list)

On 28/02/16 07:43, Ben Caradoc-Davies wrote:

That is strange. I disabled doclint on GeoTools master in December and
this resolved the failure to generate javadocs on Java 8:
https://github.com/geotools/geotools/commit/502a6f3831a2734484989f85425838966ae452a6

--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/&gt;
New Zealand

12

Thanks for the fixes Andrea, artifacts are avaialble for testing here:

http://ares.boundlessgeo.com/geoserver/release/2.9-beta/

(I will catch up with the mac build tomorrow)

···

On 27 February 2016 at 00:13, Jody Garnett <jody.garnett@anonymised.com> wrote:

Turning it off did not work, here is pull request for the manual correction of these errors:

–
Jody Garnett

–
Jody Garnett

On 26 February 2016 at 23:43, Jody Garnett <jody.garnett@anonymised.com> wrote:

Okay found info on java 8 “doclint” (enabled by default)… trying to turn it off:

-Xdoclint:none

–
Jody Garnett

On 26 February 2016 at 23:14, Jody Garnett <jody.garnett@anonymised.com> wrote:

So this is worth a feature branch:

Most errors thus far have been invalid links.

I am having trouble with class javadocs for generics, cannot seem to figure out how to make eclipse accept them (or ignore them).

Javadoc: Description expected after this reference

Currently working through these - introduced by all the auto generated “@throws Exception” and “@param x” javadocs that were never filled in with a description. Deleting these lines generates the same javadoc …

–
Jody Garnett

On 26 February 2016 at 22:32, Ben Caradoc-Davies <ben@anonymised.com> wrote:

Yes, this is the first release since the Java 8 upgrade, which was delayed until 2.9-M0 was complete.

On 27/02/16 17:37, Jody Garnett wrote:

Guess we did not try javadocs since upgrading to java 8 - doing so now.

–

Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand

13

Was able to test the windows.exe, deploy on its way up to SF. Had a few glitches with community/release that we can look at for the RC1, and am still waiting on the mac DMG build.

Will write a blog post up tomorrow, mostly focused on this being a beta, collecting details for “about geoserver 2.9” section. If you have any blog posts that should be highlighted in these releases please reply to this email thread.
···

On 29 February 2016 at 22:59, Jody Garnett <jody.garnett@anonymised.com> wrote:

Thanks for the fixes Andrea, artifacts are avaialble for testing here:

http://ares.boundlessgeo.com/geoserver/release/2.9-beta/

(I will catch up with the mac build tomorrow)

–
Jody Garnett

–
Jody Garnett

On 27 February 2016 at 00:13, Jody Garnett <jody.garnett@anonymised.com> wrote:

Turning it off did not work, here is pull request for the manual correction of these errors:

–
Jody Garnett

On 26 February 2016 at 23:43, Jody Garnett <jody.garnett@anonymised.com> wrote:

Okay found info on java 8 “doclint” (enabled by default)… trying to turn it off:

-Xdoclint:none

–
Jody Garnett

On 26 February 2016 at 23:14, Jody Garnett <jody.garnett@anonymised.com> wrote:

So this is worth a feature branch:

Most errors thus far have been invalid links.

I am having trouble with class javadocs for generics, cannot seem to figure out how to make eclipse accept them (or ignore them).

Javadoc: Description expected after this reference

Currently working through these - introduced by all the auto generated “@throws Exception” and “@param x” javadocs that were never filled in with a description. Deleting these lines generates the same javadoc …

–
Jody Garnett

On 26 February 2016 at 22:32, Ben Caradoc-Davies <ben@anonymised.com> wrote:

Yes, this is the first release since the Java 8 upgrade, which was delayed until 2.9-M0 was complete.

On 27/02/16 17:37, Jody Garnett wrote:

Guess we did not try javadocs since upgrading to java 8 - doing so now.

–

Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand