[Geoserver-devel] Build failed in Hudson: geoserver-trunk #514

Gabriel_Roldan2 · September 15, 2008, 8:43pm

About this failure, why do we have a DescribeLayer test that expects version 1.1.0 to work, if we only implement 1.1.1?
moreover, you can make the following request:
http://sigma.openplans.org:8080/geoserver/wms?request=DescribeLayer&layers=topp:states&version=2.3.4
and get back a <WMS_DescribeLayerResponse version="2.3.4">, which seems odd to me.

My take on it is that we should stick to the supported version and hence catch a version missmatch in the request as early as possible (ie. DescribeLayerKvpRequestReader).

Otherwise does anyone know of a reason to be that permissive in DescribeLayer?

Gabriel

Hudson escribió:

See http://hudson.opengeo.org/hudson/job/geoserver-trunk/514/changes

Changes:

[groldan] GEOS-2223, propper exception messages for DescribeLayer and unit test suite

------------------------------------------
[...truncated 2985 lines...]
INFO: testDefaultStyle Buildings: pixel count=280000 non bg pixels: 289
Sep 16, 2008 9:40:19 AM org.geoserver.wms.WMSTestSupport assertNotBlank
INFO: testDefaultStyle RoadSegments: pixel count=280000 non bg pixels: 323
Sep 16, 2008 9:40:19 AM org.geoserver.wms.WMSTestSupport assertNotBlank
INFO: testDefaultStyle DividedRoutes: pixel count=280000 non bg pixels: 289
Sep 16, 2008 9:40:20 AM org.geoserver.wms.WMSTestSupport assertNotBlank
INFO: testDefaultStyle Lakes: pixel count=280000 non bg pixels: 289
Sep 16, 2008 9:40:20 AM org.geoserver.wms.WMSTestSupport assertNotBlank
INFO: testDefaultStyle MapNeatline: pixel count=280000 non bg pixels: 289
Sep 16, 2008 9:40:20 AM org.geoserver.wms.WMSTestSupport assertNotBlank
INFO: testDefaultStyle Ponds: pixel count=280000 non bg pixels: 289
Sep 16, 2008 9:40:20 AM org.geoserver.wms.WMSTestSupport assertNotBlank
INFO: testBlueLake: pixel count=250000 non bg pixels: 250000
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.383 sec
Running org.vfny.geoserver.wms.responses.featureinfo.FeatureDescriptionTemplateTest
<h4>testType</h4>

<ul class="textattributes">
  <li><strong><span class="atr-name">string</span>:</strong> <span class="atr-value">three</span></li>
  <li><strong><span class="atr-name">int</span>:</strong> <span class="atr-value">3</span></li>
  <li><strong><span class="atr-name">double</span>:</strong> <span class="atr-value">3.3</span></li>
  </ul>
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec
Running org.vfny.geoserver.wms.responses.helpers.WMSCapsTransformerTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.542 sec
Running org.vfny.geoserver.wms.requests.GetLegendGraphicKvpReaderTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.251 sec
Running org.vfny.geoserver.wms.responses.map.kml.KMLReflectorTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.209 sec
Running org.vfny.geoserver.wms.responses.featureinfo.FeatureTimeTemplateTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.37 sec
Running org.vfny.geoserver.wms.responses.map.kml.KMLTransformerTest
<?xml version="1.0" encoding="UTF-8"?>
<kml>
  <Document xmlns:atom="http://purl.org/atom/ns#">
    <name>Points</name>
    <Style id="GeoServerStylePoints.0">
      <IconStyle>
        <colorMode>normal</colorMode>
        <Icon>
          <href>http://localhost:80/geoserver/styles/bridge.png</href>
        </Icon>
      </IconStyle>
      <LabelStyle>
        <color>00ffffff</color>
      </LabelStyle>
    </Style>
    <Placemark id="Points.0">
      <name><![CDATA[Points.0]]></name>
      <description><![CDATA[<h4>Points</h4>

<ul class="textattributes">
  <li><strong><span class="atr-name">id</span>:</strong> <span class="atr-value">t0000</span></li>
  </ul>
]]></description>
      <LookAt>
        <longitude>500050.0</longitude>
        <latitude>500050.0</latitude>
        <heading>10.0</heading>
        <tilt>10.0</tilt>
        <range>700</range>
      </LookAt>
      <styleUrl>#GeoServerStylePoints.0</styleUrl>
      <Point>
        <coordinates>500050.0,500050.0</coordinates>
      </Point>
    </Placemark>
  </Document>
</kml>

Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.148 sec
Running org.vfny.geoserver.wms.responses.map.georss.RSSGeoRSSTransformerTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.588 sec
Running org.vfny.geoserver.wms.responses.palette.CustomPaletteBuilderTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.044 sec
Running org.geoserver.wms.WMSExtensionsTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 sec
Running org.vfny.geoserver.wms.responses.map.svg.SVGMapProducerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.239 sec
Running org.geoserver.wms.CapabilitiesTest
Sep 16, 2008 9:40:24 AM java.util.prefs.FileSystemPreferences$7 run
WARNING: Prefs file removed in background /home/tomcat/.java/.userPrefs/org/geotools/referencing/wkt/prefs.xml
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.32 sec
Running org.vfny.geoserver.wms.responses.map.metatile.QuickTileCacheTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec
Running org.vfny.geoserver.wms.responses.map.openlayers.OpenLayersMapTemplateTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.295 sec
Running org.vfny.geoserver.wms.responses.map.legend.DefaultRasterLegendProducerTest
Sep 16, 2008 9:40:24 AM org.geoserver.wms.WMSTestSupport assertNotBlank
INFO: testUserSpecifiedRule: pixel count=600 non bg pixels: 153
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.185 sec
Running org.geoserver.wms.kvp.GetMapKvpRequestReaderTest
Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.202 sec
Running org.vfny.geoserver.wms.responses.map.georss.AtomGeoRSSTransformerTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.218 sec
Running org.geoserver.wms.DefaultWebMapServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.29 sec
Running org.vfny.geoserver.wms.responses.featureinfo.GetFeatureInfoTest
16 Sep 09:40:26 ERROR [geoserver.ows] - org.vfny.geoserver.wms.WmsException: Invalid format 'unknown/format', supported formats are [text/plain, text/html, application/vnd.ogc.gml]
  at org.vfny.geoserver.wms.requests.GetFeatureInfoKvpReader.getRequest(GetFeatureInfoKvpReader.java:104)
  at org.geoserver.ows.adapters.KvpRequestReaderAdapter.createRequest(KvpRequestReaderAdapter.java:94)
  at org.geoserver.ows.Dispatcher.parseRequestKVP(Dispatcher.java:983)
  at org.geoserver.ows.Dispatcher.dispatch(Dispatcher.java:383)
  at org.geoserver.ows.Dispatcher.handleRequestInternal(Dispatcher.java:191)
  at org.springframework.web.servlet.mvc.AbstractController.handleRequest(AbstractController.java:153)
  at org.springframework.web.servlet.mvc.SimpleControllerHandlerAdapter.handle(SimpleControllerHandlerAdapter.java:48)
  at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:875)
  at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:809)
  at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:571)
  at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:501)
  at javax.servlet.http.HttpServlet.service(HttpServlet.java:689)
  at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
  at org.geoserver.test.GeoServerAbstractTestSupport.dispatch(GeoServerAbstractTestSupport.java:935)
  at org.geoserver.test.GeoServerAbstractTestSupport.dispatch(GeoServerAbstractTestSupport.java:902)
  at org.geoserver.test.GeoServerAbstractTestSupport.getAsServletResponse(GeoServerAbstractTestSupport.java:439)
  at org.geoserver.test.GeoServerAbstractTestSupport.get(GeoServerAbstractTestSupport.java:420)
  at org.vfny.geoserver.wms.responses.featureinfo.GetFeatureInfoTest.testUknownFormat(GetFeatureInfoTest.java:46)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
  at java.lang.reflect.Method.invoke(Method.java:585)
  at junit.framework.TestCase.runTest(TestCase.java:164)
  at org.geoserver.test.GeoServerAbstractTestSupport.runTest(GeoServerAbstractTestSupport.java:124)
  at junit.framework.TestCase.runBare(TestCase.java:130)
  at junit.framework.TestResult$1.protect(TestResult.java:106)
  at junit.framework.TestResult.runProtected(TestResult.java:124)
  at junit.framework.TestResult.run(TestResult.java:109)
  at junit.framework.TestCase.run(TestCase.java:120)
  at junit.framework.TestSuite.runTest(TestSuite.java:230)
  at junit.framework.TestSuite.run(TestSuite.java:225)
  at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
  at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
  at junit.framework.TestResult.runProtected(TestResult.java:124)
  at junit.extensions.TestSetup.run(TestSetup.java:25)
  at sun.reflect.GeneratedMethodAccessor107.invoke(Unknown Source)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
  at java.lang.reflect.Method.invoke(Method.java:585)
  at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
  at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
  at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
  at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
  at java.lang.reflect.Method.invoke(Method.java:585)
  at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:338)
  at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:997)
<?xml version="1.0" encoding="UTF-8"?>
<ServiceExceptionReport version="1.1.1"> <ServiceException code="InvalidParameterValue" locator="info_format">
      Invalid format 'unknown/format', supported formats are [text/plain, text/html, application/vnd.ogc.gml]
</ServiceException>
</ServiceExceptionReport>
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.247 sec
Running org.vfny.geoserver.wms.responses.map.kml.GeoSearchKMLTest
16 Sep 09:40:28 ERROR [geoserver.ows] - java.io.IOException
  at org.vfny.geoserver.wms.responses.map.kml.KMLMapProducer.writeTo(KMLMapProducer.java:125)
  at org.vfny.geoserver.wms.responses.GetMapResponse.writeTo(GetMapResponse.java:560)
  at org.geoserver.ows.adapters.ResponseAdapter.write(ResponseAdapter.java:60)
  at org.geoserver.ows.Dispatcher.response(Dispatcher.java:637)
  at org.geoserver.ows.Dispatcher.handleRequestInternal(Dispatcher.java:198)
  at org.springframework.web.servlet.mvc.AbstractController.handleRequest(AbstractController.java:153)
  at org.springframework.web.servlet.mvc.SimpleControllerHandlerAdapter.handle(SimpleControllerHandlerAdapter.java:48)
  at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:875)
  at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:809)
  at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:571)
  at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:501)
  at javax.servlet.http.HttpServlet.service(HttpServlet.java:689)
  at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
  at org.geoserver.test.GeoServerAbstractTestSupport.dispatch(GeoServerAbstractTestSupport.java:935)
  at org.geoserver.test.GeoServerAbstractTestSupport.dispatch(GeoServerAbstractTestSupport.java:902)
  at org.geoserver.test.GeoServerAbstractTestSupport.getAsServletResponse(GeoServerAbstractTestSupport.java:439)
  at org.geoserver.test.GeoServerAbstractTestSupport.get(GeoServerAbstractTestSupport.java:420)
  at org.geoserver.test.GeoServerAbstractTestSupport.getAsDOM(GeoServerAbstractTestSupport.java:633)
  at org.vfny.geoserver.wms.responses.map.kml.GeoSearchKMLTest.testBogusRegionator(GeoSearchKMLTest.java:92)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
  at java.lang.reflect.Method.invoke(Method.java:585)
  at junit.framework.TestCase.runTest(TestCase.java:164)
  at org.geoserver.test.GeoServerAbstractTestSupport.runTest(GeoServerAbstractTestSupport.java:124)
  at junit.framework.TestCase.runBare(TestCase.java:130)
  at junit.framework.TestResult$1.protect(TestResult.java:106)
  at junit.framework.TestResult.runProtected(TestResult.java:124)
  at junit.framework.TestResult.run(TestResult.java:109)
  at junit.framework.TestCase.run(TestCase.java:120)
  at junit.framework.TestSuite.runTest(TestSuite.java:230)
  at junit.framework.TestSuite.run(TestSuite.java:225)
  at sun.reflect.GeneratedMethodAccessor107.invoke(Unknown Source)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
  at java.lang.reflect.Method.invoke(Method.java:585)
  at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
  at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
  at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
  at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
  at java.lang.reflect.Method.invoke(Method.java:585)
  at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:338)
  at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:997)
Caused by: javax.xml.transform.TransformerException: Translator error
  at org.geotools.xml.transform.TransformerBase.transform(TransformerBase.java:133)
  at org.geotools.xml.transform.TransformerBase.transform(TransformerBase.java:108)
  at org.vfny.geoserver.wms.responses.map.kml.KMLMapProducer.writeTo(KMLMapProducer.java:122)
  ... 44 more
Caused by: java.lang.RuntimeException: org.vfny.geoserver.wms.WmsException: Unknown regionating strategy bogus
  at org.vfny.geoserver.wms.responses.map.kml.KMLTransformer$KMLTranslator.encodeVectorLayer(KMLTransformer.java:181)
  at org.vfny.geoserver.wms.responses.map.kml.KMLTransformer$KMLTranslator.encode(KMLTransformer.java:141)
  at org.geotools.xml.transform.TransformerBase$XMLReaderSupport.parse(TransformerBase.java:714)
  at org.apache.xalan.transformer.TransformerIdentityImpl.transform(TransformerIdentityImpl.java:484)
  at org.geotools.xml.transform.TransformerBase$Task.run(TransformerBase.java:296)
  at org.geotools.xml.transform.TransformerBase.transform(TransformerBase.java:129)
  ... 46 more
Caused by: org.vfny.geoserver.wms.WmsException: Unknown regionating strategy bogus
  at org.vfny.geoserver.wms.responses.map.kml.KMLUtils.loadFeatureCollection(KMLUtils.java:407)
  at org.vfny.geoserver.wms.responses.map.kml.KMLTransformer$KMLTranslator.encodeVectorLayer(KMLTransformer.java:177)
  ... 51 more
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.43 sec
Running org.vfny.geoserver.wms.responses.map.legend.GetLegendGraphicKvpReaderTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.183 sec
Running org.vfny.geoserver.wms.requests.DescribeLayerKvpRequestReaderTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec
Running org.vfny.geoserver.wms.responses.featureinfo.FeatureTemplateTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.213 sec

Results :

Failed tests: testDescribeLayerVersion110(org.vfny.geoserver.wms.DescribeLayerTest)

Tests run: 112, Failures: 1, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] There are test failures.

Please refer to http://hudson.opengeo.org/hudson/job/geoserver-trunk/ws/geoserver/wms/target/surefire-reports for the individual test results.
[INFO] ------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3 minutes 50 seconds
[INFO] Finished at: Tue Sep 16 09:40:29 EDT 2008
[INFO] Final Memory: 36M/63M
[INFO] ------------------------------------------------------------------------