[Geoserver-devel] Cascaded Stored Query update and question

GeoServer GeoServer Developer
1

Hi,

A quick status update and a question: The GeoTools work is in a pull request that Jody has just about accepted. I’ve merged my GeoServer work with master and created a pull request for GeoServer (https://github.com/geoserver/geoserver/pull/841). Comments please!

There’s been a good improvement in GeoServer regarding these types of special layers (these types = virtual tables + cascaded stored queries) in between the time when I originally wrote this and now. You’ve introduced the FeatureTypeCallback system so these kinds of layers can include their own logic inside these modules instead of polluting ResourcePool.getFeatureSource().

However, I’m a bit confused about the “temporary name” part in this pattern. I recall there was something similar before, but I can’t remember what this was for.

Looking at the API description for the callback, this functionality seems to be optional for the callback. As it stands, my feature ignores the temporary names and thus does no cleanup either.

https://github.com/sampov2/geoserver/blob/2.7.x-feature-cascaded-stored-query/src/main/src/main/java/org/geoserver/catalog/CascadedStoredQueryCallback.java

In what cases are these temporary names required?

Sampo

btw. If any of you are in London for GeoDATA 2014 on Thursday, come say hello. I’ll be manning our stand there.

···

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

2

Thanks for the hard work Sampo, and the feedback on our new API.

One trick I use to figure out new api calls in geoserver is look at the existing implementations of the method (and importantly references to the methods). Then I write a javadoc and submit it as a pull request for Andrea :slight_smile: Even if I guess wrong it is a nice starting point for a good javadoc :slight_smile:

Let me try for this out for your question…

The only call that uses a non null temporary name is in ResourcePool.getNonCacheableFeatureType( info, handleProjectionPolicy )

if (initializer != null) {
// use a highly random name, we don’t want to actually add the
// virtual table to the store as this feature type is not cacheable,
// it is “dirty” or un-saved. The renaming below will take care
// of making the user see the actual name
// NT 14/8/2012: Removed synchronization on jstore as it blocked query
// execution and risk of UUID clash is considered acceptable.

List typeNames = dataAccess.getNames();
String nsURI = null;
if (typeNames.size() > 0) {
nsURI = typeNames.get(0).getNamespaceURI();
}
do {
String name = UUID.randomUUID().toString();
temporaryName = new NameImpl(nsURI, name);
} while (Arrays.asList(typeNames).contains(temporaryName));
if (!initializer.initialize(info, dataAccess, temporaryName)) {
temporaryName = null;
}
}

So my guess is we are making a fake name to hold the virtual table in resource pool - and we go to such trouble so it won’t conflict with any really table (or view) from the database.

TLDR: ResourcePool seems to drive a lot of GeoServer, since it is a cache it wants things to have a name. We are creating a name so we can use resource pool logic (for items that are temporary and we do not want cached).

···

On Tue, Dec 2, 2014 at 6:31 AM, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

A quick status update and a question: The GeoTools work is in a pull request that Jody has just about accepted. I’ve merged my GeoServer work with master and created a pull request for GeoServer (https://github.com/geoserver/geoserver/pull/841). Comments please!

There’s been a good improvement in GeoServer regarding these types of special layers (these types = virtual tables + cascaded stored queries) in between the time when I originally wrote this and now. You’ve introduced the FeatureTypeCallback system so these kinds of layers can include their own logic inside these modules instead of polluting ResourcePool.getFeatureSource().

However, I’m a bit confused about the “temporary name” part in this pattern. I recall there was something similar before, but I can’t remember what this was for.

Looking at the API description for the callback, this functionality seems to be optional for the callback. As it stands, my feature ignores the temporary names and thus does no cleanup either.

https://github.com/sampov2/geoserver/blob/2.7.x-feature-cascaded-stored-query/src/main/src/main/java/org/geoserver/catalog/CascadedStoredQueryCallback.java

In what cases are these temporary names required?

Sampo

btw. If any of you are in London for GeoDATA 2014 on Thursday, come say hello. I’ll be manning our stand there.

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Jody Garnett

3

I went through and had a quick review of your pull request, a lot of small comments (and a couple questions) but nothing immediately troubling.

Can we get your FeatureTypeCallback question answered? I would like to get this pull request sorted while you still have time/budget.

···

On 2 December 2014 at 06:31, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

A quick status update and a question: The GeoTools work is in a pull request that Jody has just about accepted. I’ve merged my GeoServer work with master and created a pull request for GeoServer (https://github.com/geoserver/geoserver/pull/841). Comments please!

There’s been a good improvement in GeoServer regarding these types of special layers (these types = virtual tables + cascaded stored queries) in between the time when I originally wrote this and now. You’ve introduced the FeatureTypeCallback system so these kinds of layers can include their own logic inside these modules instead of polluting ResourcePool.getFeatureSource().

However, I’m a bit confused about the “temporary name” part in this pattern. I recall there was something similar before, but I can’t remember what this was for.

Looking at the API description for the callback, this functionality seems to be optional for the callback. As it stands, my feature ignores the temporary names and thus does no cleanup either.

https://github.com/sampov2/geoserver/blob/2.7.x-feature-cascaded-stored-query/src/main/src/main/java/org/geoserver/catalog/CascadedStoredQueryCallback.java

In what cases are these temporary names required?

Sampo

btw. If any of you are in London for GeoDATA 2014 on Thursday, come say hello. I’ll be manning our stand there.

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Jody Garnett

4

Hi,

I’ve now added temporary name support for my FeatureTypeCallback implementation. I think this should complete all the outstanding issues raised so far with this work.

Here’s the commit https://github.com/sampov2/geoserver/commit/7451f7949ce14f60e3e07cc341cf63a7bb986f79

Sampo

···

On Tue, Dec 9, 2014 at 1:32 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

I went through and had a quick review of your pull request, a lot of small comments (and a couple questions) but nothing immediately troubling.

Can we get your FeatureTypeCallback question answered? I would like to get this pull request sorted while you still have time/budget.

–
Jody

–

–
Jody Garnett

On 2 December 2014 at 06:31, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

A quick status update and a question: The GeoTools work is in a pull request that Jody has just about accepted. I’ve merged my GeoServer work with master and created a pull request for GeoServer (https://github.com/geoserver/geoserver/pull/841). Comments please!

There’s been a good improvement in GeoServer regarding these types of special layers (these types = virtual tables + cascaded stored queries) in between the time when I originally wrote this and now. You’ve introduced the FeatureTypeCallback system so these kinds of layers can include their own logic inside these modules instead of polluting ResourcePool.getFeatureSource().

However, I’m a bit confused about the “temporary name” part in this pattern. I recall there was something similar before, but I can’t remember what this was for.

Looking at the API description for the callback, this functionality seems to be optional for the callback. As it stands, my feature ignores the temporary names and thus does no cleanup either.

https://github.com/sampov2/geoserver/blob/2.7.x-feature-cascaded-stored-query/src/main/src/main/java/org/geoserver/catalog/CascadedStoredQueryCallback.java

In what cases are these temporary names required?

Sampo

btw. If any of you are in London for GeoDATA 2014 on Thursday, come say hello. I’ll be manning our stand there.

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com9…
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

5

Thanks Sampo, merged the work into master (just in time for christmas).

Ran into two glitches:

  • GeoServerFeatureSource was having trouble copying query hints (throwing illegal argument exception). I have patched the issue by logging these errors for now.
  • No docs (we can do that as a seperate pull request, even just to get the new screens document).
···

On 19 December 2014 at 03:25, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

I’ve now added temporary name support for my FeatureTypeCallback implementation. I think this should complete all the outstanding issues raised so far with this work.

Here’s the commit https://github.com/sampov2/geoserver/commit/7451f7949ce14f60e3e07cc341cf63a7bb986f79

Sampo

–
Jody Garnett

On Tue, Dec 9, 2014 at 1:32 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

I went through and had a quick review of your pull request, a lot of small comments (and a couple questions) but nothing immediately troubling.

Can we get your FeatureTypeCallback question answered? I would like to get this pull request sorted while you still have time/budget.

–
Jody

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

–
Jody Garnett

On 2 December 2014 at 06:31, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

A quick status update and a question: The GeoTools work is in a pull request that Jody has just about accepted. I’ve merged my GeoServer work with master and created a pull request for GeoServer (https://github.com/geoserver/geoserver/pull/841). Comments please!

There’s been a good improvement in GeoServer regarding these types of special layers (these types = virtual tables + cascaded stored queries) in between the time when I originally wrote this and now. You’ve introduced the FeatureTypeCallback system so these kinds of layers can include their own logic inside these modules instead of polluting ResourcePool.getFeatureSource().

However, I’m a bit confused about the “temporary name” part in this pattern. I recall there was something similar before, but I can’t remember what this was for.

Looking at the API description for the callback, this functionality seems to be optional for the callback. As it stands, my feature ignores the temporary names and thus does no cleanup either.

https://github.com/sampov2/geoserver/blob/2.7.x-feature-cascaded-stored-query/src/main/src/main/java/org/geoserver/catalog/CascadedStoredQueryCallback.java

In what cases are these temporary names required?

Sampo

btw. If any of you are in London for GeoDATA 2014 on Thursday, come say hello. I’ll be manning our stand there.

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

6

Hi,

Thanks Jody! Thanks for patching up the merge. I’ll talk to my client to arrange the documentation.

What’s the deadline for 2.7.x feature freeze?

Sampo

···

On Wed, Dec 24, 2014 at 7:05 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

Thanks Sampo, merged the work into master (just in time for christmas).

Ran into two glitches:

  • GeoServerFeatureSource was having trouble copying query hints (throwing illegal argument exception). I have patched the issue by logging these errors for now.
  • No docs (we can do that as a seperate pull request, even just to get the new screens document).

–
Jody

–

–
Jody Garnett

On 19 December 2014 at 03:25, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

I’ve now added temporary name support for my FeatureTypeCallback implementation. I think this should complete all the outstanding issues raised so far with this work.

Here’s the commit https://github.com/sampov2/geoserver/commit/7451f7949ce14f60e3e07cc341cf63a7bb986f79

Sampo

On Tue, Dec 9, 2014 at 1:32 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

I went through and had a quick review of your pull request, a lot of small comments (and a couple questions) but nothing immediately troubling.

Can we get your FeatureTypeCallback question answered? I would like to get this pull request sorted while you still have time/budget.

–
Jody

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

–
Jody Garnett

On 2 December 2014 at 06:31, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

A quick status update and a question: The GeoTools work is in a pull request that Jody has just about accepted. I’ve merged my GeoServer work with master and created a pull request for GeoServer (https://github.com/geoserver/geoserver/pull/841). Comments please!

There’s been a good improvement in GeoServer regarding these types of special layers (these types = virtual tables + cascaded stored queries) in between the time when I originally wrote this and now. You’ve introduced the FeatureTypeCallback system so these kinds of layers can include their own logic inside these modules instead of polluting ResourcePool.getFeatureSource().

However, I’m a bit confused about the “temporary name” part in this pattern. I recall there was something similar before, but I can’t remember what this was for.

Looking at the API description for the callback, this functionality seems to be optional for the callback. As it stands, my feature ignores the temporary names and thus does no cleanup either.

https://github.com/sampov2/geoserver/blob/2.7.x-feature-cascaded-stored-query/src/main/src/main/java/org/geoserver/catalog/CascadedStoredQueryCallback.java

In what cases are these temporary names required?

Sampo

btw. If any of you are in London for GeoDATA 2014 on Thursday, come say hello. I’ll be manning our stand there.

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@…3889…
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

7

Hi Sampo,

By the release schedule it is 2015-01-18
https://github.com/geoserver/geoserver/wiki/Release-Schedule

-Jukka Rahkonen-

···

Sampo Savolainen wrote:

Hi,

Thanks Jody! Thanks for patching up the merge. I’ll talk to my client to arrange the documentation.

What’s the deadline for 2.7.x feature freeze?

Sampo

On Wed, Dec 24, 2014 at 7:05 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

Thanks Sampo, merged the work into master (just in time for christmas).

Ran into two glitches:

  • GeoServerFeatureSource was having trouble copying query hints (throwing illegal argument exception). I have patched the issue by logging these errors for now.
  • No docs (we can do that as a seperate pull request, even just to get the new screens document).

–
Jody

–
Jody Garnett

On 19 December 2014 at 03:25, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

I’ve now added temporary name support for my FeatureTypeCallback implementation. I think this should complete all the outstanding issues raised so far with this work.

Here’s the commit https://github.com/sampov2/geoserver/commit/7451f7949ce14f60e3e07cc341cf63a7bb986f79

Sampo

On Tue, Dec 9, 2014 at 1:32 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

I went through and had a quick review of your pull request, a lot of small comments (and a couple questions) but nothing immediately troubling.

Can we get your FeatureTypeCallback question answered? I would like to get this pull request sorted while you still have time/budget.

–
Jody

–
Jody Garnett

On 2 December 2014 at 06:31, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

A quick status update and a question: The GeoTools work is in a pull request that Jody has just about accepted. I’ve merged my GeoServer work with master and created a pull request for GeoServer (https://github.com/geoserver/geoserver/pull/841). Comments please!

There’s been a good improvement in GeoServer regarding these types of special layers (these types = virtual tables + cascaded stored queries) in between the time when I originally wrote this and now. You’ve introduced the FeatureTypeCallback system so these kinds of layers can include their own logic inside these modules instead of polluting ResourcePool.getFeatureSource().

However, I’m a bit confused about the “temporary name” part in this pattern. I recall there was something similar before, but I can’t remember what this was for.

Looking at the API description for the callback, this functionality seems to be optional for the callback. As it stands, my feature ignores the temporary names and thus does no cleanup either.

https://github.com/sampov2/geoserver/blob/2.7.x-feature-cascaded-stored-query/src/main/src/main/java/org/geoserver/catalog/CascadedStoredQueryCallback.java

In what cases are these temporary names required?

Sampo

btw. If any of you are in London for GeoDATA 2014 on Thursday, come say hello. I’ll be manning our stand there.

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

8

Hi,

I’ve got the go-ahead from my client for me to use the hours for the documentation. Is there a guide on how to write the docs? Or maybe just point me to a good example I could follow?

Thanks,
Sampo

···

On Mon, Dec 29, 2014 at 12:18 PM, Rahkonen Jukka (Tike) <jukka.rahkonen@anonymised.com> wrote:

Hi Sampo,

By the release schedule it is 2015-01-18
https://github.com/geoserver/geoserver/wiki/Release-Schedule

-Jukka Rahkonen-

Sampo Savolainen wrote:

Hi,

Thanks Jody! Thanks for patching up the merge. I’ll talk to my client to arrange the documentation.

What’s the deadline for 2.7.x feature freeze?

Sampo

–

On Wed, Dec 24, 2014 at 7:05 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

Thanks Sampo, merged the work into master (just in time for christmas).

Ran into two glitches:

  • GeoServerFeatureSource was having trouble copying query hints (throwing illegal argument exception). I have patched the issue by logging these errors for now.
  • No docs (we can do that as a seperate pull request, even just to get the new screens document).

–
Jody

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

–
Jody Garnett

On 19 December 2014 at 03:25, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

I’ve now added temporary name support for my FeatureTypeCallback implementation. I think this should complete all the outstanding issues raised so far with this work.

Here’s the commit https://github.com/sampov2/geoserver/commit/7451f7949ce14f60e3e07cc341cf63a7bb986f79

Sampo

On Tue, Dec 9, 2014 at 1:32 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

I went through and had a quick review of your pull request, a lot of small comments (and a couple questions) but nothing immediately troubling.

Can we get your FeatureTypeCallback question answered? I would like to get this pull request sorted while you still have time/budget.

–
Jody

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

–
Jody Garnett

On 2 December 2014 at 06:31, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

A quick status update and a question: The GeoTools work is in a pull request that Jody has just about accepted. I’ve merged my GeoServer work with master and created a pull request for GeoServer (https://github.com/geoserver/geoserver/pull/841). Comments please!

There’s been a good improvement in GeoServer regarding these types of special layers (these types = virtual tables + cascaded stored queries) in between the time when I originally wrote this and now. You’ve introduced the FeatureTypeCallback system so these kinds of layers can include their own logic inside these modules instead of polluting ResourcePool.getFeatureSource().

However, I’m a bit confused about the “temporary name” part in this pattern. I recall there was something similar before, but I can’t remember what this was for.

Looking at the API description for the callback, this functionality seems to be optional for the callback. As it stands, my feature ignores the temporary names and thus does no cleanup either.

https://github.com/sampov2/geoserver/blob/2.7.x-feature-cascaded-stored-query/src/main/src/main/java/org/geoserver/catalog/CascadedStoredQueryCallback.java

In what cases are these temporary names required?

Sampo

btw. If any of you are in London for GeoDATA 2014 on Thursday, come say hello. I’ll be manning our stand there.

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@…3889…
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

9

Cool … and you know this is the geoserver project. Not only do we have docs on how to write docs … we have stand alone guide on how to write docs!

Here you go:

(I admit the link was a fair ways down the http://docs.geoserver.org page)

Now the good news - documentation is not functional so it won’t be tragic if you do not get the docs in by the Jan 18th code freeze. Ideally you can submit a pull request before the beta.

Mike are you available to review this when the pull request comes in?

···

On 8 January 2015 at 07:25, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

I’ve got the go-ahead from my client for me to use the hours for the documentation. Is there a guide on how to write the docs? Or maybe just point me to a good example I could follow?

Thanks,
Sampo

Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Jody Garnett

On Mon, Dec 29, 2014 at 12:18 PM, Rahkonen Jukka (Tike) <jukka.rahkonen@anonymised.com…> wrote:

Hi Sampo,

By the release schedule it is 2015-01-18
https://github.com/geoserver/geoserver/wiki/Release-Schedule

-Jukka Rahkonen-

Sampo Savolainen wrote:

Hi,

Thanks Jody! Thanks for patching up the merge. I’ll talk to my client to arrange the documentation.

What’s the deadline for 2.7.x feature freeze?

Sampo

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

On Wed, Dec 24, 2014 at 7:05 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

Thanks Sampo, merged the work into master (just in time for christmas).

Ran into two glitches:

  • GeoServerFeatureSource was having trouble copying query hints (throwing illegal argument exception). I have patched the issue by logging these errors for now.
  • No docs (we can do that as a seperate pull request, even just to get the new screens document).

–
Jody

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

–
Jody Garnett

On 19 December 2014 at 03:25, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

I’ve now added temporary name support for my FeatureTypeCallback implementation. I think this should complete all the outstanding issues raised so far with this work.

Here’s the commit https://github.com/sampov2/geoserver/commit/7451f7949ce14f60e3e07cc341cf63a7bb986f79

Sampo

On Tue, Dec 9, 2014 at 1:32 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

I went through and had a quick review of your pull request, a lot of small comments (and a couple questions) but nothing immediately troubling.

Can we get your FeatureTypeCallback question answered? I would like to get this pull request sorted while you still have time/budget.

–
Jody

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

–
Jody Garnett

On 2 December 2014 at 06:31, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

A quick status update and a question: The GeoTools work is in a pull request that Jody has just about accepted. I’ve merged my GeoServer work with master and created a pull request for GeoServer (https://github.com/geoserver/geoserver/pull/841). Comments please!

There’s been a good improvement in GeoServer regarding these types of special layers (these types = virtual tables + cascaded stored queries) in between the time when I originally wrote this and now. You’ve introduced the FeatureTypeCallback system so these kinds of layers can include their own logic inside these modules instead of polluting ResourcePool.getFeatureSource().

However, I’m a bit confused about the “temporary name” part in this pattern. I recall there was something similar before, but I can’t remember what this was for.

Looking at the API description for the callback, this functionality seems to be optional for the callback. As it stands, my feature ignores the temporary names and thus does no cleanup either.

https://github.com/sampov2/geoserver/blob/2.7.x-feature-cascaded-stored-query/src/main/src/main/java/org/geoserver/catalog/CascadedStoredQueryCallback.java

In what cases are these temporary names required?

Sampo

btw. If any of you are in London for GeoDATA 2014 on Thursday, come say hello. I’ll be manning our stand there.

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

10

Any update on the docs Sampo? We have the RC coming up on Feb 18th. At that point we will have a new 2.7.x branch (so any docs you do will need to be applied to both branches).

···

On 8 January 2015 at 07:25, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

I’ve got the go-ahead from my client for me to use the hours for the documentation. Is there a guide on how to write the docs? Or maybe just point me to a good example I could follow?

Thanks,
Sampo

Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Jody Garnett

On Mon, Dec 29, 2014 at 12:18 PM, Rahkonen Jukka (Tike) <jukka.rahkonen@anonymised.com…> wrote:

Hi Sampo,

By the release schedule it is 2015-01-18
https://github.com/geoserver/geoserver/wiki/Release-Schedule

-Jukka Rahkonen-

Sampo Savolainen wrote:

Hi,

Thanks Jody! Thanks for patching up the merge. I’ll talk to my client to arrange the documentation.

What’s the deadline for 2.7.x feature freeze?

Sampo

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

On Wed, Dec 24, 2014 at 7:05 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

Thanks Sampo, merged the work into master (just in time for christmas).

Ran into two glitches:

  • GeoServerFeatureSource was having trouble copying query hints (throwing illegal argument exception). I have patched the issue by logging these errors for now.
  • No docs (we can do that as a seperate pull request, even just to get the new screens document).

–
Jody

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

–
Jody Garnett

On 19 December 2014 at 03:25, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

I’ve now added temporary name support for my FeatureTypeCallback implementation. I think this should complete all the outstanding issues raised so far with this work.

Here’s the commit https://github.com/sampov2/geoserver/commit/7451f7949ce14f60e3e07cc341cf63a7bb986f79

Sampo

On Tue, Dec 9, 2014 at 1:32 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

I went through and had a quick review of your pull request, a lot of small comments (and a couple questions) but nothing immediately troubling.

Can we get your FeatureTypeCallback question answered? I would like to get this pull request sorted while you still have time/budget.

–
Jody

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

–
Jody Garnett

On 2 December 2014 at 06:31, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

A quick status update and a question: The GeoTools work is in a pull request that Jody has just about accepted. I’ve merged my GeoServer work with master and created a pull request for GeoServer (https://github.com/geoserver/geoserver/pull/841). Comments please!

There’s been a good improvement in GeoServer regarding these types of special layers (these types = virtual tables + cascaded stored queries) in between the time when I originally wrote this and now. You’ve introduced the FeatureTypeCallback system so these kinds of layers can include their own logic inside these modules instead of polluting ResourcePool.getFeatureSource().

However, I’m a bit confused about the “temporary name” part in this pattern. I recall there was something similar before, but I can’t remember what this was for.

Looking at the API description for the callback, this functionality seems to be optional for the callback. As it stands, my feature ignores the temporary names and thus does no cleanup either.

https://github.com/sampov2/geoserver/blob/2.7.x-feature-cascaded-stored-query/src/main/src/main/java/org/geoserver/catalog/CascadedStoredQueryCallback.java

In what cases are these temporary names required?

Sampo

btw. If any of you are in London for GeoDATA 2014 on Thursday, come say hello. I’ll be manning our stand there.

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

11

Hi Jody,

Sorry for the radio silence. I’ve got the docs halfway done: https://github.com/sampov2/geoserver/tree/cascaded-stored-query-docs

I’ll schedule some time for me next week to complete them and submit the first complete version for comments.

On a related note: while writing the docs, I noticed I failed to resolve on of your original comments regarding the implementation. The CQL expression parameters still have the unconventional + operator that does string concatenation if either side is not a number. What was the CQL function that concatenates an arbitrary number of parameters together? Or is it too late to fix this?

Sampo

···

On Thu, Feb 5, 2015 at 12:05 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

Any update on the docs Sampo? We have the RC coming up on Feb 18th. At that point we will have a new 2.7.x branch (so any docs you do will need to be applied to both branches).

Jody

–

–
Jody Garnett

On 8 January 2015 at 07:25, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

I’ve got the go-ahead from my client for me to use the hours for the documentation. Is there a guide on how to write the docs? Or maybe just point me to a good example I could follow?

Thanks,
Sampo

Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

On Mon, Dec 29, 2014 at 12:18 PM, Rahkonen Jukka (Tike) <jukka.rahkonen@anonymised.com> wrote:

Hi Sampo,

By the release schedule it is 2015-01-18
https://github.com/geoserver/geoserver/wiki/Release-Schedule

-Jukka Rahkonen-

Sampo Savolainen wrote:

Hi,

Thanks Jody! Thanks for patching up the merge. I’ll talk to my client to arrange the documentation.

What’s the deadline for 2.7.x feature freeze?

Sampo

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

On Wed, Dec 24, 2014 at 7:05 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

Thanks Sampo, merged the work into master (just in time for christmas).

Ran into two glitches:

  • GeoServerFeatureSource was having trouble copying query hints (throwing illegal argument exception). I have patched the issue by logging these errors for now.
  • No docs (we can do that as a seperate pull request, even just to get the new screens document).

–
Jody

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

–
Jody Garnett

On 19 December 2014 at 03:25, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

I’ve now added temporary name support for my FeatureTypeCallback implementation. I think this should complete all the outstanding issues raised so far with this work.

Here’s the commit https://github.com/sampov2/geoserver/commit/7451f7949ce14f60e3e07cc341cf63a7bb986f79

Sampo

On Tue, Dec 9, 2014 at 1:32 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

I went through and had a quick review of your pull request, a lot of small comments (and a couple questions) but nothing immediately troubling.

Can we get your FeatureTypeCallback question answered? I would like to get this pull request sorted while you still have time/budget.

–
Jody

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

–
Jody Garnett

On 2 December 2014 at 06:31, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

A quick status update and a question: The GeoTools work is in a pull request that Jody has just about accepted. I’ve merged my GeoServer work with master and created a pull request for GeoServer (https://github.com/geoserver/geoserver/pull/841). Comments please!

There’s been a good improvement in GeoServer regarding these types of special layers (these types = virtual tables + cascaded stored queries) in between the time when I originally wrote this and now. You’ve introduced the FeatureTypeCallback system so these kinds of layers can include their own logic inside these modules instead of polluting ResourcePool.getFeatureSource().

However, I’m a bit confused about the “temporary name” part in this pattern. I recall there was something similar before, but I can’t remember what this was for.

Looking at the API description for the callback, this functionality seems to be optional for the callback. As it stands, my feature ignores the temporary names and thus does no cleanup either.

https://github.com/sampov2/geoserver/blob/2.7.x-feature-cascaded-stored-query/src/main/src/main/java/org/geoserver/catalog/CascadedStoredQueryCallback.java

In what cases are these temporary names required?

Sampo

btw. If any of you are in London for GeoDATA 2014 on Thursday, come say hello. I’ll be manning our stand there.

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@…3889…
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

12

On Sat, Feb 7, 2015 at 6:19 PM, Sampo Savolainen <
sampo.savolainen@anonymised.com> wrote:

Hi Jody,

Sorry for the radio silence. I've got the docs halfway done:
https://github.com/sampov2/geoserver/tree/cascaded-stored-query-docs

I'll schedule some time for me next week to complete them and submit the
first complete version for comments.

On a related note: while writing the docs, I noticed I failed to resolve
on of your original comments regarding the implementation. The CQL
expression parameters still have the unconventional + operator that does
string concatenation if either side is not a number. What was the CQL
function that concatenates an arbitrary number of parameters together? Or
is it too late to fix this?

"Concatenate"
It's bever too late for small fixes :slight_smile:

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

13

Hi,

Here’s the documentation pull request: https://github.com/geoserver/geoserver/pull/922 - I’d love some feedback, I’m sure it’s still lacking in some way or another.

I’ll now work on getting some final fixes for this feature (like removing the overridden + operator)

Sampo

···

On Sat, Feb 7, 2015 at 7:31 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

–

On Sat, Feb 7, 2015 at 6:19 PM, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi Jody,

Sorry for the radio silence. I’ve got the docs halfway done: https://github.com/sampov2/geoserver/tree/cascaded-stored-query-docs

I’ll schedule some time for me next week to complete them and submit the first complete version for comments.

On a related note: while writing the docs, I noticed I failed to resolve on of your original comments regarding the implementation. The CQL expression parameters still have the unconventional + operator that does string concatenation if either side is not a number. What was the CQL function that concatenates an arbitrary number of parameters together? Or is it too late to fix this?

“Concatenate”
It’s bever too late for small fixes :slight_smile:

Cheers
Andrea

–

==

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@…3889…
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

14

Thanks Sampo, way to sneak this in just before the RC1 :slight_smile:

···

On 11 February 2015 at 02:17, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi,

Here’s the documentation pull request: https://github.com/geoserver/geoserver/pull/922 - I’d love some feedback, I’m sure it’s still lacking in some way or another.

I’ll now work on getting some final fixes for this feature (like removing the overridden + operator)

Sampo

–
Jody Garnett

On Sat, Feb 7, 2015 at 7:31 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

–

Sampo Savolainen
R&D Director, Spatineo Oy
sampo.savolainen@anonymised.com
+358-407555649
Linnankoskenkatu 16 A 17, 00250 Helsinki, Finland
www.spatineo.com, twitter.com/#!/spatineo
www.linkedin.com/company/spatineo-inc

This message may contain privileged and/or confidential information. If you
have received this e-mail in error or are not the intended recipient, you
may not use, copy, disseminate, or distribute it; do not open any
attachments, delete it immediately from your system and notify the sender
promptly by e-mail that you have done so.

On Sat, Feb 7, 2015 at 6:19 PM, Sampo Savolainen <sampo.savolainen@anonymised.com> wrote:

Hi Jody,

Sorry for the radio silence. I’ve got the docs halfway done: https://github.com/sampov2/geoserver/tree/cascaded-stored-query-docs

I’ll schedule some time for me next week to complete them and submit the first complete version for comments.

On a related note: while writing the docs, I noticed I failed to resolve on of your original comments regarding the implementation. The CQL expression parameters still have the unconventional + operator that does string concatenation if either side is not a number. What was the CQL function that concatenates an arbitrary number of parameters together? Or is it too late to fix this?

“Concatenate”
It’s bever too late for small fixes :slight_smile:

Cheers
Andrea

–

==

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.