The issue is here
https://jira.codehaus.org/browse/GEOS-5754
I fear this issue won’t be solved in the near future because it requires an Apache Wicket migration.
I am asking myself if we should present a warning on these two pages if a request is originated from Chrome.
I think searching for the String “Chrome” in the “User-Agent” HTTP request could do the job.
Opinions ?
–
DI Christian Mueller MSc (GIS), MSc (IT-Security)
OSS Open Source Solutions GmbH
On Tue, May 21, 2013 at 10:11 AM, Christian Mueller <
christian.mueller@anonymised.com> wrote:
The issue is here
https://jira.codehaus.org/browse/GEOS-5754
I fear this issue won't be solved in the near future because it requires
an Apache Wicket migration.I am asking myself if we should present a warning on these two pages if a
request is originated from Chrome.I think searching for the String "Chrome" in the "User-Agent" HTTP request
could do the job.Opinions ?
I'm wondering if we can try to upgrade to the latest 1.4.x Wicket release,
it has some Chrome specific fixes
I believe?
However I already know some tests will fail, wondering if the work done for
the 1.5.x migration can help
us there though
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
On 21/05/13 16:46, Andrea Aime wrote:
I'm wondering if we can try to upgrade to the latest 1.4.x Wicket
release, it has some Chrome specific fixes
I believe?
This one from 2009-2011 affects Chrome and IE8:
Troubles changing CRS for simple feature
https://jira.codehaus.org/browse/GEOS-3307
Kind regards,
--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre
I tried using Apache Wicket 1.4.22 instead of 1.4.12.
Unfortunately this helps nothing but causes additional exceptions. (some img files could not be found).
As far as I can remember, there were some mails describing security configuration problems and the solutions was to use Firefox.
Perhaps we can avoid this and save time with the warning messages.
Christian
2013/5/21 Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com…>
On 21/05/13 16:46, Andrea Aime wrote:
I’m wondering if we can try to upgrade to the latest 1.4.x Wicket
release, it has some Chrome specific fixes
I believe?This one from 2009-2011 affects Chrome and IE8:
Troubles changing CRS for simple feature
https://jira.codehaus.org/browse/GEOS-3307Kind regards,
–
Ben Caradoc-Davies Ben.Caradoc-Davies@anonymised.com
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre
–
DI Christian Mueller MSc (GIS), MSc (IT-Security)
OSS Open Source Solutions GmbH
On Tue, May 21, 2013 at 3:57 PM, Christian Mueller <
christian.mueller@anonymised.com> wrote:
I tried using Apache Wicket 1.4.22 instead of 1.4.12.
Unfortunately this helps nothing but causes additional exceptions. (some
img files could not be found).
That is precisely why I suggested to look into the wicket upgrade branch,
maybe there these issues have
been solved already (there is already quite a bit of work in there)
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
But 1.4.22 does not solve the problem the with save buttons (I checked it) . If it would, I would invest some time, but it does not.
Christian
2013/5/21 Andrea Aime <andrea.aime@anonymised.com1268…>
On Tue, May 21, 2013 at 3:57 PM, Christian Mueller <christian.mueller@anonymised.com> wrote:
–
DI Christian Mueller MSc (GIS), MSc (IT-Security)
OSS Open Source Solutions GmbH
I tried using Apache Wicket 1.4.22 instead of 1.4.12.
Unfortunately this helps nothing but causes additional exceptions. (some img files could not be found).
That is precisely why I suggested to look into the wicket upgrade branch, maybe there these issues have
been solved already (there is already quite a bit of work in there)
Cheers
Andrea
–
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
On Tue, May 21, 2013 at 4:08 PM, Christian Mueller <
christian.mueller@anonymised.com> wrote:
But 1.4.22 does not solve the problem the with save buttons (I checked it)
. If it would, I would invest some time, but it does not.
Ah, I see. Bummer.
Has some debugging been tried? Like, don't know, looking into not using
ajax for save buttons (if it's used),
or using a javascript debugger to see what's breaking in Chrome?
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
The save button does not use Ajax, the type of the button is “SubmitLink”. I compared the HTML output for the button in Firefox and Chrome, pretty much the same.
I am not a JS expert, opening the JS Debugger in Chrome is nice but does not help me. The simplest example is
PasswordPage.java
PasswordPage.html
I have really no idea.
2013/5/21 Andrea Aime <andrea.aime@anonymised.com>
On Tue, May 21, 2013 at 4:08 PM, Christian Mueller <christian.mueller@anonymised.com.3674…> wrote:
–
DI Christian Mueller MSc (GIS), MSc (IT-Security)
OSS Open Source Solutions GmbH
But 1.4.22 does not solve the problem the with save buttons (I checked it) . If it would, I would invest some time, but it does not.
Ah, I see. Bummer.
Has some debugging been tried? Like, don’t know, looking into not using ajax for save buttons (if it’s used),
or using a javascript debugger to see what’s breaking in Chrome?
Cheers
Andrea
–
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
On Tue, May 21, 2013 at 5:34 PM, Christian Mueller <
christian.mueller@anonymised.com> wrote:
The save button does not use Ajax, the type of the button is "SubmitLink".
I compared the HTML output for the button in Firefox and Chrome, pretty
much the same.I am not a JS expert, opening the JS Debugger in Chrome is nice but does
not help me. The simplest example isPasswordPage.java
PasswordPage.htmlI have really no idea.
I found out what the cause is: it's the patch for GEOS-5172.
http://jira.codehaus.org/browse/GEOS-5172
The patch is designed to make table filtering work in modal windows, but
affects also normal pages
that have nested forms, and results in the problem you're seeing with
Chrome.
Long story short, in Chrome the submit for the hidden table filter submits
gets invoked instead of the
main submit, whilst the issue is not present in Firefox because the patch
above explicitly applies
the submit behavior in Safari/Chrome and IE browsers only.
Going to have a look and see if we can solve this without breaking modal
windows in the process.
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
On Sat, May 25, 2013 at 3:46 PM, Andrea Aime
<andrea.aime@anonymised.com>wrote:
I found out what the cause is: it's the patch for GEOS-5172.
http://jira.codehaus.org/browse/GEOS-5172The patch is designed to make table filtering work in modal windows, but
affects also normal pages
that have nested forms, and results in the problem you're seeing with
Chrome.
Long story short, in Chrome the submit for the hidden table filter submits
gets invoked instead of the
main submit, whilst the issue is not present in Firefox because the patch
above explicitly applies
the submit behavior in Safari/Chrome and IE browsers only.
Going to have a look and see if we can solve this without breaking modal
windows in the process.
Ok, I've just committed a patch on trunk that should fix the issue with
Chrome without causing
regressions on the filtered tables in modal windows.
I've tested it on main pages, works, modal windows, works, however after
committing it I noticed
that when multiple filterable tables are in the same page (Authentication
page), they still don't work
in Chrome, but do on Windows.
Overall seems a step in the right direction, at least the main submit
button works now...
Going to look into this a bit more
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
On Sat, May 25, 2013 at 6:28 PM, Andrea Aime
<andrea.aime@anonymised.com>wrote:
I've tested it on main pages, works, modal windows, works, however after
committing it I noticed
that when multiple filterable tables are in the same page (Authentication
page), they still don't work
in Chrome, but do on Windows.
err... but they do on Firefox... sigh... need some rest...
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
On Sat, May 25, 2013 at 6:28 PM, Andrea Aime
<andrea.aime@anonymised.com>wrote:
Overall seems a step in the right direction, at least the main submit
button works now...
Going to look into this a bit more
All right, committed what seems a better patch. Tested it on Chrome and
Firefox on Linux,
IE 8 on Windows, seems to be working properly in full pages with one or
more filterable
tables, and in dialog windows as well.
Can someone double check before we port back to 2.3.x?
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
Just tried on chrome, safari, and firefox. All working. Nice work on this fix.
On Sat, May 25, 2013 at 10:48 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:
On Sat, May 25, 2013 at 6:28 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:
–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
Overall seems a step in the right direction, at least the main submit button works now…
All right, committed what seems a better patch. Tested it on Chrome and Firefox on Linux,
IE 8 on Windows, seems to be working properly in full pages with one or more filterable
tables, and in dialog windows as well.
Can someone double check before we port back to 2.3.x?
Cheers
Andrea
–
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
Going to look into this a bit more
On Mon, May 27, 2013 at 10:04 PM, Justin Deoliveira <jdeolive@anonymised.com>wrote:
Just tried on chrome, safari, and firefox. All working. Nice work on this
fix.
Thanks, just backported it to 2.3.x
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------