On Thu, May 1, 2014 at 10:15 AM, Andrea Aime
<andrea.aime@anonymised.com>wrote:
And... I get a full pass, 568 tests passing, including those that fail on
the build server for the past weeks (
http://ares.boundlessgeo.com/jenkins/view/geoserver-cite/job/cite-wfs-1.1/
)
I'll have a look and see if I can stand up postgis 1.x anywhere, maybe
it's related to the
postgis/postgresql version... although... it seems unlikely, one test is
doing a simple equality check
against a string attribute, the other two should be failing because of a
validation error in the
query and instead they are returning a FeatureCollection... it's as if the
strict compliance checks
are not enabled anymore?
Hi,
so I've downloaded the nightly build and run that one instead, and while I
cannot reproduce the GetFeature-tc5.3
failure, the other two are there.
I've attached a debugger, stepped though the code, the parser is put in
validating mode, yet it's not complaining
about the wfs:Smuery element.
Made some further investigation, one first thing that is striking me is
that the WFS xml parsing sets
the parser in validating mode, but not in strict mode, when the cite
compliance hack is enabled.
The WCS/CSW xml parsers are instead put in strict mode too when the the
compliance hacks are enabled.
I've then compared to what happens when running GeoServer from Eclipse, and
found the difference
is that the SAX parser emits an error caught by
ParserHandler.error(SAXParseException) when working
in Eclipse, but not when running the stand alone binary package.
Checking what SAX parser gets instantiated I've found:
* Running from
Eclipse: com.sun.org.apache.xerces.internal.jaxp.SAXParserFactoryImpl@anonymised.com(JDK
own parser)
* Running from bin package
(Jetty): org.apache.xerces.jaxp.SAXParserFactoryImpl@anonymised.com (Eeek...
Xerces stand alone!)
Looking in the bin package:
find . -name "*xerces*"
./lib/xercesImpl-2.7.1.jar <--- It's in Jetty!!
Now, in recent version of Java this might not be required anymore right? So
I've moved it out and restarted
the package, it started fine, rerun the cite tests and (drumroll)... full
pass!
There are still two bits outstanding:
* no idea why this started happening only some time ago (java version
changes in the server maybe?)
* the GetFeature-tc5.3 failiure is still non reproducable for me
About the xerces dependency... shall we try removing it from the bin
package? I believe it was there
for Jetty, but if GeoServer starts, I guess the Jetty code was already
using JAXP to find the xml
parsers and it's probably picking up the JDK ones now.
Cheers
Andrea
--
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------