[Geoserver-devel] CITE WFS 1.1 failures

GeoServer GeoServer Developer
1

Torben,

CITE WFS 1.1 tests have been failing on all branches for about 7 days. Looking at master, the failures started with this geoserver-master-nightly build (CITE tests run from nightly builds):
http://ares.boundlessgeo.com/jenkins/view/geoserver/job/geoserver-master-nightly/1410/changes

The only relevant change seems to be:

[GEOS-8117] Improve support for null service/version/request in KvpUtils
https://github.com/geoserver/geoserver/pull/2289
https://osgeo-org.atlassian.net/browse/GEOS-8117

CITE tests are old and seem to expect //wfs:WFS_Capabilities/@version='1.1.0' if version is not specified because that was the highest version when the CITE tests were published. From:
http://ares.boundlessgeo.com/jenkins/view/testing-cite/job/cite-wfs-1.1/1317/consoleText

First failure:

      [exec] Testing wfs:wfs-1.1.0-Basic-GetCapabilities-tc13.3 (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e894_1)...
      [exec] Assertion: A KVP-encoded GetCapabilities request shall include the following query parameters: service=WxS request=GetCapabilities, where WxS is a mnemonic label for a service type. See Table 2 for definitions of optional query parameters.
      [exec] Testing ctl:assert-xpath (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e894_1/d41e2445_1)...
      [exec] Assertion:
      [exec] Evaluates the given XPath expression against the input document and
      [exec] returns a boolean result according to the XPath specification (see
      [exec] http://www.w3.org/TR/xpath#section-Boolean-Functions).
      [exec]
      [exec] The expression '//wfs:WFS_Capabilities/@version='1.1.0'' is false.
      [exec] Test ctl:assert-xpath Failed
      [exec] Test wfs:wfs-1.1.0-Basic-GetCapabilities-tc13.3 Failed (Inherited failure)

Second failure:

      [exec] Testing wfs:wfs-1.1.0-Basic-GetCapabilities-tc14.1 (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e899_1)...
      [exec] Assertion: If AcceptVersion is not specified, the service must respond with highest supported version.
      [exec] Testing ctl:assert-xpath (wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e899_1/d41e2519_1)...
      [exec] Assertion:
      [exec] Evaluates the given XPath expression against the input document and
      [exec] returns a boolean result according to the XPath specification (see
      [exec] http://www.w3.org/TR/xpath#section-Boolean-Functions).
      [exec]
      [exec] The expression '//wfs:WFS_Capabilities/@version='1.1.0'' is false.
      [exec] Test ctl:assert-xpath Failed
      [exec] Test wfs:wfs-1.1.0-Basic-GetCapabilities-tc14.1 Failed (Inherited failure)

Kind regards,

--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/&gt;
New Zealand

2

Torben,

you can use ServiceInfo.isCiteCompliant() to detect whether a service is in CITE compliance mode.

Kind regards,
Ben.

On 10/05/17 15:53, Ben Caradoc-Davies wrote:

Torben,

CITE WFS 1.1 tests have been failing on all branches for about 7 days.
Looking at master, the failures started with this
geoserver-master-nightly build (CITE tests run from nightly builds):
http://ares.boundlessgeo.com/jenkins/view/geoserver/job/geoserver-master-nightly/1410/changes

The only relevant change seems to be:

[GEOS-8117] Improve support for null service/version/request in KvpUtils
https://github.com/geoserver/geoserver/pull/2289
https://osgeo-org.atlassian.net/browse/GEOS-8117

CITE tests are old and seem to expect
//wfs:WFS_Capabilities/@version='1.1.0' if version is not specified
because that was the highest version when the CITE tests were published.
From:
http://ares.boundlessgeo.com/jenkins/view/testing-cite/job/cite-wfs-1.1/1317/consoleText

First failure:

      [exec] Testing
wfs:wfs-1.1.0-Basic-GetCapabilities-tc13.3
(wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e894_1)...
      [exec] Assertion: A KVP-encoded GetCapabilities
request shall include the following query parameters: service=WxS
request=GetCapabilities, where WxS is a mnemonic label for a service
type. See Table 2 for definitions of optional query parameters.
      [exec] Testing ctl:assert-xpath
(wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e894_1/d41e2445_1)...
      [exec] Assertion:
      [exec] Evaluates the given XPath expression against the
input document and
      [exec] returns a boolean result according to the XPath
specification (see
      [exec] http://www.w3.org/TR/xpath#section-Boolean-Functions).
      [exec]
      [exec] The expression
'//wfs:WFS_Capabilities/@version='1.1.0'' is false.
      [exec] Test ctl:assert-xpath Failed
      [exec] Test
wfs:wfs-1.1.0-Basic-GetCapabilities-tc13.3 Failed (Inherited failure)

Second failure:

      [exec] Testing
wfs:wfs-1.1.0-Basic-GetCapabilities-tc14.1
(wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e899_1)...
      [exec] Assertion: If AcceptVersion is not
specified, the service must respond with highest supported version.
      [exec] Testing ctl:assert-xpath
(wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e899_1/d41e2519_1)...
      [exec] Assertion:
      [exec] Evaluates the given XPath expression against the
input document and
      [exec] returns a boolean result according to the XPath
specification (see
      [exec] http://www.w3.org/TR/xpath#section-Boolean-Functions).
      [exec]
      [exec] The expression
'//wfs:WFS_Capabilities/@version='1.1.0'' is false.
      [exec] Test ctl:assert-xpath Failed
      [exec] Test
wfs:wfs-1.1.0-Basic-GetCapabilities-tc14.1 Failed (Inherited failure)

Kind regards,

--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/&gt;
New Zealand

3

Thanks Ben, I’ll look into it. I remember taking a look at the failures around when I made that change and couldn’t see anything problematic (it looked like just a curl failure near the end), but evidently that was just because I am not familiar in how the cite tests show errors.

Torben

···

On Tue, May 9, 2017 at 9:07 PM, Ben Caradoc-Davies <ben@anonymised.com> wrote:

Torben,

you can use ServiceInfo.isCiteCompliant() to detect whether a service is in CITE compliance mode.

Kind regards,
Ben.

On 10/05/17 15:53, Ben Caradoc-Davies wrote:

Torben,

CITE WFS 1.1 tests have been failing on all branches for about 7 days.
Looking at master, the failures started with this
geoserver-master-nightly build (CITE tests run from nightly builds):
http://ares.boundlessgeo.com/jenkins/view/geoserver/job/geoserver-master-nightly/1410/changes

The only relevant change seems to be:

[GEOS-8117] Improve support for null service/version/request in KvpUtils
https://github.com/geoserver/geoserver/pull/2289
https://osgeo-org.atlassian.net/browse/GEOS-8117

CITE tests are old and seem to expect
//wfs:WFS_Capabilities/@version=‘1.1.0’ if version is not specified
because that was the highest version when the CITE tests were published.
From:
http://ares.boundlessgeo.com/jenkins/view/testing-cite/job/cite-wfs-1.1/1317/consoleText

First failure:

[exec] Testing
wfs:wfs-1.1.0-Basic-GetCapabilities-tc13.3
(wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e894_1)…
[exec] Assertion: A KVP-encoded GetCapabilities
request shall include the following query parameters: service=WxS
request=GetCapabilities, where WxS is a mnemonic label for a service
type. See Table 2 for definitions of optional query parameters.
[exec] Testing ctl:assert-xpath
(wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e894_1/d41e2445_1)…
[exec] Assertion:
[exec] Evaluates the given XPath expression against the
input document and
[exec] returns a boolean result according to the XPath
specification (see
[exec] http://www.w3.org/TR/xpath#section-Boolean-Functions).
[exec]
[exec] The expression
‘//wfs:WFS_Capabilities/@version=‘1.1.0’’ is false.
[exec] Test ctl:assert-xpath Failed
[exec] Test
wfs:wfs-1.1.0-Basic-GetCapabilities-tc13.3 Failed (Inherited failure)

Second failure:

[exec] Testing
wfs:wfs-1.1.0-Basic-GetCapabilities-tc14.1
(wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e899_1)…
[exec] Assertion: If AcceptVersion is not
specified, the service must respond with highest supported version.
[exec] Testing ctl:assert-xpath
(wfs-1.1.0/d41e34700_1/d41e749_1/d41e24740_1/d41e899_1/d41e2519_1)…
[exec] Assertion:
[exec] Evaluates the given XPath expression against the
input document and
[exec] returns a boolean result according to the XPath
specification (see
[exec] http://www.w3.org/TR/xpath#section-Boolean-Functions).
[exec]
[exec] The expression
‘//wfs:WFS_Capabilities/@version=‘1.1.0’’ is false.
[exec] Test ctl:assert-xpath Failed
[exec] Test
wfs:wfs-1.1.0-Basic-GetCapabilities-tc14.1 Failed (Inherited failure)

Kind regards,

–
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand

4

On Wed, May 10, 2017 at 6:13 PM, Torben Barsballe <
tbarsballe@anonymised.com> wrote:

Thanks Ben, I'll look into it. I remember taking a look at the failures
around when I made that change and couldn't see anything problematic (it
looked like just a curl failure near the end), but evidently that was just
because I am not familiar in how the cite tests show errors.

Because they don't... if you run them from command line you have to run a
separate tool
to get the report (I don't remember exactly how it works, never liked using
it that way).
When running them as a web application instead, you can follow a link to go
to that
specific error page, get a report, and run that one test again

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

5

Update:

I’m working on a fix here: https://github.com/geoserver/geoserver/pull/2328
It seems to fix the issue in question, but still fails CITE tests. I am looking into a better solution.

I’ve also set up a temporary Jenkins job for running WFS cite tests against an arbitrary branch here: http://ares.boundlessgeo.com/jenkins/job/cite-wfs-1.1-troubleshooting

As an aside, this job seems like it is something that could be useful on a more permanent basis.

Torben

···

On Wed, May 10, 2017 at 9:19 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Wed, May 10, 2017 at 6:13 PM, Torben Barsballe <tbarsballe@anonymised.com> wrote:

Thanks Ben, I’ll look into it. I remember taking a look at the failures around when I made that change and couldn’t see anything problematic (it looked like just a curl failure near the end), but evidently that was just because I am not familiar in how the cite tests show errors.

Because they don’t… if you run them from command line you have to run a separate tool
to get the report (I don’t remember exactly how it works, never liked using it that way).
When running them as a web application instead, you can follow a link to go to that
specific error page, get a report, and run that one test again

Cheers
Andrea

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

6

Given that the 2.11.1 release is coming up soon, and I doubt I will be able to fix this cite failure before then, what is the lesser of two evils here:

  1. Let the CITE tests fail, given that the result is technically correct (2.0.0 is the most recent version, the CITE tests are just old)
  2. Revert the GEOS-8117 fix on 2.11.x and 2.10.x until I can get the CITE tests passing

Torben

···

On Wed, May 10, 2017 at 1:14 PM, Torben Barsballe <tbarsballe@anonymised.com> wrote:

Update:

I’m working on a fix here: https://github.com/geoserver/geoserver/pull/2328
It seems to fix the issue in question, but still fails CITE tests. I am looking into a better solution.

I’ve also set up a temporary Jenkins job for running WFS cite tests against an arbitrary branch here: http://ares.boundlessgeo.com/jenkins/job/cite-wfs-1.1-troubleshooting

As an aside, this job seems like it is something that could be useful on a more permanent basis.

Torben

On Wed, May 10, 2017 at 9:19 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Wed, May 10, 2017 at 6:13 PM, Torben Barsballe <tbarsballe@anonymised.com> wrote:

Thanks Ben, I’ll look into it. I remember taking a look at the failures around when I made that change and couldn’t see anything problematic (it looked like just a curl failure near the end), but evidently that was just because I am not familiar in how the cite tests show errors.

Because they don’t… if you run them from command line you have to run a separate tool
to get the report (I don’t remember exactly how it works, never liked using it that way).
When running them as a web application instead, you can follow a link to go to that
specific error page, get a report, and run that one test again

Cheers
Andrea

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

7

How about:

3. Update the failing CITE tests to reflect the existence of WFS 2.0.0.

Kind regards,
Ben.

On 13/05/17 11:03, Torben Barsballe wrote:

Given that the 2.11.1 release is coming up soon, and I doubt I will be able
to fix this cite failure before then, what is the lesser of two evils here:

1. Let the CITE tests fail, given that the result is technically correct
(2.0.0 is the most recent version, the CITE tests are just old)
2. Revert the GEOS-8117 <https://osgeo-org.atlassian.net/browse/GEOS-8117&gt; fix
on 2.11.x and 2.10.x until I can get the CITE tests passing

Torben

On Wed, May 10, 2017 at 1:14 PM, Torben Barsballe <
tbarsballe@anonymised.com> wrote:

Update:

I'm working on a fix here: https://github.com/
geoserver/geoserver/pull/2328
It seems to fix the issue in question, but still fails CITE tests. I am
looking into a better solution.

I've also set up a temporary Jenkins job for running WFS cite tests
against an arbitrary branch here: http://ares.
boundlessgeo.com/jenkins/job/cite-wfs-1.1-troubleshooting

As an aside, this job seems like it is something that could be useful on a
more permanent basis.

Torben

On Wed, May 10, 2017 at 9:19 AM, Andrea Aime <andrea.aime@anonymised.com

wrote:

On Wed, May 10, 2017 at 6:13 PM, Torben Barsballe <
tbarsballe@anonymised.com> wrote:

Thanks Ben, I'll look into it. I remember taking a look at the failures
around when I made that change and couldn't see anything problematic (it
looked like just a curl failure near the end), but evidently that was just
because I am not familiar in how the cite tests show errors.

Because they don't... if you run them from command line you have to run a
separate tool
to get the report (I don't remember exactly how it works, never liked
using it that way).
When running them as a web application instead, you can follow a link to
go to that
specific error page, get a report, and run that one test again

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313 <+39%200584%20962313>
fax: +39 0584 1660272 <+39%200584%20166%200272>
mob: +39 339 8844549 <+39%20339%20884%204549>

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely
for the attention and use of the named addressee(s) and may be confidential
or proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/&gt;
New Zealand

8

On Fri, May 12, 2017 at 4:08 PM, Ben Caradoc-Davies <ben@anonymised.com>
wrote:

How about:

3. Update the failing CITE tests to reflect the existence of WFS 2.0.0.

That would certainly be the better option. However, the CITE tests their
own project / repo, and I am not especially familiar with it.
Plus, I'm not sure how easy it is to update the version of the CITE engine
we have running on ares. Has anyone done this recently?

Torben

9

On 13/05/17 11:13, Torben Barsballe wrote:

On Fri, May 12, 2017 at 4:08 PM, Ben Caradoc-Davies <ben@anonymised.com>
wrote:

How about:
3. Update the failing CITE tests to reflect the existence of WFS 2.0.0.

That would certainly be the better option. However, the CITE tests their
own project / repo, and I am not especially familiar with it.
Plus, I'm not sure how easy it is to update the version of the CITE engine
we have running on ares. Has anyone done this recently?

The CITE tools are in their own repo:
https://github.com/geoserver/geoserver-cite-tools

The tests are in a submodule that points to Justin's repo:
https://github.com/jdeolive/cite-scripts/tree/9937bd36c2377f7692ab7856307f78a067de8112

History indicates that Justin has previously had to fix a few problems in the tests.

Should we fork this back into a new repo in the GeoServer organisation to make it easier for us to maintain?

Kind regards,

--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/&gt;
New Zealand

10

Huh, interesting.

Looks like at least one of the submodule links in Justin’s repo are broken (goes to a 404), so migration may be interesting.

I found the official cite test repo, and it look like this failure may have been fixed 1.5 years ago: https://github.com/opengeospatial/ets-wfs11/commit/bf25d9c689997f851692f973006bcbd3eae54a18

···

On Fri, May 12, 2017 at 4:19 PM, Ben Caradoc-Davies <ben@anonymised.com> wrote:

On 13/05/17 11:13, Torben Barsballe wrote:

On Fri, May 12, 2017 at 4:08 PM, Ben Caradoc-Davies <ben@anonymised.com>
wrote:

How about:
3. Update the failing CITE tests to reflect the existence of WFS 2.0.0.

That would certainly be the better option. However, the CITE tests their
own project / repo, and I am not especially familiar with it.
Plus, I’m not sure how easy it is to update the version of the CITE engine
we have running on ares. Has anyone done this recently?

The CITE tools are in their own repo:
https://github.com/geoserver/geoserver-cite-tools

The tests are in a submodule that points to Justin’s repo:
https://github.com/jdeolive/cite-scripts/tree/9937bd36c2377f7692ab7856307f78a067de8112

History indicates that Justin has previously had to fix a few problems in the tests.

Should we fork this back into a new repo in the GeoServer organisation to make it easier for us to maintain?

Kind regards,

–
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand

11

I’d play it safe and revert, knowing there is a failure will make us ignore the results and other failures may slip in.

Also, the build server is public, having a failure (even a legit one) and releasing anyways is bad rep imho

Cheers
Andrea

Cheers
Andrea

···

Il 13 mag 2017 1:08 AM, “Torben Barsballe” <tbarsballe@anonymised.com> ha scritto:

Given that the 2.11.1 release is coming up soon, and I doubt I will be able to fix this cite failure before then, what is the lesser of two evils here:

  1. Let the CITE tests fail, given that the result is technically correct (2.0.0 is the most recent version, the CITE tests are just old)
  2. Revert the GEOS-8117 fix on 2.11.x and 2.10.x until I can get the CITE tests passing

Torben

Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Geoserver-devel mailing list
Geoserver-devel@anonymised.com.366…sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

On Wed, May 10, 2017 at 1:14 PM, Torben Barsballe <tbarsballe@anonymised.com> wrote:

Update:

I’m working on a fix here: https://github.com/geoserver/geoserver/pull/2328
It seems to fix the issue in question, but still fails CITE tests. I am looking into a better solution.

I’ve also set up a temporary Jenkins job for running WFS cite tests against an arbitrary branch here: http://ares.boundlessgeo.com/jenkins/job/cite-wfs-1.1-troubleshooting

As an aside, this job seems like it is something that could be useful on a more permanent basis.

Torben

On Wed, May 10, 2017 at 9:19 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Wed, May 10, 2017 at 6:13 PM, Torben Barsballe <tbarsballe@anonymised.com> wrote:

Thanks Ben, I’ll look into it. I remember taking a look at the failures around when I made that change and couldn’t see anything problematic (it looked like just a curl failure near the end), but evidently that was just because I am not familiar in how the cite tests show errors.

Because they don’t… if you run them from command line you have to run a separate tool
to get the report (I don’t remember exactly how it works, never liked using it that way).
When running them as a web application instead, you can follow a link to go to that
specific error page, get a report, and run that one test again

Cheers
Andrea

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

12

+1 for option (2), reverting the GEOS-8117 fix. I would also revert the GEOS-8117 fix on master because the failure it causes masks any new CITE WFS 1.1 failures.

No good deed goes unpunished.

Kind regards,
Ben.

On 13/05/17 19:55, Andrea Aime wrote:

I'd play it safe and revert, knowing there is a failure will make us ignore
the results and other failures may slip in.

Also, the build server is public, having a failure (even a legit one) and
releasing anyways is bad rep imho

Cheers
Andrea

Cheers
Andrea

Il 13 mag 2017 1:08 AM, "Torben Barsballe" <tbarsballe@anonymised.com> ha
scritto:

Given that the 2.11.1 release is coming up soon, and I doubt I will be able
to fix this cite failure before then, what is the lesser of two evils here:

1. Let the CITE tests fail, given that the result is technically correct
(2.0.0 is the most recent version, the CITE tests are just old)
2. Revert the GEOS-8117 <https://osgeo-org.atlassian.net/browse/GEOS-8117&gt; fix
on 2.11.x and 2.10.x until I can get the CITE tests passing

Torben

On Wed, May 10, 2017 at 1:14 PM, Torben Barsballe <
tbarsballe@anonymised.com> wrote:

Update:

I'm working on a fix here: https://github.com/geose
rver/geoserver/pull/2328
It seems to fix the issue in question, but still fails CITE tests. I am
looking into a better solution.

I've also set up a temporary Jenkins job for running WFS cite tests
against an arbitrary branch here: http://ares.boundlessgeo
.com/jenkins/job/cite-wfs-1.1-troubleshooting

As an aside, this job seems like it is something that could be useful on a
more permanent basis.

Torben

On Wed, May 10, 2017 at 9:19 AM, Andrea Aime <andrea.aime@anonymised.com

wrote:

On Wed, May 10, 2017 at 6:13 PM, Torben Barsballe <
tbarsballe@anonymised.com> wrote:

Thanks Ben, I'll look into it. I remember taking a look at the failures
around when I made that change and couldn't see anything problematic (it
looked like just a curl failure near the end), but evidently that was just
because I am not familiar in how the cite tests show errors.

Because they don't... if you run them from command line you have to run a
separate tool
to get the report (I don't remember exactly how it works, never liked
using it that way).
When running them as a web application instead, you can follow a link to
go to that
specific error page, get a report, and run that one test again

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313 <+39%200584%20962313>
fax: +39 0584 1660272 <+39%200584%20166%200272>
mob: +39 339 8844549 <+39%20339%20884%204549>

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely
for the attention and use of the named addressee(s) and may be confidential
or proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/&gt;
New Zealand

13

Commits were reverted yesterday. Full cycle of nightly builds and CITE tests have finally completed, and all CITE tests are passing.

Torben

···

On Sat, May 13, 2017 at 4:42 PM, Ben Caradoc-Davies <ben@…4191…> wrote:

+1 for option (2), reverting the GEOS-8117 fix. I would also revert the GEOS-8117 fix on master because the failure it causes masks any new CITE WFS 1.1 failures.

No good deed goes unpunished.

Kind regards,
Ben.

On 13/05/17 19:55, Andrea Aime wrote:

I’d play it safe and revert, knowing there is a failure will make us ignore
the results and other failures may slip in.

Also, the build server is public, having a failure (even a legit one) and
releasing anyways is bad rep imho

Cheers
Andrea

Cheers
Andrea

Il 13 mag 2017 1:08 AM, “Torben Barsballe” <tbarsballe@anonymised.com> ha
scritto:

Given that the 2.11.1 release is coming up soon, and I doubt I will be able
to fix this cite failure before then, what is the lesser of two evils here:

  1. Let the CITE tests fail, given that the result is technically correct
    (2.0.0 is the most recent version, the CITE tests are just old)
  2. Revert the GEOS-8117 <https://osgeo-org.atlassian.net/browse/GEOS-8117> fix

on 2.11.x and 2.10.x until I can get the CITE tests passing

Torben

On Wed, May 10, 2017 at 1:14 PM, Torben Barsballe <
tbarsballe@anonymised.com39…> wrote:

Update:

I’m working on a fix here: https://github.com/geose
rver/geoserver/pull/2328
It seems to fix the issue in question, but still fails CITE tests. I am
looking into a better solution.

I’ve also set up a temporary Jenkins job for running WFS cite tests
against an arbitrary branch here: http://ares.boundlessgeo
.com/jenkins/job/cite-wfs-1.1-troubleshooting

As an aside, this job seems like it is something that could be useful on a
more permanent basis.

Torben

On Wed, May 10, 2017 at 9:19 AM, Andrea Aime <andrea.aime@anonymised.com

wrote:

On Wed, May 10, 2017 at 6:13 PM, Torben Barsballe <
tbarsballe@anonymised.com39…> wrote:

Thanks Ben, I’ll look into it. I remember taking a look at the failures
around when I made that change and couldn’t see anything problematic (it
looked like just a curl failure near the end), but evidently that was just
because I am not familiar in how the cite tests show errors.

Because they don’t… if you run them from command line you have to run a
separate tool
to get the report (I don’t remember exactly how it works, never liked
using it that way).
When running them as a web application instead, you can follow a link to
go to that
specific error page, get a report, and run that one test again

Cheers
Andrea

–

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)

phone: +39 0584 962313 <+39%200584%20962313>
fax: +39 0584 1660272 <+39%200584%20166%200272>
mob: +39 339 8844549 <+39%20339%20884%204549>

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely
for the attention and use of the named addressee(s) and may be confidential
or proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand