Alright everyone, I have now commented over 3kloc of OTHER peoples code. This has never been accepted, nor will it anytime in the future.
Gabriel, the world of commenting started before I was born, so hopefully you have heard of it.
David
David Zwiers wrote:
Alright everyone, I have now commented over 3kloc of OTHER peoples code. This has never been accepted, nor will it anytime in the future.
I have never seen that patch... care to post it?
I always liked well commented code 
Andrea
Andrea Aime wrote:
David Zwiers wrote:
Alright everyone, I have now commented over 3kloc of OTHER peoples code. This has never been accepted, nor will it nytime in the future.
I have never seen that patch... care to post it?
I always liked well commented code
The comments (&code) is on the config branch. I am afraid I am working David & Richard pretty hard 
We will be merging back onto the HEAD over the next little while.
Gabriel please accept my apologies for any frayed nerves on our end.
If I could ask you to check over our comments once they are back on the Head it would be deeply appreciated. As you can imagine some guess work has been going on and a Sanity check would be good.
I am really starting to like the GeoServer design. Maybe I should say I finally understand it and it is quite nicely laid out.
My Congrats to all those who put this together.
I was very impressed with the FeatureSource wrapper - a sweet bit of design. Could we add our code that enforces attribute ordering to this class? The class has been renamed to GeoServerFeatureSource/Store/Locking so that Transaction can use instance of to determine capabilities. GeoServerFeatureSource.create is the factory method that does the magic.
I suppose I should add this idea to the Jira task (sigh).
Jody