[Geoserver-devel] [continuum] BUILD FAILURE: GeoServer

http://traffic.openplans.org:8080/continuum/buildResult.action?buildId=109&projectId=7

Continuum ha scritto:

http://traffic.openplans.org:8080/continuum/buildResult.action?buildId=109&projectId=7

This one I cannot reproduce on my box... is there anyone that can?
Cheers
Andrea

yes i can.

Andrea Aime wrote:

Continuum ha scritto:

http://traffic.openplans.org:8080/continuum/buildResult.action?buildId=109&projectId=7

This one I cannot reproduce on my box... is there anyone that can?
Cheers
Andrea

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

!DSPAM:4007,471ccddd96433327367457!

--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org

If I add a dependency on gt2-wfs with a "test" scope it works ok. There
must be some online tests or something that use gt wfs client?

Andrea Aime wrote:

Continuum ha scritto:

http://traffic.openplans.org:8080/continuum/buildResult.action?buildId=109&projectId=7

This one I cannot reproduce on my box... is there anyone that can?
Cheers
Andrea

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

!DSPAM:4007,471ccddd96433327367457!

--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org

Justin Deoliveira ha scritto:

yes i can.

Andrea Aime wrote:

Continuum ha scritto:

http://traffic.openplans.org:8080/continuum/buildResult.action?buildId=109&projectId=7

This one I cannot reproduce on my box... is there anyone that can?

Yes and no. I had the problem of centralizing some bits of code to test
if sigma was up an running in order to run the tests regarging REMOTE_OWS_URL/TYPE (component wms).

Now, I need that code in both the GetMapKvpReaderTest, KMLTest and GetMapTest. The only common superclass of those is GeoServerTestSupport,
so I reluctantly pushed that code there and added a test dependency
onto wfs datastore in main.

I still fail to see why the problem triggers in WFS, since I can see
no code that may trigger the _usage_ of the WFSDataStore (you have
to call GeoServerTestSupport.isRemoteStatesAvailable() in order
to really need the wfs datastore).
Apparently maven is doing some strange reflection stuff that trigger
the need for it.

Solutions I can see:
* merge KvpRequestReaderTestSupport back into GeoServerTestSupport, this
   would allow me to have all tests in wms module extend WMSTestSupport
   and thus move the REMOTE_OWS_stuff related code there.
   Alternatively, move the only method in KvpRequestReaderTestSupport in
   an utility class.
* add a dependency to the wfs module... not too nice thought, the
   same would have to be done for all other modules depending on
   GeoServerTestSupport...
* find out why accessing the list of declared method requires the
   wfs datastore around...

Ideas?

Cheers
Andrea

Andrea Aime ha scritto:

Justin Deoliveira ha scritto:

Solutions I can see:

Oh, I could also roll out a utility class that does the check
with a static method. That is probably the less invasive solution.
I'm going to adopt this one if nobody tells me not to in the
next 30 minutes (my work day is about to end, I cannot leave
the build broken)
Cheers
Andrea

Yeah... I like this approach a bit better. +1

Andrea Aime wrote:

Andrea Aime ha scritto:

Justin Deoliveira ha scritto:

Solutions I can see:

Oh, I could also roll out a utility class that does the check
with a static method. That is probably the less invasive solution.
I'm going to adopt this one if nobody tells me not to in the
next 30 minutes (my work day is about to end, I cannot leave
the build broken)
Cheers
Andrea

!DSPAM:4007,471cda85135554901796417!

--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org