[Geoserver-devel] Control Flow blacklist/whitelist Error Message

When GeoServer is initializing the Control Flow extension, it will log an
error message if the "ip.blacklist" and/or "ip.whitelist" properties are
used in controlflow.properties. For example,
ERROR [org.geoserver.flow.config] Rules should be assigned just a queue
size, instead ip.blacklist is associated to 127.0.0.1

The error message(s) are harmless since those properties are used by a
different class than the one logging the errors and there does not appear to
be any loss of functionality. The error messages were cause by this commit:

where it changed from:
if(!"ip.blacklist".equals(key) && !"ip.whitelist".equals(key)){
    ...do stuff
}else{
    continue;
}

to:
if("ip.blacklist".equals(key) && "ip.whitelist".equals(key)) {
    continue;
} else {
    ...do stuff
}

but it should be using or instead of and:
if("ip.blacklist".equals(key) || "ip.whitelist".equals(key)) {
    continue;

Steve Ikeoka

--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Control-Flow-blacklist-whitelist-Error-Message-tp5323421.html
Sent from the GeoServer - Dev mailing list archive at Nabble.com.