+1
-Jukka Rahkonen-
Ben Caradoc-Davies [mailto:ben@…4191…]
Lähetetty: 14. syyskuuta 2016 6:40
Vastaanottaja: Andrea Aime <andrea.aime@...1268...>
Kopio: Geoserver-devel <geoserver-devel@lists.sourceforge.net>
Aihe: Re: [Geoserver-devel] Convert raster GetFeatureInfo band names into NCNames?
If there is no objection, I would like to backport this to 2.9.x for inclusion in 2.9.2.
Kind regards,
Ben.
On 09/09/16 10:08, Ben Caradoc-Davies wrote:
Thanks, Andrea, merged on master.
Although this pull request restricts the output property names for
non-GML info_formats, by doing so it makes output for all info_formats
consistent.The next question is: should this be backported to 2.9.x? It is a
behavioural change, but also a bug fix.Kind regards,
Ben.On 08/09/16 20:30, Andrea Aime wrote:
Hi,
as a follow-up, if no one has anything more to pitch in, I'd say Ben
go ahead with your change, if nobody else cares one way or the other
it's probably a good indication that there is no need to rework your
current pull requestCheers
AndreaOn Wed, Sep 7, 2016 at 12:07 PM, Andrea Aime
<andrea.aime@...1268...>
wrote:On Mon, Sep 5, 2016 at 11:14 PM, Ben Caradoc-Davies
<ben@...4191...>
wrote:Raster band names containing spaces cause malformed XML
GetFeatureInfo
responses:
https://osgeo-org.atlassian.net/browse/GEOS-7717
https://github.com/geoserver/geoserver/pull/1799The above pull request converts band names to NCNames by replacing
illegal characters like spaces and leading digits with underscore ("_").This proposed change will also affect plain text, HTML, and JSON
GetFeatureInfo responses. I like this because it is consistent, but
it is a behavioural change and some users might not want it.As a user, if I am allowed to configure a band name in the layer
page with spaces and other weird chars, I would really love my
decision to be respected to the extent where it's possible (GML does
not allow it, but it's the only GetFeaturInfo case).That said, it's a preference, I'm not hellbent on it, I just find
annoying to see GML limitations creeping out in other parts of the
code.In case you want to perform on the fly renaming the gt-transform
module has some support to perform the renames without having to
write custom code, although you'll have to first wrap the collection
in a feature source to use it (DataUtiltiies has a method to do
that).Does anyone object to this change? If so, I could look into making
this change elsewhere, for example, in the output format. I think
this will be uglier and make the formats inconsistent.Again just an opinion, but coming from a coverage background GML is
the ugly one hereCheers
Andrea--
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.Ing. Andrea Aime
@geowolf
Technical LeadGeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549http://www.geo-solutions.it
http://twitter.com/geosolutions_it*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica
e/o nel/i file/s allegato/i sono da considerarsi strettamente
riservate. Il loro utilizzo è consentito esclusivamente al
destinatario del messaggio, per le finalità indicate nel messaggio
stesso. Qualora riceviate questo messaggio senza esserne il
destinatario, Vi preghiamo cortesemente di darcene notizia via
e-mail e di procedere alla distruzione del messaggio stesso,
cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo,
od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.The information in this message and/or attachments, is intended
solely for the attention and use of the named addressee(s) and may
be confidential or proprietary in nature or covered by the
provisions of privacy act (Legislative Decree June, 30 2003, no.196
- Italy's New Data Protection Code).Any use not in accord with its
purpose, any disclosure, reproduction, copying, distribution, or
either dissemination, either whole or partial, is strictly forbidden
except previous formal approval of the named addressee(s). If you
are not the intended recipient, please contact immediately the
sender by telephone, fax or e-mail and delete the information in
this message that has been received in error. The sender does not
give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for
changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.-------------------------------------------------------
--
Ben Caradoc-Davies <ben@...4191...>
Director
Transient Software Limited <http://transient.nz/> New Zealand
------------------------------------------------------------------------------
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel