[Geoserver-devel] DataFeatureTypesEditorForm vs. TypesEditorForm

Hello,

I'm going through and trying to add the ability to select a
per-FeatureType option to geoserver. I've added the relevant fields to
the FeatureTypeConfig and FeatureTypeConfigDTO, and I've added the
fields to the correct places in the jsp and added messages and so-on.

However, just as I was finishing up adding the relevant fields and logic
to DataFeatureTypesEditorForm and finding where the relevant
"DataFeatureTypesEditorAction" file was, I ran into the
"TypesEditorForm" and "TypesEditorAction"

It would seem that TypesEditorAction/Form is the place to add such extra
per-featureType information. If that's the case, why does the class
"DataFeatureTypesEditorForm" exist? Is it used anywhere? Eclipse is
telling me that there are no references to it in the project...is that
correct? Should it be deprecated/deleted?

Just checking to make sure I'm not doing anything boneheaded!

--saul

Hi Saul,

I'm guessing it should be deleted, especially if nothing references it.
I will make sure it is looked into for next release. Thanks for finding it!

Brent Owens
TOPP

Saul Farber wrote:

Hello,

I'm going through and trying to add the ability to select a
per-FeatureType option to geoserver. I've added the relevant fields to
the FeatureTypeConfig and FeatureTypeConfigDTO, and I've added the
fields to the correct places in the jsp and added messages and so-on.

However, just as I was finishing up adding the relevant fields and logic
to DataFeatureTypesEditorForm and finding where the relevant
"DataFeatureTypesEditorAction" file was, I ran into the
"TypesEditorForm" and "TypesEditorAction"

It would seem that TypesEditorAction/Form is the place to add such extra
per-featureType information. If that's the case, why does the class
"DataFeatureTypesEditorForm" exist? Is it used anywhere? Eclipse is
telling me that there are no references to it in the project...is that
correct? Should it be deprecated/deleted?

Just checking to make sure I'm not doing anything boneheaded!

--saul

-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc. Get Certified Today
Register for a JBoss Training Course. Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

May be an earlier attempt at the functionality. We were trying to make them all consistent.

Jody