I am looking into DEFQueryFeatureLocking (my turn to comment code), and I am quite impressed with
this class.
It appears to be a decorator style wrapper that contains all the restrictions that are needed by GeoServer.
Enforcing FeatureType schema attribute order and so on.
However it appears that the class is not used to allow writing or locking? GeoTools2 has a way of saying this with out having half the methods throw UnsuprtedOpperationExceptions...
Only declare the interface that you can meet. I would like to change this decorator to only support the FeatureSource interface. The Transaction code already recognizes if a FeatureSource does not implement FeatureStore and can generate useful error messages if we let it.
I am going to try the change on the config branch - I will comment out the unused methods for now.
Jody