[Geoserver-devel] dropping vpf extension

GeoServer GeoServer Developer
1

I had a chance to test the VPF DataStore today, turns out the tests have been commented out for some time.

The DataStore implementation was not updated to the GeoTools 2.5 feature model, so while it compiles, is is never able to serve up any features.

Actions:

If I can ask for a review of the above pull request please.

Jody

2

Jody,

+1 for dropping the vpf extensions. However, you also need to remove:

<descriptor>release/ext-vpf.xml</descriptor>

from src/pom.xml . If this entry is not removed, the assembly step will likely fail as the pom references a file that you have removed.

Kind regards,
Ben.

On 02/09/13 13:49, Jody Garnett wrote:

I had a chance to test the VPF DataStore today, turns out the tests have
been commented out for some time.

The DataStore implementation was not updated to the GeoTools 2.5 feature
model, so while it compiles, is is never able to serve up any features.

Actions:
- reopened https://jira.codehaus.org/browse/GEOT-2347
- issued a pull request to remove this format
https://github.com/geoserver/geoserver/pull/312

If I can ask for a review of the above pull request please.
--
Jody

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk

_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

3

Thanks Ben, I have updated the pull request. I would like to keep the implementation in GeoTools as I think this work can be salvaged with a bit of TLC.

···

On Mon, Sep 2, 2013 at 4:01 PM, Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com> wrote:

Jody,

+1 for dropping the vpf extensions. However, you also need to remove:

release/ext-vpf.xml

from src/pom.xml . If this entry is not removed, the assembly step will likely fail as the pom references a file that you have removed.

Kind regards,
Ben.

On 02/09/13 13:49, Jody Garnett wrote:

I had a chance to test the VPF DataStore today, turns out the tests have
been commented out for some time.

The DataStore implementation was not updated to the GeoTools 2.5 feature
model, so while it compiles, is is never able to serve up any features.

Actions:

If I can ask for a review of the above pull request please.

Jody

Learn the latest–Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Ben Caradoc-Davies Ben.Caradoc-Davies@anonymised.com
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

4

Sure, that sounds fine. I was tempted to suggest leaving the release vpf stuff but it is easy enough to restore from git and we will have a cleaner build with less extraneous cruft.

+1 for the new pull request. I have not tried it, but it looks convincing and we will find out pretty soon. :slight_smile:

Kind regards,
Ben.

On 02/09/13 14:06, Jody Garnett wrote:

Thanks Ben, I have updated the pull request. I would like to keep the
implementation in GeoTools as I think this work can be salvaged with a
bit of TLC.

On Mon, Sep 2, 2013 at 4:01 PM, Ben Caradoc-Davies
<Ben.Caradoc-Davies@anonymised.com <mailto:Ben.Caradoc-Davies@anonymised.com>> wrote:

    Jody,

    +1 for dropping the vpf extensions. However, you also need to remove:

    <descriptor>release/ext-vpf.__xml</descriptor>

    from src/pom.xml . If this entry is not removed, the assembly step
    will likely fail as the pom references a file that you have removed.

    Kind regards,
    Ben.

    On 02/09/13 13:49, Jody Garnett wrote:

        I had a chance to test the VPF DataStore today, turns out the
        tests have
        been commented out for some time.

        The DataStore implementation was not updated to the GeoTools 2.5
        feature
        model, so while it compiles, is is never able to serve up any
        features.

        Actions:
        - reopened https://jira.codehaus.org/__browse/GEOT-2347
        <https://jira.codehaus.org/browse/GEOT-2347&gt;
        - issued a pull request to remove this format
        https://github.com/geoserver/__geoserver/pull/312
        <https://github.com/geoserver/geoserver/pull/312&gt;

        If I can ask for a review of the above pull request please.
        --
        Jody

        ------------------------------__------------------------------__------------------
        Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012,
        more!
        Discover the easy way to master current and previous Microsoft
        technologies
        and advance your career. Get an incredible 1,500+ hours of
        step-by-step
        tutorial videos with LearnDevNow. Subscribe today and save!
        http://pubads.g.doubleclick.__net/gampad/clk?id=58040911&iu=__/4140/ostg.clktrk
        <http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk&gt;

        _________________________________________________
        Geoserver-devel mailing list
        Geoserver-devel@anonymised.com
        <mailto:Geoserver-devel@lists.sourceforge.net>
        https://lists.sourceforge.net/__lists/listinfo/geoserver-devel
        <https://lists.sourceforge.net/lists/listinfo/geoserver-devel&gt;

    --
    Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
    Software Engineer
    CSIRO Earth Science and Resource Engineering
    Australian Resources Research Centre

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

5

On Mon, Sep 2, 2013 at 7:49 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

I had a chance to test the VPF DataStore today, turns out the tests have
been commented out for some time.

The DataStore implementation was not updated to the GeoTools 2.5 feature
model, so while it compiles, is is never able to serve up any features.

Actions:
- reopened https://jira.codehaus.org/browse/GEOT-2347
- issued a pull request to remove this format
https://github.com/geoserver/geoserver/pull/312

+1 on removing the extension if nobody is up to maintain it (it got there
before we had clear rules
about the requirements for a module to be an extension, and just stayed
there I think).

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------