[Geoserver-devel] Duplicate LICENSE.txt

When merging https://github.com/geoserver/geoserver/pull/2023 , I noticed that we have (at least) two identical LICENSE.txt files in the codebase, one at LICENSE.txt and one at src/release/LICENSE.txt.

Does it make sense to add a build step to copy the top-level LICENSE file to release during packaging in order to avoid duplication?

Torben

If you can figure it out, go for it. May also be able to configure the assembly to reference the file a couple of levels up.

···

On 31 January 2017 at 10:34, Torben Barsballe <tbarsballe@anonymised.com> wrote:

When merging https://github.com/geoserver/geoserver/pull/2023 , I noticed that we have (at least) two identical LICENSE.txt files in the codebase, one at LICENSE.txt and one at src/release/LICENSE.txt.

Does it make sense to add a build step to copy the top-level LICENSE file to release during packaging in order to avoid duplication?

Torben


Check out the vibrant tech community on one of the world’s most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.com.366…sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


Jody Garnett

Looking into it, it is a bit more complicated than initially anticipated.

I did discover we have a third LICENSE.txt that is included in all extension bundles (e.g. http://sourceforge.net/projects/geoserver/files/GeoServer/2.10.1/extensions/geoserver-2.10.1-gdal-plugin.zip ) and hasn’t been updated in a few years. The contents are:

Geotools2 - OpenSource mapping toolkit
http://geotools.org
(C) 2002, Geotools Project Managment Committee (PMC)
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation;
version 2.1 of the License.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.

This seems like it should be updated? I think we can modify it to link to one of the other LICENSE.txt files instead, so we have at most 2, rather than 3 or 4 versions of the file.

Torben

···

On Tue, Jan 31, 2017 at 11:06 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

If you can figure it out, go for it. May also be able to configure the assembly to reference the file a couple of levels up.


Jody Garnett

On 31 January 2017 at 10:34, Torben Barsballe <tbarsballe@anonymised.com> wrote:

When merging https://github.com/geoserver/geoserver/pull/2023 , I noticed that we have (at least) two identical LICENSE.txt files in the codebase, one at LICENSE.txt and one at src/release/LICENSE.txt.

Does it make sense to add a build step to copy the top-level LICENSE file to release during packaging in order to avoid duplication?

Torben


Check out the vibrant tech community on one of the world’s most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Update to the above - it looks like only a subset of the geotools-based extensions have the GeoTools2 license.

Separate from this, I noticed that many extensions do not include any sort of license in their packaging:

cas (security)
charts
control-flow
css
csw
feature-pregeneralized
grib
imagemap
imagemosaic-jdbc
importer-bdb
importer
inspire
libjpeg-turbo
monitor-hibernate
monitor
netcdf-out
netcdf
printing
querylayer
sqlserver
teradata
vectortile
wcs2_0-eo
wps-cluster-hazelcast
wps
xslt
ysld

Should these have licenses added, and if so, which ones

···

On Fri, Feb 3, 2017 at 10:46 AM, Torben Barsballe <tbarsballe@anonymised.com> wrote:

Looking into it, it is a bit more complicated than initially anticipated.

I did discover we have a third LICENSE.txt that is included in all extension bundles (e.g. http://sourceforge.net/projects/geoserver/files/GeoServer/2.10.1/extensions/geoserver-2.10.1-gdal-plugin.zip ) and hasn’t been updated in a few years. The contents are:

Geotools2 - OpenSource mapping toolkit
http://geotools.org
(C) 2002, Geotools Project Managment Committee (PMC)
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation;
version 2.1 of the License.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.

This seems like it should be updated? I think we can modify it to link to one of the other LICENSE.txt files instead, so we have at most 2, rather than 3 or 4 versions of the file.

Torben

On Tue, Jan 31, 2017 at 11:06 AM, Jody Garnett <jody.garnett@…403…> wrote:

If you can figure it out, go for it. May also be able to configure the assembly to reference the file a couple of levels up.


Jody Garnett

On 31 January 2017 at 10:34, Torben Barsballe <tbarsballe@anonymised.com> wrote:

When merging https://github.com/geoserver/geoserver/pull/2023 , I noticed that we have (at least) two identical LICENSE.txt files in the codebase, one at LICENSE.txt and one at src/release/LICENSE.txt.

Does it make sense to add a build step to copy the top-level LICENSE file to release during packaging in order to avoid duplication?

Torben


Check out the vibrant tech community on one of the world’s most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Consolidation of LICENSE.txt and src/release/LICENSE.txt here (should affect all core artifacts: war, system independant binary, and Windows/OS X installers): https://github.com/geoserver/geoserver/pull/2085

All the extensions use a different license file, which can be fixed separately, given that there seems to be additional issues there.

Torben

···

On Fri, Feb 3, 2017 at 12:08 PM, Torben Barsballe <tbarsballe@anonymised.com> wrote:

Update to the above - it looks like only a subset of the geotools-based extensions have the GeoTools2 license.

Separate from this, I noticed that many extensions do not include any sort of license in their packaging:

cas (security)
charts
control-flow
css
csw
feature-pregeneralized
grib
imagemap
imagemosaic-jdbc
importer-bdb
importer
inspire
libjpeg-turbo
monitor-hibernate
monitor
netcdf-out
netcdf
printing
querylayer
sqlserver
teradata
vectortile
wcs2_0-eo
wps-cluster-hazelcast
wps
xslt
ysld

Should these have licenses added, and if so, which ones

On Fri, Feb 3, 2017 at 10:46 AM, Torben Barsballe <tbarsballe@anonymised.com> wrote:

Looking into it, it is a bit more complicated than initially anticipated.

I did discover we have a third LICENSE.txt that is included in all extension bundles (e.g. http://sourceforge.net/projects/geoserver/files/GeoServer/2.10.1/extensions/geoserver-2.10.1-gdal-plugin.zip ) and hasn’t been updated in a few years. The contents are:

Geotools2 - OpenSource mapping toolkit
http://geotools.org
(C) 2002, Geotools Project Managment Committee (PMC)
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation;
version 2.1 of the License.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.

This seems like it should be updated? I think we can modify it to link to one of the other LICENSE.txt files instead, so we have at most 2, rather than 3 or 4 versions of the file.

Torben

On Tue, Jan 31, 2017 at 11:06 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

If you can figure it out, go for it. May also be able to configure the assembly to reference the file a couple of levels up.


Jody Garnett

On 31 January 2017 at 10:34, Torben Barsballe <tbarsballe@anonymised.com> wrote:

When merging https://github.com/geoserver/geoserver/pull/2023 , I noticed that we have (at least) two identical LICENSE.txt files in the codebase, one at LICENSE.txt and one at src/release/LICENSE.txt.

Does it make sense to add a build step to copy the top-level LICENSE file to release during packaging in order to avoid duplication?

Torben


Check out the vibrant tech community on one of the world’s most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel