2013/3/29 Milo van der Linden <milo@anonymised.com>
I am finished with the dutch translation and did a few minor fixes to
wicket html pages. If it is no burden to the team, I would like to
create a pull request, would that be convenient?
Great, an other language is close to 100%. I'm wondering if we could create
a blog post to state these improvements to the geoserver user community
Pull request its the way to get it into the mainline. If you have commit
access to the origin repository, you could push directly.
I also investigated the transifex translation process, but for now
this would be like driving to Amsterdam through Paris (no offense). I
would gladly pick up translating through transifex from now on, but
would it be possible for now to do it through the pull request?
Absolutely! Its independent from where you have edited the files. I would
suggest to create a pull request either way. Nevertheless you could upload
the *_nl.properties files to transifex afterwards or right now OR you could
use the transifex client tool to do it for you (for the defined resources).
I checked and my commits are all later then the last commit
(
https://github.com/geoserver/geoserver/commit/704becf3fad02f29b7b74b8d5a3abc6b316a64cf
)
in http://github.com/geoserver/geoserver, so if nobody has local
pending changes to any of the wicket files, merging should be easy.
The commit affects:
- 1 added line in
src/web/core/src/main/resources/GeoServerApplication.properties
- 4 html files that where missing a wicket tag or with a minor
cosmetic correction
- 7 new _nl.properties files
Please separate it into two pull requests, one for the additional i18
support (have you created an issue for this?) and one for updating the
Dutch properties files. This procedure would make it easier to apply this
change to several branches (e.g. master and 2.3.x). And please create a
branch from master/2.3.x and push it to your private geoserver github clone
repository. Please follow the common instructions at github :
https://help.github.com/articles/creating-a-pull-request
Please let me know if and when I can create a pull request.
Whenever you are ready create a request. You are free to add additional
commits after you have created the pull request. Just push these commits to
your working-branch.
Cheers
------------------------------------------------------------------------------
Own the Future-Intel(R) Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest. Compete
for recognition, cash, and the chance to get your game on Steam.
$5K grand prize plus 10 genre and skill prizes. Submit your demo
by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel