[Geoserver-devel] Factoring out the kml code in its own module

GeoServer GeoServer Developer
1

Hi,
some time ago while discussing the KML module refactor Justin suggested we separate
the KML code in its own module. So I did:
https://github.com/geoserver/geoserver/pull/153

Interesting tidbits about the pull request:

  • most of the pull request is a mere file move
  • however, the integration of the KML reflector required a bit of magic, as the
    DefaultWebMapService is defined in wms, but the reflector is in “kml”.
    Resolved it using a Spring style AOP interceptor that wires up the reflector
    only when the kml module is in
  • some tests in wms were using KML output as a way to check which layers
    were used to generate a certain map, I’ve switched all of them to use
    GeoRSS instead, which provides the same kind of information (the list
    of used layer as the title element content)

The idea is that we’ll have a kml2 community module with the new kml work,
and people can just take kml out, kml2 in, and try the new code.

Cheers
Andrea

–

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

2

Nice work Andrea. +1 on the pull request.

Fancy trick the DefaultWebMapService :slight_smile:

···

On Tue, Feb 19, 2013 at 9:37 AM, Andrea Aime <andrea.aime@anonymised.com…> wrote:

Hi,
some time ago while discussing the KML module refactor Justin suggested we separate
the KML code in its own module. So I did:
https://github.com/geoserver/geoserver/pull/153

Interesting tidbits about the pull request:

  • most of the pull request is a mere file move
  • however, the integration of the KML reflector required a bit of magic, as the
    DefaultWebMapService is defined in wms, but the reflector is in “kml”.
    Resolved it using a Spring style AOP interceptor that wires up the reflector
    only when the kml module is in
  • some tests in wms were using KML output as a way to check which layers
    were used to generate a certain map, I’ve switched all of them to use
    GeoRSS instead, which provides the same kind of information (the list
    of used layer as the title element content)

The idea is that we’ll have a kml2 community module with the new kml work,
and people can just take kml out, kml2 in, and try the new code.

Cheers
Andrea

–

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.