[Geoserver-devel] Fake unique ids for GML 3.2 geometries?

GeoServer GeoServer Developer
1

Hi,
following up on CITE WFS 2.0 compliance failures, there are a lot of reports about not having a
id on geometry properties. Which is something reported already in Jira:

https://osgeo-org.atlassian.net/browse/GEOS-6141

Now… given that geometry properties in simple feature encoding are plain, not linked, would
you mind terribly if we just generate a random id to make the result schema compliant, without
any attempt to support a GetPropertyValue on the id?

Rationale, simple feature geometries do not have an ID anyways, and while one could be fabricated
by some smart concatenation of feature id and some tracking of parent geometries, the scenario itself
does not seem to make sense anyways, the geometry is fully encoded in the GML anyways (unlike
cases in complex features where the geometry might be shared and referred to).

Cheers
Andrea

···

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

2

+1. I think this is the right thing to do. I propose that you create the geometry gml:id with the feature gml:id + "." + propertyName.

app-schema configurations for GML 3.2 commonly use ClientProperty to set a gml:id on geometries to be schema-valid. Your implementation should check to see if there is a ClientProperty for an app-schema type, or be used only for simple features. app-schema unit tests cover gml:id set on geometries (e.g. Gsml32BoreholeWfsTest:64) so will detect if you break the ClientProperty behaviour.

Kind regards,
Ben.

On 23/11/17 07:28, Andrea Aime wrote:

Hi,
following up on CITE WFS 2.0 compliance failures, there are a lot of
reports about not having a
id on geometry properties. Which is something reported already in Jira:

https://osgeo-org.atlassian.net/browse/GEOS-6141

Now... given that geometry properties in simple feature encoding are plain,
not linked, would
you mind terribly if we just generate a random id to make the result schema
compliant, without
any attempt to support a GetPropertyValue on the id?

Rationale, simple feature geometries do not have an ID anyways, and while
one could be fabricated
by some smart concatenation of feature id and some tracking of parent
geometries, the scenario itself
does not seem to make sense anyways, the geometry is fully encoded in the
GML anyways (unlike
cases in complex features where the geometry might be shared and referred
to).

Cheers
Andrea

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/&gt;
New Zealand

3

On Wed, Nov 22, 2017 at 11:29 PM, Ben Caradoc-Davies <ben@anonymised.com>
wrote:

+1. I think this is the right thing to do. I propose that you create the
geometry gml:id with the feature gml:id + "." + propertyName.

Hum... that won't work in general, when a geometry contains another they
both have an id and that needs to be different... a count could be made for
sure.
I was leaning towards just using a random UUID instead, it's easier to
implement and the net effect is the same no?
In any case, I'll have better a look at implementing what you proposed.

app-schema configurations for GML 3.2 commonly use ClientProperty to set a
gml:id on geometries to be schema-valid. Your implementation should check
to see if there is a ClientProperty for an app-schema type, or be used only
for simple features. app-schema unit tests cover gml:id set on geometries
(e.g. Gsml32BoreholeWfsTest:64) so will detect if you break the
ClientProperty behaviour.

Yep, I plan to implement this only for simple features (on the fast GML
encoding path)

Cheers
Andrea

--

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

4

Hi Ben,
managed to follow your advice on the fast path. Looked at the binding based one too, there be dragons, big, scary ones (and it’s not needed
for GeoServer simple features). So I solved one and left a ticket for the other.

Here is a sample of the output, a case with nested geometries:

<sf:AggregateGeoFeature gml:id=“AggregateGeoFeature.f005”>
gml:descriptiondescription-f005</gml:description>
gml:namename-f005</gml:name>
gml:boundedBy
<gml:Envelope srsName=“urn:ogc:def:crs:EPSG::4326”>
gml:lowerCorner68.87 29.86</gml:lowerCorner>
gml:upperCorner71.96 32.19</gml:upperCorner>
</gml:Envelope>
</gml:boundedBy>
sf:multiPointProperty
<gml:MultiPoint srsName=“urn:ogc:def:crs:EPSG::4326”
gml:id=“AggregateGeoFeature.f005.multiPointProperty”>
gml:pointMember
<gml:Point gml:id=“AggregateGeoFeature.f005.multiPointProperty.1”>
gml:pos70.83 29.86</gml:pos>
</gml:Point>
</gml:pointMember>
gml:pointMember
<gml:Point gml:id=“AggregateGeoFeature.f005.multiPointProperty.2”>
gml:pos68.87 31.08</gml:pos>
</gml:Point>
</gml:pointMember>
gml:pointMember
<gml:Point gml:id=“AggregateGeoFeature.f005.multiPointProperty.3”>
gml:pos71.96 32.19</gml:pos>
</gml:Point>
</gml:pointMember>
</gml:MultiPoint>
</sf:multiPointProperty>
sf:doubleProperty2012.78</sf:doubleProperty>
sf:strPropertyMa quande lingues coalesce, li grammatica del resultant lingue es plu simplic e regulari quam ti del coalescent lingues. Li nov lingua franca va esser plu simplic e regulari quam li existent Europan lingues.</sf:strProperty>
sf:featureCodeBK030</sf:featureCode>
</sf:AggregateGeoFeature>

and the pull request that implements this:

https://github.com/geotools/geotools/pull/1754

Cheers
Andrea

···

On Thu, Nov 23, 2017 at 10:10 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

–

On Wed, Nov 22, 2017 at 11:29 PM, Ben Caradoc-Davies <ben@anonymised.com191…> wrote:

+1. I think this is the right thing to do. I propose that you create the geometry gml:id with the feature gml:id + “.” + propertyName.

Hum… that won’t work in general, when a geometry contains another they both have an id and that needs to be different… a count could be made for sure.
I was leaning towards just using a random UUID instead, it’s easier to implement and the net effect is the same no?
In any case, I’ll have better a look at implementing what you proposed.

app-schema configurations for GML 3.2 commonly use ClientProperty to set a gml:id on geometries to be schema-valid. Your implementation should check to see if there is a ClientProperty for an app-schema type, or be used only for simple features. app-schema unit tests cover gml:id set on geometries (e.g. Gsml32BoreholeWfsTest:64) so will detect if you break the ClientProperty behaviour.

Yep, I plan to implement this only for simple features (on the fast GML encoding path)

Cheers

Andrea

–

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

5

Andrea,

that looks great. I like the handling of nested geometries. I tested a local merge + GWC + GeoServer + app-schema online and everything passed.

Merged on master.

Kind regards,
Ben.

On 24/11/17 04:08, Andrea Aime wrote:

Hi Ben,
managed to follow your advice on the fast path. Looked at the binding based
one too, there be dragons, big, scary ones (and it's not needed
for GeoServer simple features). So I solved one and left a ticket for the
other.

Here is a sample of the output, a case with nested geometries:

<sf:AggregateGeoFeature gml:id="AggregateGeoFeature.f005">
<gml:description>description-f005</gml:description>
<gml:name>name-f005</gml:name>
<gml:boundedBy>
<gml:Envelope srsName="urn:ogc:def:crs:EPSG::4326">
<gml:lowerCorner>68.87 29.86</gml:lowerCorner>
<gml:upperCorner>71.96 32.19</gml:upperCorner>
</gml:Envelope>
</gml:boundedBy>
<sf:multiPointProperty>
<gml:MultiPoint srsName="urn:ogc:def:crs:EPSG::4326"
gml:id="AggregateGeoFeature.f005.multiPointProperty">
<gml:pointMember>
<gml:Point gml:id="AggregateGeoFeature.f005.multiPointProperty.1">
<gml:pos>70.83 29.86</gml:pos>
</gml:Point>
</gml:pointMember>
<gml:pointMember>
<gml:Point gml:id="AggregateGeoFeature.f005.multiPointProperty.2">
<gml:pos>68.87 31.08</gml:pos>
</gml:Point>
</gml:pointMember>
<gml:pointMember>
<gml:Point gml:id="AggregateGeoFeature.f005.multiPointProperty.3">
<gml:pos>71.96 32.19</gml:pos>
</gml:Point>
</gml:pointMember>
</gml:MultiPoint>
</sf:multiPointProperty>
<sf:doubleProperty>2012.78</sf:doubleProperty>
<sf:strProperty>Ma quande lingues coalesce, li grammatica del resultant
lingue es plu simplic e regulari quam ti del coalescent lingues. Li nov
lingua franca va esser plu simplic e regulari quam li existent Europan
lingues.</sf:strProperty>
<sf:featureCode>BK030</sf:featureCode>
</sf:AggregateGeoFeature>

and the pull request that implements this:

https://github.com/geotools/geotools/pull/1754

Cheers
Andrea

On Thu, Nov 23, 2017 at 10:10 AM, Andrea Aime <andrea.aime@anonymised.com>
wrote:

On Wed, Nov 22, 2017 at 11:29 PM, Ben Caradoc-Davies <ben@anonymised.com>
wrote:

+1. I think this is the right thing to do. I propose that you create the
geometry gml:id with the feature gml:id + "." + propertyName.

Hum... that won't work in general, when a geometry contains another they
both have an id and that needs to be different... a count could be made for
sure.
I was leaning towards just using a random UUID instead, it's easier to
implement and the net effect is the same no?
In any case, I'll have better a look at implementing what you proposed.

app-schema configurations for GML 3.2 commonly use ClientProperty to set
a gml:id on geometries to be schema-valid. Your implementation should check
to see if there is a ClientProperty for an app-schema type, or be used only
for simple features. app-schema unit tests cover gml:id set on geometries
(e.g. Gsml32BoreholeWfsTest:64) so will detect if you break the
ClientProperty behaviour.

Yep, I plan to implement this only for simple features (on the fast GML
encoding path)

Cheers
Andrea

--

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313 <+39%200584%20962313>
fax: +39 0584 1660272 <+39%200584%20166%200272>
mob: +39 339 8844549 <+39%20339%20884%204549>

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/&gt;
New Zealand