[Geoserver-devel] Few comments on geoserver admin webapp

GeoServer GeoServer Developer
1

Hi all,

1.- the Login.jsp misses internationalisation on the submit/reset button (I
have corrected it - see attached file)

2.- New.jsp : at line 25 a > was missing (</td) (see attached file).

3.- The error remains when filling a new namespace. Looking at the source,
org/vfny/geoserver/form/data/StylesEditorForm.java at line 60 fills the
filename with : style.getFilename().getPath(). At that moment getFilename()
returns null. A quick fix is to code : filename= null (see atached file) ; I
wonder whether the real form to call in that case (new style) shouldn't be
StylesNewForm.java ?

4.- For the data configuration, it would be nice to have on the left handside
menu, the namespace entry first, then datastores, styles and featureTypes. In
fact, when adding a new datastore, the logical path is is to create a new
namespace or check if a relevant one exists, then create the datastore and so
on. Having the menu in that order helps people for the different stages
during the configuration (tiles-defs.xml, line 204, menuForwards of
config.data definition, the value could be
value="config.data.store:config.data.namespace:config.data.style:config.data.type"
(see attached file)

5.- When asking for port (datastore), putting the default port for the chosen
dbms helps. I have put the 5432 on the ApplicationResources_fr.properties to
get help, but I believe this could be done somewhere else.

6.- Demo.jsp is not really self explanatory when using it for newcomers. At
least, info on input fields are necessary. The submit button misses
internationalisation (see attached file). What's deemed necessary is to draw
maps from shapefile datastores as it was in the gt2 WMS. For users, it is of
most importance to see data drawn on screen by just clicking on a hyperlink.

7.- ApplicationResources_fr.properties has been updated.

Otherwise, under Linux and Tomcat 5.0.19, the JSPCompiler works fine without
having the problems of Tomcat 4.1.x. Congratulations !!

didier

(attachments)

didier-proposed-fixes.tgz (11.2 KB)

2

Hi Richard thanks for the testing/feedback - I do have a couple of questions.

The frist question is to Chris Holmes: Could we get Richard commiter access to
GeoServer. He has provided help feedback and fixes for some months now.

Hi all,

1.- the Login.jsp misses internationalisation on the submit/reset button (I
have corrected it - see attached file)

Thanks - I think we try and use the <html:submit><html:reset> buttons were possible.

2.- New.jsp : at line 25 a > was missing (</td) (see attached file).

There are many New.jsp files - just to confirm you ment Namesspace new (guessing
based on #3)

3.- The error remains when filling a new namespace. Looking at the source,
org/vfny/geoserver/form/data/StylesEditorForm.java at line 60 fills the
filename with : style.getFilename().getPath(). At that moment getFilename()
returns null. A quick fix is to code : filename= null (see atached file) ; I
wonder whether the real form to call in that case (new style) shouldn't be
StylesNewForm.java ?

What we really would like is a dropdown list of all the "*.sld" files in the
styles directory.

4.- For the data configuration, it would be nice to have on the left
handside
menu, the namespace entry first, then datastores, styles and featureTypes. In
fact, when adding a new datastore, the logical path is is to create a new
namespace or check if a relevant one exists, then create the datastore and so
on. Having the menu in that order helps people for the different stages
during the configuration (tiles-defs.xml, line 204, menuForwards of
config.data definition, the value could be
value="config.data.store:config.data.namespace:config.data.style:config.data.type"
(see attached file)

5.- When asking for port (datastore), putting the default port for the chosen
dbms helps. I have put the 5432 on the ApplicationResources_fr.properties to
get help, but I believe this could be done somewhere else.

The code to do this is part of the Param objects provided by the
DataStoreFactory class. The only thing that was holding me back was not knowing
how to apply the default values. Chris directed me to just use them as initial
values during DataStore creation. I'll try and get to this one.

6.- Demo.jsp is not really self explanatory when using it for newcomers. At

least, info on input fields are necessary. The submit button misses
internationalisation (see attached file). What's deemed necessary is to draw
maps from shapefile datastores as it was in the gt2 WMS. For users, it is of
most importance to see data drawn on screen by just clicking on a hyperlink.

Demo is *really* new, and is a hack so that we don't have to cut and paste
queries into the TestServlet. The only reason WMS is ignored right now is that
it did not work on Friday and I don't know how to make a WMS request.

So if you know how to make some WMS requests lets put the in the UserBasic
conf/demo directory. We may need to modify the ActionForm to detect what
category of request is being made.

7.- ApplicationResources_fr.properties has been updated.

Thanks.

Otherwise, under Linux and Tomcat 5.0.19, the JSPCompiler works fine without
having the problems of Tomcat 4.1.x. Congratulations !!

That is Great -

As I understand it here is what works

      Tomcat 4.1.30 Tomcat 5.0.19 Resin 2.X Resin 3.X Jetty
      ------------- ------------- --------- --------- -----
PC yes yes yes no yes
Linux -- yes -- -- --

I have been test on Tomcat 3.1.30 on PC, and we have Linux/Tomcat 5.0.19 working
as well. The only thing we have not tested in Linux/Tomcat 4.1.x. Resin 3.X
seems broken on the UI side of things (often having to submit requests multiple
times, and experience of application hangs).

Maybe what we could do as a group that would help chris out is test the gaps in
the above table?

3

The frist question is to Chris Holmes: Could we get Richard commiter
access to
GeoServer. He has provided help feedback and fixes for some months
now.

Was thinking the same thought, and asked him if he wanted commit rights.
Was just going to run it by you and the other developers. So unless
anyone objects I'll put him on. Richard could you email me your
sourceforge user id?

> 3.- The error remains when filling a new namespace. Looking at the
source,
> org/vfny/geoserver/form/data/StylesEditorForm.java at line 60 fills
the
> filename with : style.getFilename().getPath(). At that moment
getFilename()
> returns null. A quick fix is to code : filename= null (see atached
file) ; I
> wonder whether the real form to call in that case (new style)
shouldn't be
> StylesNewForm.java ?

What we really would like is a dropdown list of all the "*.sld" files
in the
styles directory.

Well, at least that's what we'd really like for a next iteration. What
would also be nice is if we could figure out a way to upload files with
struts. Looks like there is a package to handle it, and I found this
little bit on google (I'm sure there's more)
http://www.tek-tips.com/gviewthread.cfm/pid/946/qid/812145
Anyone want to try it out? Richard with your new commit rights? You
can definitely have free domain over the style page, as no one else has
much time or inclination to touch it, though I'll try if nothing is
done after rc1. The next step after being able to upload and select
from a drop down list would be to have a text box where you could edit
the sld directly through the interface. And the final step imho is
when Andrea's legend builder reaches maturity and we can run it in an
applet on the page, with previews of the layer the user is making the
style for.

>
> 5.- When asking for port (datastore), putting the default port for
the chosen
> dbms helps. I have put the 5432 on the
ApplicationResources_fr.properties to
> get help, but I believe this could be done somewhere else.

The code to do this is part of the Param objects provided by the
DataStoreFactory class. The only thing that was holding me back was
not knowing
how to apply the default values. Chris directed me to just use them
as initial
values during DataStore creation. I'll try and get to this one.

Cool.

> 6.- Demo.jsp is not really self explanatory when using it for
newcomers. At

> least, info on input fields are necessary. The submit button misses
> internationalisation (see attached file). What's deemed necessary
is to draw
> maps from shapefile datastores as it was in the gt2 WMS. For users,
it is of
> most importance to see data drawn on screen by just clicking on a
hyperlink.

Demo is *really* new, and is a hack so that we don't have to cut and
paste
queries into the TestServlet. The only reason WMS is ignored right
now is that
it did not work on Friday and I don't know how to make a WMS request.

WMS is working quite nicely now, thanks Gabriel, Andrea and James. I'll
see if I can put up some requests... (though I really should just start
on oracle, I'm sorta procrastinating with this other stuff).

> Otherwise, under Linux and Tomcat 5.0.19, the JSPCompiler works
fine without
> having the problems of Tomcat 4.1.x. Congratulations !!

That is Great -

As I understand it here is what works

      Tomcat 4.1.30 Tomcat 5.0.19 Resin 2.X Resin 3.X Jetty
      ------------- ------------- --------- --------- -----
PC yes yes yes no yes
Linux -- yes -- -- --

I have been test on Tomcat 3.1.30 on PC, and we have Linux/Tomcat
5.0.19 working
as well. The only thing we have not tested in Linux/Tomcat 4.1.x.
Resin 3.X
seems broken on the UI side of things (often having to submit
requests multiple
times, and experience of application hangs).

Maybe what we could do as a group that would help chris out is test
the gaps in
the above table?

Yeah, that would be great. You could probably even borrow a wiki page
from GeoTools so everyone can update it. Having an explanation by the
no would also be helpful. To make a wiki I think you can just make a
link on one page, create the new page, and then orphan it by deleting
the original link you made. GeoServer can then just link to the page.

Chris

----------------------------------------------------------
This mail sent through IMP: https://webmail.limegroup.com/