[Geoserver-devel] Filter Parsing (errors and validation)

GeoServer GeoServer Developer
1

I've noticed that the Filter parser isnt good at validation or error
reporting. For example,
..
    <Filter>
         <equal>
                <PropertyName>STATE_NAME</PropertyName>
                <Literal>Delaware</Literal>
          </equal>
    </Filter>
..

(I'm using "equal" instead of "PropertyIsEqualTo")

This returns the entire dataset - it should give some sort of error.

Correcting this, but using lower-case 'L' literal instead of the
uppercase "L" Literal gives me this exception:

<ServiceException
locator="org.vfny.geoserver.requests.readers.XmlRequestReader">
      org.xml.sax.SAXException: Attempted to construct illegal filter:
Got to the end state of an incomplete filter, current state is
rightValue
</ServiceException>

I'd really like this to be a little smarter and provide better errors.
Does the Dave Zweirs XML Framework version of Filter parsing handle
this better?

dave

----------------------------------------------------------
This mail sent through IMP: https://webmail.limegroup.com/

2

dblasby@anonymised.com wrote:

I'd really like this to be a little smarter and provide better errors. Does the Dave Zweirs XML Framework version of Filter parsing handle
this better?

When I was writing Filter parsing using dzwiers's framework I was able to give quite detailed error messages.