[Geoserver-devel] fix assumtions about FeatureId.getID() being the full representational state of a feature identifier in transactions

GeoServer GeoServer Developer
1

Hey Justin,

as I was updating the wfs2-v branch to work against geotools trunk's
ResourceId work, I would need to commit the attached patch to
GeoServer trunk in order to <see subject>.

We discussed this already while working on the wfs2-v branch, but
wanted to get confirmation it'd be ok to commit it to trunk,
especially because it implies a scan of the results on
TransactionUpdate to get the updated FeatureIds.

Cheers,
Gabriel

--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.

(attachments)

transactionIds.patch (5.42 KB)

2

Looks fine to me. Commit as you please.

On Fri, Nov 11, 2011 at 8:25 AM, Gabriel Roldan <groldan@anonymised.com> wrote:

Hey Justin,

as I was updating the wfs2-v branch to work against geotools trunk’s
ResourceId work, I would need to commit the attached patch to
GeoServer trunk in order to .

We discussed this already while working on the wfs2-v branch, but
wanted to get confirmation it’d be ok to commit it to trunk,
especially because it implies a scan of the results on
TransactionUpdate to get the updated FeatureIds.

Cheers,
Gabriel

–
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

3

Great, thanks for the prompt reply. Committed at r16573.

Cheers,
Gabriel

On Fri, Nov 11, 2011 at 1:12 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Looks fine to me. Commit as you please.

On Fri, Nov 11, 2011 at 8:25 AM, Gabriel Roldan <groldan@anonymised.com> wrote:

Hey Justin,

as I was updating the wfs2-v branch to work against geotools trunk's
ResourceId work, I would need to commit the attached patch to
GeoServer trunk in order to <see subject>.

We discussed this already while working on the wfs2-v branch, but
wanted to get confirmation it'd be ok to commit it to trunk,
especially because it implies a scan of the results on
TransactionUpdate to get the updated FeatureIds.

Cheers,
Gabriel

--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.

--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.