[Geoserver-devel] Font REST API modified patch

GeoServer GeoServer Developer
1

On Thu, Oct 14, 2010 at 5:31 PM, jose garcia <josegar74@anonymised.com> wrote:

Hi

I modified the Font REST API to remove catalog stuff and use FontCache
class. I attach you the patches for geoserver and geotools, now created
using trunk.

Some comments:

* In FontCache systemFonts contains both faces and families, not sure if to
return the list of fonts we want both.

Hi Jose,
I've reviewed this patch and applied it to GeoTools 2.6.x and trunk

* The REST service extents MapResource class, producing a quite simple xml
representation. I think if needed better representation i have to check in
AbstractCatalogListResource (but not extending from this class). Any hint
about where to look to produce better output is welcome.
* Need to add test cases.

For this one you should discuss on the public ml, I'm not the maintainer of the
restconfig extension. I've reattached the patch affecting rest

Cheers
Andrea

-----------------------------------------------------
Ing. Andrea Aime
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584962313
fax: +39 0584962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-----------------------------------------------------

(attachments)

REST_Font_list.patch (2.07 KB)

2

Patch looks good to me. However I seem to remember some feedback from Tim about the rest api. Was that ever addressed? Regardless +1 on the patch. But if it would be nice to gather the feedback as jiras.

On Mon, Oct 25, 2010 at 6:47 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Thu, Oct 14, 2010 at 5:31 PM, jose garcia <josegar74@anonymised.com> wrote:

Hi

I modified the Font REST API to remove catalog stuff and use FontCache
class. I attach you the patches for geoserver and geotools, now created
using trunk.

Some comments:

  • In FontCache systemFonts contains both faces and families, not sure if to
    return the list of fonts we want both.

Hi Jose,
I’ve reviewed this patch and applied it to GeoTools 2.6.x and trunk

  • The REST service extents MapResource class, producing a quite simple xml
    representation. I think if needed better representation i have to check in
    AbstractCatalogListResource (but not extending from this class). Any hint
    about where to look to produce better output is welcome.
  • Need to add test cases.

For this one you should discuss on the public ml, I’m not the maintainer of the
restconfig extension. I’ve reattached the patch affecting rest

Cheers
Andrea

Ing. Andrea Aime
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584962313
fax: +39 0584962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.