[Geoserver-devel] format_options through the KMLReflector

Hi all,

I'm working on a feature that will add an optional format_options item and have been digging around the code. I can recognize a new item when using a full wms request by adding stuff to the FormatOptionsKvpParser and the applicationContext.xml. The problem comes when I try to use a kml_reflect request. The KMLReflector specified in the web.xml is org.vfny.geoserver.wms.servlets.KMLReflector, which is deprecated. The new org.vfny.geoserver.wms.responses.map.kml.KMLReflector I'm directed to use produces an error telling me it's not a javax.servlet.Servlet.

Where should I go from here? I don't want to add anything to the deprecated class, obviously. Am I missing something?

Thanks,
Wayne

--
Refractions Research
Suite 300 - 1207 Douglas St
Victoria, BC, V8W 2E7, Canada
ph: (250) 383-3022
fax:(250) 383-2140

Hi Wayne,

While deprecated, the wms.servlets.KMLReflector is still used unfortunatly. Its a bit of a mess. But the non-servlet reflector should be reachable via "/kml/wms". Example:

http://localhost:8080/geoserver/kml/wms?layers=topp:states

wheras the servlet based reflector is at:

localhost:8080/geoserver/wms/kml_reflect?layers=topp:states

-Justin

Wayne Fang wrote:

Hi all,

I'm working on a feature that will add an optional format_options item and have been digging around the code. I can recognize a new item when using a full wms request by adding stuff to the FormatOptionsKvpParser and the applicationContext.xml. The problem comes when I try to use a kml_reflect request. The KMLReflector specified in the web.xml is org.vfny.geoserver.wms.servlets.KMLReflector, which is deprecated. The new org.vfny.geoserver.wms.responses.map.kml.KMLReflector I'm directed to use produces an error telling me it's not a javax.servlet.Servlet.

Where should I go from here? I don't want to add anything to the deprecated class, obviously. Am I missing something?

Thanks,
Wayne

--
Justin Deoliveira
The Open Planning Project
jdeolive@anonymised.com

Hi Justin,

Thanks for the response. So should I make my changes to the wms.servlets.KMLReflector as well, knowing that it is deprecated but still in use?

Thanks,
Wayne

Justin Deoliveira wrote:

Hi Wayne,

While deprecated, the wms.servlets.KMLReflector is still used unfortunatly. Its a bit of a mess. But the non-servlet reflector should be reachable via "/kml/wms". Example:

http://localhost:8080/geoserver/kml/wms?layers=topp:states

wheras the servlet based reflector is at:

localhost:8080/geoserver/wms/kml_reflect?layers=topp:states

-Justin

Wayne Fang wrote:

Hi all,

I'm working on a feature that will add an optional format_options item and have been digging around the code. I can recognize a new item when using a full wms request by adding stuff to the FormatOptionsKvpParser and the applicationContext.xml. The problem comes when I try to use a kml_reflect request. The KMLReflector specified in the web.xml is org.vfny.geoserver.wms.servlets.KMLReflector, which is deprecated. The new org.vfny.geoserver.wms.responses.map.kml.KMLReflector I'm directed to use produces an error telling me it's not a javax.servlet.Servlet.

Where should I go from here? I don't want to add anything to the deprecated class, obviously. Am I missing something?

Thanks,
Wayne

--
Refractions Research
Suite 300 - 1207 Douglas St
Victoria, BC, V8W 2E7, Canada
ph: (250) 383-3022
fax:(250) 383-2140

If possible yes... although what we really need to do is have the deprecated reflector delegate to the new reflector. Which should be doable... just have to find the time :). So i leave it to you. If its easy, sure, if not dont worry about it.

-Justin

Wayne Fang wrote:

Hi Justin,

Thanks for the response. So should I make my changes to the wms.servlets.KMLReflector as well, knowing that it is deprecated but still in use?

Thanks,
Wayne

Justin Deoliveira wrote:

Hi Wayne,

While deprecated, the wms.servlets.KMLReflector is still used unfortunatly. Its a bit of a mess. But the non-servlet reflector should be reachable via "/kml/wms". Example:

http://localhost:8080/geoserver/kml/wms?layers=topp:states

wheras the servlet based reflector is at:

localhost:8080/geoserver/wms/kml_reflect?layers=topp:states

-Justin

Wayne Fang wrote:

Hi all,

I'm working on a feature that will add an optional format_options item and have been digging around the code. I can recognize a new item when using a full wms request by adding stuff to the FormatOptionsKvpParser and the applicationContext.xml. The problem comes when I try to use a kml_reflect request. The KMLReflector specified in the web.xml is org.vfny.geoserver.wms.servlets.KMLReflector, which is deprecated. The new org.vfny.geoserver.wms.responses.map.kml.KMLReflector I'm directed to use produces an error telling me it's not a javax.servlet.Servlet.

Where should I go from here? I don't want to add anything to the deprecated class, obviously. Am I missing something?

Thanks,
Wayne

--
Justin Deoliveira
The Open Planning Project
jdeolive@anonymised.com