[Geoserver-devel] Geofence drag and drop and JQuery version

GeoServer GeoServer Developer
1

Hi,
in GeoFence is possible to manage rules priority using drag and drop, this functionality was implemented using the library wicket-dnd (https://github.com/svenmeier/wicket-dnd).
After the Apache Wicket 7 upgrade the wicket-dnd library was also upgraded to a version that supports Apache Wicket 7, but the drag and drop functionality was not working.

Long story short, the drag and drop in GeoFence is not working because of the JQuery version used by GeoServer. Apache Wicket 7 and the wicket-dnd use JQuery 1.11.3 but GeoServer still includes JQuery 1.2.6.

To fix the drag and drop issue the version of JQuery imported by GeoServer needs to be upgraded to JQuery 1.11.3.

Looking for imports of JQuery library under geoserver/src returns the following paths:

./web/core/src/main/java/org/geoserver/web/GeoServerBasePage.html
./web/demo/src/main/java/org/geoserver/web/demo/PlainCodePage.html
./web/core/src/main/java/org/geoserver/web/wicket/CodeMirrorEditor.js
./web/core/src/main/java/org/geoserver/web/wicket/GeoServerTablePanel.html
./extension/wps/web-wps/src/main/java/org/geoserver/wps/web/SubProcessBuilder.html

None of this files is directly using JQuery for doing something, at the exception of CodeMirrorEditor all the imports of JQuery exists only because of the plugin inline-info.
Besides, in file CodeMirrorEditor the code that uses JQuery is commented.

The inline-info plugin is located in:
./web/core/src/main/java/org/geoserver/web/js/jquery.inline-info.js

and the source code for this plugin is available at:
https://github.com/chrispatterson/jquery-inline-info

This plugin is used to show tips to user directly in the input fields, when the user clicks in the input field the tip is removed allowing the user to enter the data.
Even if this plugin is imported by several files it is only used in GeoServerBasePage (to show username and password tips in the login fields) and in
GeoServerTablePanel (to show the tip Search in the filter field).

Sadly the inline-info plugin has not been updated in the last years and don't support JQuery 1.11.3.

So, if I didn't miss anything upgrading the JQuery 1.2.6 included by GeoServer to JQuery 1.11.3 can be resumed to find an alternative to the inline-info plugin.

I have tree possible solutions for this:

- Check if apache wicket 7 provides the same functionality as the inline-info plugin out of the box.
- Find a JQuery 1.11.3 plugin alternative.
- Change this inline-info plugin source to be compatible with JQuery 1.11.3 (not very difficult).

Any comments on this are welcome :slight_smile:

Best regards,

Nuno Oliveira

--

GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information.

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono
da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate
nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e
-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo
anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of
the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree
June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying,
distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender does not give any warranty or accept liability as the content,
accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which
arise as a result of e-mail transmission, viruses, etc.

2

On Tue, Apr 5, 2016 at 7:35 PM, nuno.oliveira <
nuno.oliveira@anonymised.com> wrote:

I have tree possible solutions for this:

- Check if apache wicket 7 provides the same functionality as the
inline-info plugin out of the box.
- Find a JQuery 1.11.3 plugin alternative.
- Change this inline-info plugin source to be compatible with JQuery
1.11.3 (not very difficult).

Hi Nuno,
my 2 cents on the matter, I'd go for something directly supported by
wicket7 if at all possible,
and if not, try to build a solution that works on top of the wicket7 own
jquery, instead
of adding a copy of jquery in the codebase

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

3

Hi,

Thank you for the feedback Andrea.

HTML5 give us the placeholder attribute that allow us to do the same thing as the inline-info plugin JQuery plugin:
http://www.w3schools.com/tags/att_input_placeholder.asp

Basically when declaring an input field in wicket we have to provide the placeholder attribute:

The only problem is that the placeholder attribute is not supported by older versions of Internet Explorer.
So I also used a JQuery plugin that will make placeholders possible in older versions of IE but will not do
anything if the browser supports the placeholder attribute:
https://github.com/mathiasbynens/jquery-placeholder

This plugin is compatible with the JQuery version used by Apache Wicket. The plugin will use the defined
placeholder attribute so no extra configuration required. To activate the plugin we only need to add the line:
$(‘input, textarea’).placeholder();

I manually tested this solution with recent version of browsers Firefox and Chrome and with Internet Explorer 8.

I will do a pull request with this changes.

Regards,

Nuno Oliveira

···

On Tue, Apr 5, 2016 at 7:35 PM, nuno.oliveira <nuno.oliveira@anonymised.com> wrote:

I have tree possible solutions for this:

  • Check if apache wicket 7 provides the same functionality as the inline-info plugin out of the box.
  • Find a JQuery 1.11.3 plugin alternative.
  • Change this inline-info plugin source to be compatible with JQuery 1.11.3 (not very difficult).

Hi Nuno,
my 2 cents on the matter, I’d go for something directly supported by wicket7 if at all possible,
and if not, try to build a solution that works on top of the wicket7 own jquery, instead
of adding a copy of jquery in the codebase

Cheers
Andrea

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

4

Thanks for watching out for the older browsers. Our customer base is generally stuck multiple generations back on Firefox and Internet Explorer.

(attachments)

image001.png

···

Chris Snider

Senior Software Engineer

Intelligent Software Solutions, Inc.

Description: Description: Description: cid:image001.png@...3926...

From: Nuno Oliveira [mailto:nuno.oliveira@…1268…]
Sent: Wednesday, April 06, 2016 7:10 AM
To: Andrea Aime <andrea.aime@…1268…>
Cc: Geoserver-devel geoserver-devel@lists.sourceforge.net
Subject: Re: [Geoserver-devel] Geofence drag and drop and JQuery version

Hi,

Thank you for the feedback Andrea.

HTML5 give us the placeholder attribute that allow us to do the same thing as the inline-info plugin JQuery plugin:

http://www.w3schools.com/tags/att_input_placeholder.asp

Basically when declaring an input field in wicket we have to provide the placeholder attribute:

<input id=“username” type=“text” name=“username” value=“” title=“username” placeholder=“username”

wicket:message=“title:username,placeholder:username”/>

The only problem is that the placeholder attribute is not supported by older versions of Internet Explorer.

So I also used a JQuery plugin that will make placeholders possible in older versions of IE but will not do

anything if the browser supports the placeholder attribute:

https://github.com/mathiasbynens/jquery-placeholder

This plugin is compatible with the JQuery version used by Apache Wicket. The plugin will use the defined

placeholder attribute so no extra configuration required. To activate the plugin we only need to add the line:

$(‘input, textarea’).placeholder();

I manually tested this solution with recent version of browsers Firefox and Chrome and with Internet Explorer 8.

I will do a pull request with this changes.

Regards,

Nuno Oliveira

Le mercredi 06 avril 2016 à 09:51 +0200, Andrea Aime a écrit :

On Tue, Apr 5, 2016 at 7:35 PM, nuno.oliveira <nuno.oliveira@…1268…> wrote:

I have tree possible solutions for this:

  • Check if apache wicket 7 provides the same functionality as the inline-info plugin out of the box.
  • Find a JQuery 1.11.3 plugin alternative.
  • Change this inline-info plugin source to be compatible with JQuery 1.11.3 (not very difficult).

Hi Nuno,

my 2 cents on the matter, I’d go for something directly supported by wicket7 if at all possible,

and if not, try to build a solution that works on top of the wicket7 own jquery, instead

of adding a copy of jquery in the codebase

Cheers

Andrea

–

==

GeoServer Professional Services from the experts! Visit

http://goo.gl/it488V for more information.

==

Ing. Andrea Aime

@geowolf

Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)

phone: +39 0584 962313

fax: +39 0584 1660272

mob: +39 339 8844549

http://www.geo-solutions.it

http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

-- 

==

GeoServer Professional Services from the experts! 

Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.

==

Nuno Miguel Carvalho Oliveira

@nmcoliveira

Software Engineer



GeoSolutions S.A.S.

Via di Montramito 3/A

55054  Massarosa (LU)

Italy



phone: +39 0584 962313

fax:   +39 0584 1660272

mob:   +39  333 8128928



[http://www.geo-solutions.it](http://www.geo-solutions.it)

[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)



-------------------------------------------------------



AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono

da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate

nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e

-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo

anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai

principi dettati dal D.Lgs. 196/2003.

 

The information in this message and/or attachments, is intended solely for the attention and use of

the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree

June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying,

distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named

addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the

information in this message that has been received in error. The sender does not give any warranty or accept liability as the content,

accuracy or completeness of sent messages and accepts no responsibility  for changes made after they were sent or for other risks which

arise as a result of e-mail transmission, viruses, etc.
5

Thanks for the extensive research, do we actually make use of the inline-info functionality anywhere?

When I was experimenting with providing feedback the wicket documentation indicated we could provide per field warnings - something I was unable to get to work due to “how wicket was setup in geoserver”. As a result we have any form or data entry earnings listed at the top of the page. I am sorry I do not have further details on how we got to that position.

···

On 5 April 2016 at 10:35, nuno.oliveira <nuno.oliveira@anonymised.com> wrote:

Hi,
in GeoFence is possible to manage rules priority using drag and drop, this functionality was implemented using the library wicket-dnd (https://github.com/svenmeier/wicket-dnd).
After the Apache Wicket 7 upgrade the wicket-dnd library was also upgraded to a version that supports Apache Wicket 7, but the drag and drop functionality was not working.

Long story short, the drag and drop in GeoFence is not working because of the JQuery version used by GeoServer. Apache Wicket 7 and the wicket-dnd use JQuery 1.11.3 but GeoServer still includes JQuery 1.2.6.

To fix the drag and drop issue the version of JQuery imported by GeoServer needs to be upgraded to JQuery 1.11.3.

Looking for imports of JQuery library under geoserver/src returns the following paths:

./web/core/src/main/java/org/geoserver/web/GeoServerBasePage.html
./web/demo/src/main/java/org/geoserver/web/demo/PlainCodePage.html
./web/core/src/main/java/org/geoserver/web/wicket/CodeMirrorEditor.js
./web/core/src/main/java/org/geoserver/web/wicket/GeoServerTablePanel.html
./extension/wps/web-wps/src/main/java/org/geoserver/wps/web/SubProcessBuilder.html

None of this files is directly using JQuery for doing something, at the exception of CodeMirrorEditor all the imports of JQuery exists only because of the plugin inline-info.
Besides, in file CodeMirrorEditor the code that uses JQuery is commented.

The inline-info plugin is located in:
./web/core/src/main/java/org/geoserver/web/js/jquery.inline-info.js

and the source code for this plugin is available at:
https://github.com/chrispatterson/jquery-inline-info

This plugin is used to show tips to user directly in the input fields, when the user clicks in the input field the tip is removed allowing the user to enter the data.
Even if this plugin is imported by several files it is only used in GeoServerBasePage (to show username and password tips in the login fields) and in
GeoServerTablePanel (to show the tip Search in the filter field).

Sadly the inline-info plugin has not been updated in the last years and don’t support JQuery 1.11.3.

So, if I didn’t miss anything upgrading the JQuery 1.2.6 included by GeoServer to JQuery 1.11.3 can be resumed to find an alternative to the inline-info plugin.

I have tree possible solutions for this:

  • Check if apache wicket 7 provides the same functionality as the inline-info plugin out of the box.
  • Find a JQuery 1.11.3 plugin alternative.
  • Change this inline-info plugin source to be compatible with JQuery 1.11.3 (not very difficult).

Any comments on this are welcome :slight_smile:

Best regards,

Nuno Oliveira

–

GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information.

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono
da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate
nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e
-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo
anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of
the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree
June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying,
distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender does not give any warranty or accept liability as the content,
accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which
arise as a result of e-mail transmission, viruses, etc.

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Jody Garnett

6

On Thu, Apr 7, 2016 at 9:10 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

Thanks for the extensive research, do we actually make use of the
inline-info functionality anywhere?

We do, Nuno provided that information in it's first mail:

-----------------
This plugin is used to show tips to user directly in the input fields, when
the user clicks in the input field the tip is removed allowing the user to
enter the data.
Even if this plugin is imported by several files it is only used in
GeoServerBasePage (to show username and password tips in the login fields)
and in
GeoServerTablePanel (to show the tip Search in the filter field).
-----------------

When I was experimenting with providing feedback the wicket documentation
indicated we could provide per field warnings - something I was unable to
get to work due to "how wicket was setup in geoserver". As a result we have
any form or data entry earnings listed at the top of the page. I am sorry I
do not have further details on how we got to that position.

inline-info does not seem to be used for error reporting. If you're eager
to work on this though, you could start a separate thread to discuss it
(let's keep this one focused if at all possible).

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

7

Hi,

The pull request for this was made:
https://github.com/geoserver/geoserver/pull/1557

Best regards,

Nuno Oliveira

···

On Thu, Apr 7, 2016 at 9:10 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

Thanks for the extensive research, do we actually make use of the inline-info functionality anywhere?

We do, Nuno provided that information in it’s first mail:

This plugin is used to show tips to user directly in the input fields, when the user clicks in the input field the tip is removed allowing the user to enter the data.
Even if this plugin is imported by several files it is only used in GeoServerBasePage (to show username and password tips in the login fields) and in
GeoServerTablePanel (to show the tip Search in the filter field).

When I was experimenting with providing feedback the wicket documentation indicated we could provide per field warnings - something I was unable to get to work due to “how wicket was setup in geoserver”. As a result we have any form or data entry earnings listed at the top of the page. I am sorry I do not have further details on how we got to that position.

inline-info does not seem to be used for error reporting. If you’re eager to work on this though, you could start a separate thread to discuss it (let’s keep this one focused if at all possible).

Cheers
Andrea

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.