Hi Justin,
about <http://jira.codehaus.org/browse/GEOS-1815>, I wonder if it means:
a- ensuring the responses are encoded in the globally configured geoserver
charset
b- ensuring the http response header for the charset encoding is set
or both.
I guess both, as the issue does not tell just wanted to make sure.
Gabriel
Hi Gabriel,
I actually meant to assign this to myself... must have slipped. But if you want to take it by all means be my guest :).
So yeah... I think I meant more a), but b) is very much valid too. Although I think the dispatcher may already ensure that b) is done.
-Justin
Gabriel Roldán wrote:
Hi Justin,
about <http://jira.codehaus.org/browse/GEOS-1815>, I wonder if it means:
a- ensuring the responses are encoded in the globally configured geoserver charset
b- ensuring the http response header for the charset encoding is set
or both.I guess both, as the issue does not tell just wanted to make sure.
Gabriel
!DSPAM:4007,47e9335b39651336712104!
--
Justin Deoliveira
The Open Planning Project
jdeolive@anonymised.com
On Tuesday 25 March 2008 06:35:07 pm Justin Deoliveira wrote:
Hi Gabriel,
I actually meant to assign this to myself... must have slipped. But if
you want to take it by all means be my guest :).
np, it was cholmes choice.
So yeah... I think I meant more a), but b) is very much valid too.
Although I think the dispatcher may already ensure that b) is done.
Yeah, it seems for b we're covered by Dispatcher.
So it lays down to check every xml response in every service sets the
encoding, right?
cheers,
Gabriel
-Justin
Gabriel Roldán wrote:
> Hi Justin,
>
> about <http://jira.codehaus.org/browse/GEOS-1815>, I wonder if it means:
> a- ensuring the responses are encoded in the globally configured
> geoserver charset
> b- ensuring the http response header for the charset encoding is set
> or both.
>
> I guess both, as the issue does not tell just wanted to make sure.
>
>
> Gabriel
Gabriel Roldán ha scritto:
On Tuesday 25 March 2008 06:35:07 pm Justin Deoliveira wrote:
Hi Gabriel,
I actually meant to assign this to myself... must have slipped. But if
you want to take it by all means be my guest :).np, it was cholmes choice.
So yeah... I think I meant more a), but b) is very much valid too.
Although I think the dispatcher may already ensure that b) is done.Yeah, it seems for b we're covered by Dispatcher.
So it lays down to check every xml response in every service sets the encoding, right?
Hum ,in the 1.5.x code some of the XML transformer had the charset
encoding set as a property, so maybe it's not just the dispatcher
that needs it?
See for example:
http://svn.codehaus.org/geoserver/branches/1.5.x/geoserver/wfs/src/main/java/org/vfny/geoserver/wfs/responses/GML2FeatureResponseDelegate.java
line 139:
transformer.setEncoding(request.getWFS().getGeoServer().getCharSet());
Cheers
Andrea