[Geoserver-devel] [GEOS-3586] BIL/DDS MapProducer Unitests completed

GeoServer GeoServer Developer
1

Hi All,

As discussed on IRC the other day I have completed and committed the tests
sets for worldwind format outputs:

DDS test borrows from the GIF output test and extends
defaultmapproducertest. I would like the defaultmapproducertest to be more
generic and have less "image/gif" hardcoded bits. But that's just me. I
solved the issues mostly with copy-paste and replace.

The BilTest borrows from the getfeatureinfo test (thanks for the pointers
andrea) and checks that datablocks of certain byte size are returned
depending on the request i.e. byte , short and float. Also requests larger
than 512x512 generate a serviceexception. This output format essentially
misuses a WMS as a WCS since worldwind says that's how things should be.

I would like to get the module promoted to standard extension status. Thanks
for all your advice and help.

Cheers,

what_nick.
--
View this message in context: http://old.nabble.com/-GEOS-3586--BIL-DDS-MapProducer-Unitests-completed-tp26297466p26297466.html
Sent from the GeoServer - Dev mailing list archive at Nabble.com.

2

Great work what_nick! A few comments:

whatnick wrote:

Hi All,

As discussed on IRC the other day I have completed and committed the tests
sets for worldwind format outputs:

DDS test borrows from the GIF output test and extends
defaultmapproducertest. I would like the defaultmapproducertest to be more
generic and have less "image/gif" hardcoded bits. But that's just me. I
solved the issues mostly with copy-paste and replace.

Patches are more than welcome for such things. It would be great if you could refactor out the specific bits. The copy and paste approach is definitely frowned upon unless its some experimental stuff.

The BilTest borrows from the getfeatureinfo test (thanks for the pointers
andrea) and checks that datablocks of certain byte size are returned
depending on the request i.e. byte , short and float. Also requests larger
than 512x512 generate a serviceexception. This output format essentially
misuses a WMS as a WCS since worldwind says that's how things should be.

I would like to get the module promoted to standard extension status. Thanks
for all your advice and help.

That is great. This doc outlines the process to do so:

http://docs.geoserver.org/1.7.x/en/developer/policies/community-modules.html

-Justin

Cheers,

what_nick.

--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

3

Since I am still in the community bin i.e. experimental I will get away with
the copy pastery. Still need to add a few things such as community profile
entry and web profile entry.

I may need to discuss with the original writer of the default map producer
test before I make any changes. Don't want to break stuff that already
works. Well I will be breaking the tests. I will try out the changes in my
local copy and see how many dominos fall.

Cheers,

what_nick.
--
View this message in context: http://old.nabble.com/-GEOS-3586--BIL-DDS-MapProducer-Unitests-completed-tp26297466p26313511.html
Sent from the GeoServer - Dev mailing list archive at Nabble.com.

4

DDS Module promotion pathway

# Please give feedback--

The module is considered “stable” by the majority of the PSC

A module will only be promoted if it is deemed “stable” by the majority of
the PSC. Those PSC members deeming it “unstable” must provide a reasonable
justification for the assertion.

# I have written some simple unit test emulating getfeatureinfo (WCS like)
and getmap,format gif

The module maintains 40% test coverage

A minimum of 40% test coverage must be maintained by the module in order to
be promoted. Of course higher coverage is encouraged. The more test coverage
a community module the more credibility it gets.

# I module makes calls to worldwind.jar I see no explicit IP violations but
I am no lawyer

The module has no IP violations

The module must not contain any code with a license or copyright that
violates the GPL.

# Where do I create the said user manual page ?

The module has a page in the user manual

Each module needs a page in the user manual documenting its function and
usage. Tutorials and walk-throughs are encouraged.

# I can sign stuff - please don't take me to court :slight_smile:

The maintainer has signed the GeoServer Contributor Agreement

The Open Planning Project (TOPP) retains all copyright on code released as
part of GeoServer. Since core and extension modules are released along with
the rest of GeoServer, the maintainer of said modules must agree to assign
copyright of code to TOPP.

--
View this message in context: http://old.nabble.com/-GEOS-3586--BIL-DDS-MapProducer-Unitests-completed-tp26297466p26498556.html
Sent from the GeoServer - Dev mailing list archive at Nabble.com.

5

Hi what_nick,
When I try to run the test you have provided I get the “There is no support for creating maps in image/bil format” exception from geoserver.
I have a eclipse setup for debugging geoserver and I have put your BilMapProducer in the wms project and run a “maven clean install” command. I guess geoserver does not load your BilMapProducer, do you have a clue on how to enable it?

baris

On Tue, Nov 24, 2009 at 18:44, whatnick <tisham@anonymised.com.> wrote:

DDS Module promotion pathway

Please give feedback–

The module is considered “stable” by the majority of the PSC

A module will only be promoted if it is deemed “stable” by the majority of
the PSC. Those PSC members deeming it “unstable” must provide a reasonable
justification for the assertion.

I have written some simple unit test emulating getfeatureinfo (WCS like)

and getmap,format gif

The module maintains 40% test coverage

A minimum of 40% test coverage must be maintained by the module in order to
be promoted. Of course higher coverage is encouraged. The more test coverage
a community module the more credibility it gets.

I module makes calls to worldwind.jar I see no explicit IP violations but

I am no lawyer

The module has no IP violations

The module must not contain any code with a license or copyright that
violates the GPL.

Where do I create the said user manual page ?

The module has a page in the user manual

Each module needs a page in the user manual documenting its function and
usage. Tutorials and walk-throughs are encouraged.

I can sign stuff - please don’t take me to court :slight_smile:

The maintainer has signed the GeoServer Contributor Agreement

The Open Planning Project (TOPP) retains all copyright on code released as
part of GeoServer. Since core and extension modules are released along with
the rest of GeoServer, the maintainer of said modules must agree to assign
copyright of code to TOPP.

–
View this message in context: http://old.nabble.com/-GEOS-3586–BIL-DDS-MapProducer-Unitests-completed-tp26297466p26498556.html

Sent from the GeoServer - Dev mailing list archive at Nabble.com.

Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what’s new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel