[Geoserver-devel] [GEOS-7740]

tbarsballe · September 13, 2016, 6:25pm

Hello Neils,

You did most of the work on JDBCStore, correct? Any insight into GEOS-7740?

I think I have a fix, but I am still not quite sure why the issue was occuring in the first place. I can’t see any specific usage of ResourceNotification in JDBCStore.

Thanks,

Torben

Niels_Charlier · September 14, 2016, 10:03am

HI Torben,

I can't see your fix (it leads back to the same jira issue), but obviously ResourceNotification needs to be serializable in order to be published over a hazelcast cluster.

This doesn't have anything to do with jdbcstore, other than the fact that the default FileSystemResourceStore does not use a notification dispatcher at all (it simply watches the files, and does not need the cluster to communicate about resource changes). The issue is simply with the HzResourceNotificationDispatcher, nothing else.

What surprises me most, is that I did not come across this exception before, I did make a unit test for HzResourceNotificationDispatcher ??!

Regards

Niels

On 13-09-16 20:25, Torben Barsballe wrote:

Hello Neils,

You did most of the work on JDBCStore, correct? Any insight into GEOS-7740 <https://osgeo-org.atlassian.net/browse/GEOS-7740>?

I think I have a fix <https://osgeo-org.atlassian.net/browse/GEOS-7740>, but I am still not quite sure why the issue was occuring in the first place. I can't see any specific usage of ResourceNotification in JDBCStore.

Thanks,
Torben

tbarsballe · September 14, 2016, 3:49pm

Ah, sorry about the wrong link, fix is here.

Are there any resource stores other than JDBCStore that also use a notification dispatcher?

Torben

···

On Wed, Sep 14, 2016 at 3:03 AM, Niels Charlier <niels@anonymised.com> wrote:

HI Torben,

I can’t see your fix (it leads back to the same jira issue), but obviously ResourceNotification needs to be serializable in order to be published over a hazelcast cluster.

This doesn’t have anything to do with jdbcstore, other than the fact that the default FileSystemResourceStore does not use a notification dispatcher at all (it simply watches the files, and does not need the cluster to communicate about resource changes). The issue is simply with the HzResourceNotificationDispatcher, nothing else.

What surprises me most, is that I did not come across this exception before, I did make a unit test for HzResourceNotificationDispatcher ??!

Regards

Niels

On 13-09-16 20:25, Torben Barsballe wrote:

Hello Neils,

You did most of the work on JDBCStore, correct? Any insight into GEOS-7740?

I think I have a fix, but I am still not quite sure why the issue was occuring in the first place. I can’t see any specific usage of ResourceNotification in JDBCStore.

Thanks,

Torben

Niels_Charlier · September 14, 2016, 3:54pm

There are no other resource stores besides filesystembased and jdbc in the official geoserver.

However, I do know of at least one other resource store in a separate client project that uses notification dispatcher.

Regards
Niels

On 14-09-16 17:49, Torben Barsballe wrote:

Ah, sorry about the wrong link, fix is here <https://github.com/geoserver/geoserver/pull/1819>\.

Are there any resource stores other than JDBCStore that also use a notification dispatcher?

Torben

On Wed, Sep 14, 2016 at 3:03 AM, Niels Charlier <niels@anonymised.com <mailto:niels@anonymised.com>> wrote:

    HI Torben,

    I can't see your fix (it leads back to the same jira issue), but
    obviously ResourceNotification needs to be serializable in order
    to be published over a hazelcast cluster.

    This doesn't have anything to do with jdbcstore, other than the
    fact that the default FileSystemResourceStore does not use a
    notification dispatcher at all (it simply watches the files, and
    does not need the cluster to communicate about resource changes).
    The issue is simply with the HzResourceNotificationDispatcher,
    nothing else.

    What surprises me most, is that I did not come across this
    exception before, I did make a unit test for
    HzResourceNotificationDispatcher ??!

    Regards

    Niels

    On 13-09-16 20:25, Torben Barsballe wrote:

    Hello Neils,

    You did most of the work on JDBCStore, correct? Any insight into
    GEOS-7740 <https://osgeo-org.atlassian.net/browse/GEOS-7740>?

    I think I have a fix
    <https://osgeo-org.atlassian.net/browse/GEOS-7740>, but I am
    still not quite sure why the issue was occuring in the first
    place. I can't see any specific usage of ResourceNotification in
    JDBCStore.

    Thanks,
    Torben